chore(NODE-4285): rename csfle shared library references #3280
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adjust the AutoEncryption typings as indicated in the updated spec.
durran
previously approved these changes
Jun 1, 2022
dariakp
requested changes
Jun 1, 2022
Contributor
dariakp
left a comment
dariakp
left a comment
There was a problem hiding this comment.
I'd like to have a team discussion about the changes before we merge this
dariakp
reviewed
Jun 1, 2022
| encrypt(ns: string, cmd: Document, options: any, callback: Callback<Document>): void; | ||
| decrypt(cmd: Document, options: any, callback: Callback<Document>): void; | ||
| readonly csfleVersionInfo: { version: bigint; versionStr: string } | null; | ||
| readonly cryptSharedLibVersionInfo: { version: bigint; versionStr: string } | null; |
Contributor
There was a problem hiding this comment.
Would we also want to mark this property with a tag?
Contributor
Author
There was a problem hiding this comment.
Yeah, that makes sense. I think this is also the only AutoEncrypter property that you might still want to expose as public API in general.
dariakp
approved these changes
Jun 2, 2022
nbbeeken
approved these changes
Jun 2, 2022
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjust the AutoEncryption typings as indicated in the updated spec.
(Changes to libmongocrypt are in mongodb/libmongocrypt#352)
Description
What is changing?
Is there new documentation needed for these changes?
What is the motivation for this change?
Double check the following
npm run check:lintscript<type>(NODE-xxxx)<!>: <description>