PYTHON-3287 Reenable shared library testing #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
Waiting for the tests to pass. github says they've passed but they are still running: https://spruce.mongodb.com/version/629a679f56234351417498ad/tasks?sorts=STATUS%3AASC%3BBASE_STATUS%3ADESC |
Member
Author
|
I confirmed that test_crypt_shared is being run properly now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The changes in #352 caused the shared library tests to silently be skipped. This change fixes that and makes it less likely to happen in the future by adding the TEST_CRYPT_SHARED=1 env var. When TEST_CRYPT_SHARED=1 is set the test suite fails if crypt_shared cannot be loaded.