Reorganize content into tabs of controller preferences by JoergAtGithub · Pull Request #14006 · mixxxdj/mixxx

JoergAtGithub · 2024-12-09T22:32:24Z

Convert groupBoxSettings/groupBoxScreens into tabs
Show only the tabs, which have valid content in the current context
Sort tabs that settingsTab is shown by default, if controller settings are defined in mapping
Moved controller tabs below info and warning section
Made hyperlink warning label clickable and warning text select- and copy-able
Made warning label collapsing in height
Hide 'Mapping Info' fields if there is no content

This is a preparatory GUI cleanup, prior to the addition of further properties in additional tabs.

Before:

This PR:

Show only the tabs, which have valid content in the current context Sort tabs that settingsTab is shown by default, if controller settings are defined in mapping Moved controller tabs below info and warning section Made hyperlink warning label clickable and warning text select- and copy-able Made warning label collapsing in height Hide 'Mapping Info' fields if there is no content

Swiftb0y

LGTM otherwise. Thank you.

Swiftb0y

LGTM. Waiting for CI. @ronso0 do you have interest to take a quick look at the .ui changes?

ronso0 · 2024-12-11T00:49:52Z

Umm, looking at .ui diffs is pointless here. Before and after grid/layout items are in random order (that's why I usually reorder them so GUI order matches .ui order).
And I can't built main currently because I don't have hidapi 0.14.0

So if the screenshots reflect the current state of this PR and UX (correct tabstops etc.) is the same this LGTM 👍
Just the grids/2-column-layouts in Device Info / Mapping Info could be optimised so that eg. Mapping -> Description can use the available space.

Added tabstop section Unified some names Simplified top level frame/grid structure to a single grid

JoergAtGithub · 2024-12-14T20:44:56Z

I reordered the .ui file in GUI order.
I added a tabstop section.
But I could not find a way to use all the available vertical space in the grids/2-column-layouts in Device Info / Mapping Info. I tried for hours, and the only partially working solution was to set the spacer height from C++, which I consider more ugly than a little uneccessary whitespace.

ronso0 · 2024-12-14T23:45:38Z

I'll take a look asap, can build again with a libhidapi backport.

ronso0

my first review, will take another look soonish

ronso0 · 2024-12-30T06:41:35Z

A regression I noticed is that now the Input/Output tabs can't use the entire height of the dialog as before, mapping and device info will always occupy space at the top.

One solution would be to allow collapsing groupboxes.

subclass QGroupBox, add collapse/expand buttons, which I'd appreciate also for mappings with many options where I'm interested only in one or two settings catgeories.
Not trivial though..
add an expand/collapse toggle above Device / Mapping Info.
Much easier, but the toggle itself would occupy a row

ronso0 · 2024-12-30T06:45:27Z

Btw
QCheckBox "chkEnabledDevice" and QLabel "labelLoadMapping" are both in row="1" column="0".
This will probably never cause issues (overlap) because the checkbox is left-aligned (default) and the label is right-aligned, only if the entire dialog is very narrow and all device info fields are empty and the big, bold device name is very short and the mapping description is not empty.
Just saying..

on second thought, maybe that's intentional 🤷‍♂️

JoergAtGithub · 2024-12-30T09:48:25Z

Btw QCheckBox "chkEnabledDevice" and QLabel "labelLoadMapping" are both in row="1" column="0".

I also noticed this, but this is not new in this PR.

Added methods to count and find the first visible tab.

ronso0

Thanks, I'll do a test with some HID and MIDI gear... next year ; )

…ducing a boolean variable

JoergAtGithub · 2025-01-26T15:26:03Z

Thanks, I'll do a test with some HID and MIDI gear... next year ; )

@ronso0 Did you already found the time to test this?

ronso0 · 2025-01-26T15:32:24Z

Sorry, this got shifted down in my TODO list.
Will try to test tonight.

…tion

…izontally

ronso0

LGTM otherwise!

I opened JoergAtGithub#3 with some fixes:

Screens tab was always visible when built with QML off
finally managed to fix the random layout changes / v-stretch of the device / mapping info groupboxes
(this took hours, literally... sometimes Qt widget/layout props are a PITA)
nits

Tested with MIDI Through and Traktor S4mk3 (HID).
All looking good now with the fixup PR.

ronso0 · 2025-01-27T03:35:50Z

+    int firstVisibleTabIndex = getIndexOfFirstVisibleTabs();
+    if (firstVisibleTabIndex >= 0) {
+        m_ui.controllerTabs->setCurrentIndex(firstVisibleTabIndex);
+    }


Ux nit: when changing mappings, this would always reset to first visible tab.

We could save and (try to) restore the last selected tab.
This might be helpful for eg. quickly compare screens of two mappings.

I see your use case. But I think another use case is more important:
If a (new) user steps/scrolls through the list of mappings. Than it's likely that there was a mapping without controller settings beneth them. This means Midi In becomes the default - an expert setting, not intendend for average users. For them we introduced the controller settings, which should appear as default therefore.

ronso0 · 2025-01-27T20:23:15Z

+
+    // Store the index of the input and output mappings tabs
+    m_inputMappingsTabIndex = m_ui.controllerTabs->indexOf(m_ui.inputMappingsTab);
+    m_outputMappingsTabIndex = m_ui.controllerTabs->indexOf(m_ui.outputMappingsTab);
+    m_settingsTabIndex = m_ui.controllerTabs->indexOf(m_ui.settingsTab);
+    m_screensTabIndex = m_ui.controllerTabs->indexOf(m_ui.screensTab);


All tabs are visible by default (indices are correct), so let's move this to the top of the ctor, above the first call of slotShowMapping()?

I don't see any side effects, just saying..
When slotUpdate() is called to actually show the preferences indices are set.

DlgPrefController layout fixes

ronso0 · 2025-02-01T23:04:35Z

Okay, let's merge it then.
Thanks!

github-actions Bot added the controller backend label Dec 9, 2024

Swiftb0y reviewed Dec 10, 2024

View reviewed changes

Comment thread src/controllers/dlgprefcontroller.h

Swiftb0y approved these changes Dec 10, 2024

View reviewed changes

Reordered widgets according position in ui grid

e1f8a6b

Added tabstop section Unified some names Simplified top level frame/grid structure to a single grid

JoergAtGithub force-pushed the controller_pref_tab_layout branch from b0a87f9 to e1f8a6b Compare December 14, 2024 20:34

ronso0 added this to the 2.6-beta milestone Dec 28, 2024

ronso0 requested changes Dec 30, 2024

View reviewed changes

Comment thread src/controllers/dlgprefcontroller.cpp Outdated

Comment thread src/controllers/dlgprefcontroller.cpp Outdated

ronso0 added the preferences label Dec 30, 2024

Replaced dynamic tab addition/removal with setTabVisible.

e9ce649

Added methods to count and find the first visible tab.

JoergAtGithub requested a review from ronso0 December 30, 2024 14:06

ronso0 reviewed Dec 30, 2024

View reviewed changes

Comment thread src/controllers/dlgprefcontroller.cpp Outdated

Simplified the logic for showing/hiding MIDI controller tabs by intro…

1621866

…ducing a boolean variable

ronso0 mentioned this pull request Jan 6, 2025

Controller preferences: don't break support link texts #14079

Merged

ronso0 added 7 commits January 27, 2025 23:57

DlgPrefController: remove screens tab if QML flag is OFF

23db3db

DlgPrefController ui: remove useless rowstretch (ignored if all are 0)

e91729f

DlgPrefController ui: remove useless minimumSize from mapping descrip…

256c52a

…tion

DlgPrefController ui: keep device info small, expand mapping info hor…

e7bc252

…izontally

DlgPrefController ui: keep device/mapping info minimal vertically

ea36d91

DlgPrefController ui: remove "handling" from data protocol label

5a1dbc7

DlgPrefController: rename function, remove blank line

c48c17a

ronso0 reviewed Jan 27, 2025

View reviewed changes

Merge pull request #3 from ronso0/con-pref-tab-layout-fixes

6962a0a

DlgPrefController layout fixes

ronso0 merged commit f54d3f6 into mixxxdj:main Feb 1, 2025

JoergAtGithub deleted the controller_pref_tab_layout branch February 2, 2025 01:09

ronso0 mentioned this pull request Feb 16, 2025

(fix) Controller preferences: make Enabled checkbox clickable again #14354

Merged

acolombier mentioned this pull request Apr 7, 2025

fix(DlgPrefController): add missing layout #14606

Merged

Uh oh!

Conversation

JoergAtGithub commented Dec 9, 2024

Uh oh!

Swiftb0y left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Swiftb0y left a comment

Choose a reason for hiding this comment

Uh oh!

ronso0 commented Dec 11, 2024

Uh oh!

JoergAtGithub commented Dec 14, 2024

Uh oh!

ronso0 commented Dec 14, 2024

Uh oh!

ronso0 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ronso0 commented Dec 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ronso0 commented Dec 30, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JoergAtGithub commented Dec 30, 2024

Uh oh!

ronso0 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JoergAtGithub commented Jan 26, 2025

Uh oh!

ronso0 commented Jan 26, 2025

Uh oh!

ronso0 left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

ronso0 Jan 27, 2025

Choose a reason for hiding this comment

Uh oh!

JoergAtGithub Feb 1, 2025

Choose a reason for hiding this comment

Uh oh!

ronso0 Jan 27, 2025

Choose a reason for hiding this comment

Uh oh!

ronso0 Jan 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

ronso0 commented Feb 1, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

ronso0 commented Dec 30, 2024 •

edited

Loading

ronso0 commented Dec 30, 2024 •

edited

Loading

ronso0 left a comment •

edited

Loading

ronso0 Jan 27, 2025 •

edited

Loading