Skip to content

Controller preferences: don't break support link texts#14079

Merged
JoergAtGithub merged 1 commit intomixxxdj:2.5from
ronso0:controller-pref-dont-break-links
Feb 8, 2025
Merged

Controller preferences: don't break support link texts#14079
JoergAtGithub merged 1 commit intomixxxdj:2.5from
ronso0:controller-pref-dont-break-links

Conversation

@ronso0
Copy link
Copy Markdown
Member

@ronso0 ronso0 commented Dec 30, 2024

Before, links could be broken due to wordwrap="true" which is confusing, just weird and not necessary:
Mixxx Forums Mixxx
Manual Troublsehooting

Now it looks like this:
Mixxx Forums Mixxx Manual
Troublsehooting

@JoergAtGithub
Copy link
Copy Markdown
Member

I cannot reproduce this, because there is never a word wrap and always the horizontal scrollbar apears when the window width is reduced too much. This is independent if I youse 2.5 or this PR:
grafik

@ronso0
Copy link
Copy Markdown
Member Author

ronso0 commented Jan 6, 2025

Okay, 2.5 is the wrong target.
I think I noticed this with your PR #14006

Btw in main both device and mapping info is just cropped, there are no horizontal scrollbars:
image

@ronso0 ronso0 closed this Jan 6, 2025
@ronso0 ronso0 deleted the controller-pref-dont-break-links branch January 6, 2025 22:48
@ronso0 ronso0 restored the controller-pref-dont-break-links branch February 8, 2025 16:35
@ronso0 ronso0 reopened this Feb 8, 2025
@ronso0
Copy link
Copy Markdown
Member Author

ronso0 commented Feb 8, 2025

Reopening this since it's (still) happening with main: Mixxx / Manual is needlessly split
image

@JoergAtGithub
Copy link
Copy Markdown
Member

JoergAtGithub commented Feb 8, 2025

I just tried this with Main and reduced the dialog size to minimum width. I see no line break:
grafik

Not even if I reduce the height to minimum too:
grafik

@Swiftb0y
Copy link
Copy Markdown
Member

Swiftb0y commented Feb 8, 2025

these are different OSes? Maybe there are different platform specific defaults that cause this?

@ronso0
Copy link
Copy Markdown
Member Author

ronso0 commented Feb 8, 2025

Please try with the AKAI MPD24 mapping.
If other parts of the mapping description make the box expand it might look okay.

@JoergAtGithub
Copy link
Copy Markdown
Member

It works with 2.5 as with this PR. Code LGTM! Let's merge it therefore!

@JoergAtGithub JoergAtGithub merged commit 8b0381c into mixxxdj:2.5 Feb 8, 2025
@ronso0 ronso0 deleted the controller-pref-dont-break-links branch February 8, 2025 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants