(fix) Controller preferences: make Enabled checkbox clickable again#14354
Merged
Swiftb0y merged 1 commit intomixxxdj:mainfrom Feb 24, 2025
Merged
(fix) Controller preferences: make Enabled checkbox clickable again#14354Swiftb0y merged 1 commit intomixxxdj:mainfrom
Swiftb0y merged 1 commit intomixxxdj:mainfrom
Conversation
Member
|
Tested this and it works as expected! Thank you for the fix, I didn't noticed it until now. |
JoergAtGithub
approved these changes
Feb 17, 2025
ronso0
force-pushed
the
controller-pref-enabled-checkbox
branch
from
650210e to
67ffd97
Compare
Member
Author
|
Squashed, ready for merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #14006 both the Enabled checkbox and the 'Load mapping:' label are in the same cell of the QGridLayout.
The issue is: click events don't reach the checkbox anymore.
This can be fixed by putting the checkbox after the label in the ui file (ie. on top of the label, see first commit), but the better fix is to put both in a QHBoxLayout (fixup commit) since that also prevents checkbox / label overlap.
Is this actually an issue for anyone else? I'm building with Qt 6.2.3
If yes, does the first fix work you? (just curious, the QHBoxLayout should be merged)