Skip to content

DlgPrefController layout fixes#3

Merged
JoergAtGithub merged 7 commits intoJoergAtGithub:controller_pref_tab_layoutfrom
ronso0:con-pref-tab-layout-fixes
Feb 1, 2025
Merged

DlgPrefController layout fixes#3
JoergAtGithub merged 7 commits intoJoergAtGithub:controller_pref_tab_layoutfrom
ronso0:con-pref-tab-layout-fixes

Conversation

@ronso0
Copy link
Copy Markdown

@ronso0 ronso0 commented Jan 27, 2025

No description provided.

@ronso0
Copy link
Copy Markdown
Author

ronso0 commented Jan 27, 2025

Note that keepng the device info minimal was the only way to avoid random device/mapping info layout changes when going through the mapping list. I understand the horizontal 50/50 split for these groupboxes would be nice but I didn't find a way to set such a ratio and at the same time a) keep the layout static and b) give both groupboxes the space they need.
(actually 40/60 device strings don't seem to be long, but mapping descriptions can use more space)

Hope you agree with the removal of "handling".

@coveralls
Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 13000033798

Details

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage remained the same at 31.801%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/controllers/dlgprefcontroller.cpp 0 2 0.0%
Files with Coverage Reduction New Missed Lines %
src/controllers/dlgprefcontroller.cpp 2 0.0%
Totals Coverage Status
Change from base Build 12553291147: 0.0%
Covered Lines: 33336
Relevant Lines: 104828

💛 - Coveralls

@JoergAtGithub
Copy link
Copy Markdown
Owner

Hope you agree with the removal of "handling".

I would've prefered the old string, but it's also Ok for me.
What bothers me more is that the info boxes are no longer 50/50. I hope that we can find a solution for this at some point in the future.

@JoergAtGithub JoergAtGithub merged commit 6962a0a into JoergAtGithub:controller_pref_tab_layout Feb 1, 2025
@ronso0 ronso0 deleted the con-pref-tab-layout-fixes branch February 1, 2025 23:00
@ronso0
Copy link
Copy Markdown
Author

ronso0 commented Feb 1, 2025

Looks like this is not possible with sizepolicies in the ui file.
But maybe by doing some resizing in DlgPrefController::resizeEvent().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants