[rel/18.6] Remove stale Microsoft.Extensions.FileSystemGlobbing binding redirect - #16083
Merged
Amaury Levé (Evangelink) merged 1 commit intoJun 2, 2026
Conversation
…ng redirect Cherry-pick of the main fix (PR microsoft#16082) to unblock the rel/18.6 VMR build. testhost.x86 and datacollector neither reference Microsoft.Extensions.FileSystemGlobbing nor ship the DLL beside their EXE in the Microsoft.TestPlatform.CLI nupkg (TestHostNetFramework folder). Same anti-pattern as the DiagnosticSource fix (microsoft#15776). On main and rel/18.8 the _VerifyNuGetPackages target is skipped under DotNetBuild=true, so the latent issue is masked in the VMR. On rel/18.6 that skip is not present, so the hardened verifier (from microsoft#15778) running in the VMR pack catches the stale redirect and fails the build. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Amaury Levé (Evangelink)
enabled auto-merge (squash)
June 2, 2026 11:57
Jan Krivanek (JanKrivanek)
approved these changes
Jun 2, 2026
Amaury Levé (Evangelink)
deleted the
dev/amauryleve/remove-stale-filesystemglobbing-redirect-rel-18.6
branch
June 3, 2026 14:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #16082 to rel/18.6.
What
Remove the stale
Microsoft.Extensions.FileSystemGlobbing<bindingRedirect>fromsrc/testhost.x86/app.configandsrc/datacollector/app.config(kept insrc/vstest.console/app.config— the only EXE that legitimately usesFilePatternParserand ships the DLL beside itself).Why this matters specifically for rel/18.6
The rel/18.6 VMR build is failing on this check (see dnceng-public build 1435728):
In vstest's own pipeline this is masked because the verifier (
Find-ExeInPackagesineng/verify-binding-redirects.ps1) prefers a non-TestHostNetFrameworklocation and picks the EXEs fromMicrosoft.TestPlatform.nupkg'stools/net462/Common7/IDE/Extensions/TestPlatform/folder, whereMicrosoft.Extensions.FileSystemGlobbing.dllis sitting next to them. In the VMR,Microsoft.TestPlatform.csprojgatesIsPackableon'$(DotNetBuild)' != 'true'("relies on a VS license"), so onlyMicrosoft.TestPlatform.CLIis produced — and the EXEs end up in itscontentFiles/any/net10.0/TestHostNetFramework/folder where the DLL doesn't ship.On main/rel/18.8
_VerifyNuGetPackagesitself is skipped underDotNetBuild=true, so the latent stale redirect doesn't surface there. That skip was not backported to rel/18.6, so the hardened verifier (from #15778) running in the VMR pack catches the issue here.The cleanest fix is to remove the stale redirect (same anti-pattern as the
DiagnosticSourcefix in #15776 / #15765).