[fix] Harden binding redirect validation to catch missing DLLs by nohwnd · Pull Request #15778 · microsoft/vstest

Jakub Jareš (nohwnd) · 2026-05-14T11:01:16Z

verify-binding-redirects.ps1 silently skipped redirects whose DLL wasn't in the package layout. This allowed #15765 — the DiagnosticSource redirect shipped in testhost.exe.config but the DLL was excluded from the .nuspec.

Now it's an error: if the package exists but a redirect's target DLL is missing, the script fails. The whole-package-missing case (e.g. VMR where the exe isn't found at all) is still a skip.

Copilot

Pull request overview

This PR tightens packaging validation for binding redirects so redirects to assemblies missing from the package layout are treated as validation errors instead of being silently skipped.

Changes:

Detects binding redirects whose target DLL cannot be found in the extracted package layout.
Records those cases as validation errors and emits explicit error output.

Change verify-binding-redirects.ps1 to fail when a binding redirect references a DLL that isn't in the package layout. Previously this was silently skipped, which allowed microsoft#15765 — a redirect for DiagnosticSource 8.0.0.1 shipped in the config but the DLL was excluded from the package. The whole-package-missing case (VMR) is still a skip. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Jakub Jareš (nohwnd) · 2026-05-14T11:26:09Z

/iterate

Jakub Jareš (nohwnd) · 2026-05-14T11:29:24Z

/iterate

Jakub Jareš (nohwnd) · 2026-05-14T11:38:51Z

Warning

The push_to_pull_request_branch operation failed: Cannot push to fork PR: different repository names. The workflow token does not have permission to push to fork repositories.. The code changes were not applied.

Fixed the CI failure. The new validation in verify-binding-redirects.ps1 correctly caught two stale binding redirects in vstest.console/app.config that pointed to DLLs not shipped in the package layout:

System.Diagnostics.DiagnosticSource — explicitly excluded from the nuspec
System.Text.Encodings.Web — explicitly excluded from the nuspec

Removed both redirects. These were silently skipped before; now the hardened script surfaces them as errors, which is exactly what this PR is designed to do.

🔧 Iterated by PR Iteration Agent 🔧

….console The hardened validation script caught two more orphaned binding redirects in vstest.console/app.config — both DLLs are explicitly excluded from the CLI package nuspec. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Jakub Jareš (nohwnd) · 2026-05-14T11:44:06Z

pr is from fork, don't touch this anymore PR iterator. My bad.

- Missing-DLL errors now Write-Error instead of reporting success - CI message distinguishes version mismatches (auto-fixable) from missing-DLL errors (manual removal needed) - Addresses Copilot review comments on lines 133 and 138 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Comments suppressed due to low confidence (1)

eng/verify-binding-redirects.ps1:133

Missing DLLs are reported through the same $errors collection as version mismatches, so the CI failure still tells contributors to run the local auto-fix even though this case cannot be auto-fixed and requires either shipping the DLL or removing the redirect. The missing-DLL error should carry actionable remediation instead of falling through to the generic version-mismatch instructions.

                # failures (e.g. #15765). Fail so the redirect gets removed.
                # This cannot be auto-fixed — the redirect must be manually removed or the DLL shipped.
                $errors += "$($entry.ExeName): $assemblyName has a binding redirect but the DLL is not in the package layout"

Replace Unicode em-dash (U+2014) with ASCII hyphen in comments and strings. The em-dash gets corrupted to multi-byte garbage on CI's PowerShell, causing a parse error that breaks the entire validation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

It ships in the package, so allowing it would mask a future packaging regression. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

…soft#15778) * Error on binding redirects pointing to missing DLLs Change verify-binding-redirects.ps1 to fail when a binding redirect references a DLL that isn't in the package layout. Previously this was silently skipped, which allowed microsoft#15765 — a redirect for DiagnosticSource 8.0.0.1 shipped in the config but the DLL was excluded from the package. The whole-package-missing case (VMR) is still a skip. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Remove stale DiagnosticSource and Encodings.Web redirects from vstest.console The hardened validation script caught two more orphaned binding redirects in vstest.console/app.config — both DLLs are explicitly excluded from the CLI package nuspec. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix review feedback: fail locally on missing-DLL errors - Missing-DLL errors now Write-Error instead of reporting success - CI message distinguishes version mismatches (auto-fixable) from missing-DLL errors (manual removal needed) - Addresses Copilot review comments on lines 133 and 138 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix em-dash encoding in verify-binding-redirects.ps1 Replace Unicode em-dash (U+2014) with ASCII hyphen in comments and strings. The em-dash gets corrupted to multi-byte garbage on CI's PowerShell, causing a parse error that breaks the entire validation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Remove FileSystemGlobbing from allow-list It ships in the package, so allowing it would mask a future packaging regression. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Remove DiagnosticSource binding redirect from app.configs The binding redirect for System.Diagnostics.DiagnosticSource (8.0.0.1) was added in #15567 but the DLL is excluded from the CLI package during packaging. The redirect points to a version that doesn't ship, causing MissingMethodException on net462 with DisableAppDomain=true when a test triggers assembly resolution for DiagnosticSource. Fixes #15765 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * [fix] Harden binding redirect validation to catch missing DLLs (#15778) * Error on binding redirects pointing to missing DLLs Change verify-binding-redirects.ps1 to fail when a binding redirect references a DLL that isn't in the package layout. Previously this was silently skipped, which allowed #15765 — a redirect for DiagnosticSource 8.0.0.1 shipped in the config but the DLL was excluded from the package. The whole-package-missing case (VMR) is still a skip. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Remove stale DiagnosticSource and Encodings.Web redirects from vstest.console The hardened validation script caught two more orphaned binding redirects in vstest.console/app.config — both DLLs are explicitly excluded from the CLI package nuspec. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix review feedback: fail locally on missing-DLL errors - Missing-DLL errors now Write-Error instead of reporting success - CI message distinguishes version mismatches (auto-fixable) from missing-DLL errors (manual removal needed) - Addresses Copilot review comments on lines 133 and 138 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Fix em-dash encoding in verify-binding-redirects.ps1 Replace Unicode em-dash (U+2014) with ASCII hyphen in comments and strings. The em-dash gets corrupted to multi-byte garbage on CI's PowerShell, causing a parse error that breaks the entire validation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * Remove FileSystemGlobbing from allow-list It ships in the package, so allowing it would mask a future packaging regression. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…ng redirect (#16083) Cherry-pick of the main fix (PR #16082) to unblock the rel/18.6 VMR build. testhost.x86 and datacollector neither reference Microsoft.Extensions.FileSystemGlobbing nor ship the DLL beside their EXE in the Microsoft.TestPlatform.CLI nupkg (TestHostNetFramework folder). Same anti-pattern as the DiagnosticSource fix (#15776). On main and rel/18.8 the _VerifyNuGetPackages target is skipped under DotNetBuild=true, so the latent issue is masked in the VMR. On rel/18.6 that skip is not present, so the hardened verifier (from #15778) running in the VMR pack catches the stale redirect and fails the build. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…#16082) testhost.x86 and datacollector neither reference Microsoft.Extensions.FileSystemGlobbing nor ship the DLL beside their EXE in the Microsoft.TestPlatform.CLI nupkg (TestHostNetFramework folder). The stale redirect is the same anti-pattern fixed for DiagnosticSource in #15776: a redirect to an assembly that isn't shipped can cause MissingMethodException on net462 with DisableAppDomain=true. Only vstest.console references the assembly (via FilePatternParser), so the redirect is kept in src/vstest.console/app.config where the DLL ships next to vstest.console.dll. This is also the latent issue surfaced by the hardened verifier added in #15778 - currently visible on the rel/18.6 VMR build because (1) Microsoft.TestPlatform.nupkg (which ships the EXEs together with FileSystemGlobbing.dll under tools/net462/Common7/IDE/Extensions/TestPlatform/) is gated off when DotNetBuild=true, leaving the verifier to look only inside Microsoft.TestPlatform.CLI's TestHostNetFramework folder; and (2) the DotNetBuild != 'true' skip on _VerifyNuGetPackages was not backported to rel/18.6. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

…16090) The hardened binding-redirect verifier (#15778) is now catching four stale binding redirects in testhost.x86 and datacollector app.configs. The redirects point at versions that are higher than what actually ships beside the exe in the Microsoft.TestPlatform.CLI nupkg (TestHostNetFramework folder): | Assembly | Redirect | Shipped | |-----------------------------------------|----------|---------| | System.Runtime.CompilerServices.Unsafe | 6.0.3.0 | 6.0.0.0 | | System.Memory | 4.0.5.0 | 4.0.1.2 | | System.Buffers | 4.0.5.0 | 4.0.3.0 | | System.Collections.Immutable | 10.0.0.0 | 9.0.0.0 | These redirects were bumped by the auto-fix script in #15724 when those higher AV variants were present in the layout at the time, but the rel/18.6 package layout has since reverted to the older transitive versions. A redirect targeting a version that is not actually shipped causes FileLoadException at runtime in hosts without their own binding redirects (e.g. Azure DevOps Distributed Test Agent). Mirrors the auto-fix output of build.cmd -c Release: newVersion and the upper bound of oldVersion are narrowed to the actual shipped DLL version. vstest.console/app.config is intentionally left untouched - vstest.console.exe ships in Microsoft.TestPlatform.NonShipping packages that are not in the verifier's checked set and whose DLL versions are not verified here. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 14, 2026 11:01

Copilot started reviewing on behalf of Jakub Jareš (nohwnd) May 14, 2026 11:02 View session

Copilot AI reviewed May 14, 2026

View reviewed changes

Comment thread eng/verify-binding-redirects.ps1

Comment thread eng/verify-binding-redirects.ps1 Outdated

Jakub Jareš (nohwnd) force-pushed the fix-redirect-validation branch from 0c9bdca to cb7d691 Compare May 14, 2026 11:06

Jakub Jareš (nohwnd) changed the title ~~Fail validation when binding redirect points to missing DLL~~ [fix] Harden binding redirect validation to catch missing DLLs May 14, 2026

Copilot AI review requested due to automatic review settings May 14, 2026 11:43

Copilot started reviewing on behalf of Jakub Jareš (nohwnd) May 14, 2026 11:45 View session

Copilot AI reviewed May 14, 2026

View reviewed changes

Comment thread eng/verify-binding-redirects.ps1

Comment thread eng/verify-binding-redirects.ps1 Outdated

Jakub Jareš (nohwnd) and others added 2 commits May 14, 2026 14:04

Remove FileSystemGlobbing from allow-list

e673793

It ships in the package, so allowing it would mask a future packaging regression. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings May 14, 2026 14:28

Copilot started reviewing on behalf of Jakub Jareš (nohwnd) May 14, 2026 14:30 View session

Copilot AI reviewed May 14, 2026

View reviewed changes

Comment thread eng/verify-binding-redirects.ps1

Jakub Jareš (nohwnd) merged commit 039b7ea into microsoft:main May 14, 2026
14 of 17 checks passed

Jakub Jareš (nohwnd) mentioned this pull request May 14, 2026

Remove unnecessary binding redirects from app.configs #15786

Closed

dotnet-maestro Bot mentioned this pull request May 15, 2026

[main] Source code updates from microsoft/vstest dotnet/dotnet#6629

Merged

Jakub Jareš (nohwnd) mentioned this pull request May 15, 2026

[fix] Add binding redirect for System.Threading.Tasks.Extensions and ship DLL in TestHostNetFramework #15789

Closed

This was referenced Jun 2, 2026

Remove stale Microsoft.Extensions.FileSystemGlobbing binding redirect from testhost.x86 and datacollector #16082

Merged

[rel/18.6] Remove stale Microsoft.Extensions.FileSystemGlobbing binding redirect #16083

Merged

Amaury Levé (Evangelink) mentioned this pull request Jun 3, 2026

[rel/18.6] Fix stale binding redirects for SCRU/Memory/Buffers/SCI #16090

Merged

Navigation Menu

Uh oh!

[fix] Harden binding redirect validation to catch missing DLLs - #15778

[fix] Harden binding redirect validation to catch missing DLLs#15778
Jakub Jareš (nohwnd) merged 5 commits into
microsoft:mainfrom
nohwnd:fix-redirect-validation

Jakub Jareš (nohwnd) commented May 14, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Jakub Jareš (nohwnd) commented May 14, 2026

Uh oh!

Jakub Jareš (nohwnd) commented May 14, 2026

Uh oh!

Jakub Jareš (nohwnd) commented May 14, 2026

Uh oh!

Jakub Jareš (nohwnd) commented May 14, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

Jakub Jareš (nohwnd) commented May 14, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Jakub Jareš (nohwnd) commented May 14, 2026

Uh oh!

Jakub Jareš (nohwnd) commented May 14, 2026

Uh oh!

Jakub Jareš (nohwnd) commented May 14, 2026

Uh oh!

Jakub Jareš (nohwnd) commented May 14, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants