Skip to content

[release/10.0.3xx] Source code updates from microsoft/vstest - #6617

Merged
Evangelink merged 11 commits into
release/10.0.3xxfrom
darc-release/10.0.3xx-c535bee3-dea9-416b-864b-7a01f69aa9ba
Jun 4, 2026
Merged

[release/10.0.3xx] Source code updates from microsoft/vstest#6617
Evangelink merged 11 commits into
release/10.0.3xxfrom
darc-release/10.0.3xx-c535bee3-dea9-416b-864b-7a01f69aa9ba

Conversation

@dotnet-maestro

@dotnet-maestro dotnet-maestro Bot commented May 14, 2026

Copy link
Copy Markdown
Contributor

Note

This is a codeflow update. It may contain both source code changes from
the source repo
as well as dependency updates. Learn more here.

This pull request brings the following source code changes

From https://github.com/microsoft/vstest

Diff the source with this PR branch
darc vmr diff --name-only https://github.com/microsoft/vstest:d01a2fe02ca4ff81eb96f8647196a90c79a495e0..https://github.com/dotnet/dotnet:darc-release/10.0.3xx-c535bee3-dea9-416b-864b-7a01f69aa9ba

@dotnet-maestro

Copy link
Copy Markdown
Contributor Author

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@dotnet-policy-service
dotnet-policy-service Bot requested a review from a team May 14, 2026 17:26
@dotnet-maestro

Copy link
Copy Markdown
Contributor Author

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@lewing

lewing commented May 20, 2026

Copy link
Copy Markdown
Member

@dotnet/dotnet-testing-admin This code flow PR is 6 days old with Version.Details.props Validation failure and Windows x64/x86 build failures. Could you please investigate? QB daily triage.

@lewing

lewing commented May 30, 2026

Copy link
Copy Markdown
Member

@dotnet/dotnet-testing-admin Friendly reminder — this code flow PR is now 16 days old on release/10.0.3xx with 5 CI failures (including Windows x64/x86 verticals and Version.Details.props validation). Previous ping on May 20 received no response. Could someone from the vstest team please take a look or let us know if this branch update should be abandoned? QB daily triage.

@lewing

This comment was marked as duplicate.

@Evangelink

Copy link
Copy Markdown
Member

Hopefully this should fix the issue microsoft/vstest#16082

@lewing

lewing commented Jun 2, 2026

Copy link
Copy Markdown
Member

Thanks @Evangelink for the update \u2014 tracking microsoft/vstest#16082 as the fix. This PR is now 19 days old on release/10.0.3xx. Once the fix merges and flows, this codeflow PR should be superseded. Will monitor. QB daily triage.

@Evangelink

Copy link
Copy Markdown
Member

Thanks @Evangelink for the update \u2014 tracking microsoft/vstest#16082 as the fix. This PR is now 19 days old on release/10.0.3xx. Once the fix merges and flows, this codeflow PR should be superseded. Will monitor. QB daily triage.

@nohwnd is owner of VSTest, I am just doing back up while he is off because I got pinged by my manager :)

Copilot AI and others added 3 commits June 2, 2026 11:55
The _VerifyNuGetPackages target's binding-redirect check produces false
positives during the VMR product build because source-built dependency
packages can have different assembly versions than NuGet.org packages.
Gate the target on DotNetBuild != 'true', matching the fix already on
vstest main.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…ns.props

Version.Details.props already defines SystemCollectionsImmutableVersion
from the dependency flow; keeping the duplicate in Versions.props fails
the Version.Details.props validation merge policy.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@lewing

lewing commented Jun 2, 2026

Copy link
Copy Markdown
Member

Reverted the AfterSolutionBuild.targets guard (commit fc76e1b) — that change would have masked a real latent bug rather than fixing it.

The verify-nupkgs failure is actually caused by a stale Microsoft.Extensions.FileSystemGlobbing binding redirect in testhost.x86 and datacollector (same anti-pattern as the DiagnosticSource fix in microsoft/vstest#15776). The proper fix has been cherry-picked to rel/18.6 as microsoft/vstest#16083 (commit ce53df7, merged earlier today).

Status: waiting for codeflow. No BAR build with ce53df7 exists yet on the VS 18.6 channel — once the vstest official pipeline produces and publishes one, subscription 1d630943-bfb5-4bf4-874a-b82bd6871c15 will update this PR (currently at vstest e2f248, ~2 commits behind) to bring the fix in, and CI should go green.

The Versions.props dedup (commit 692691f) is orthogonal and stays.

@lewing

lewing commented Jun 3, 2026

Copy link
Copy Markdown
Member

QB daily triage (June 3) — this PR is now 20 days old on release/10.0.3xx. CI still has 4 failing checks.

Tracking microsoft/vstest#16082 for the upstream fix. @Evangelink — any update on when the fix will merge and flow? This is well past the 7-day staleness threshold and needs resolution.

cc @dotnet/dotnet-testing-admin

@Evangelink

Copy link
Copy Markdown
Member

This was merged yesterday, I don't really know how things are flowing and how long it usually take. Give me some time to figure this out

@dotnet-maestro

dotnet-maestro Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

@Evangelink
Evangelink enabled auto-merge June 3, 2026 20:15
@dotnet-policy-service
dotnet-policy-service Bot requested a review from a team June 3, 2026 20:16
@dotnet-maestro

dotnet-maestro Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor Author

Note

PRs from original repository included in this codeflow update:

💡 You may consult the FAQ for more information or tag @dotnet/prodconsvcs for assistance.

@dotnet-policy-service
dotnet-policy-service Bot requested a review from a team June 3, 2026 23:45
@Evangelink
Evangelink merged commit 71ac865 into release/10.0.3xx Jun 4, 2026
12 of 13 checks passed
@Evangelink
Evangelink deleted the darc-release/10.0.3xx-c535bee3-dea9-416b-864b-7a01f69aa9ba branch June 4, 2026 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants