[rel/18.7] Remove stale Microsoft.Extensions.FileSystemGlobbing binding redirect - #16084
Merged
Amaury Levé (Evangelink) merged 1 commit intoJun 2, 2026
Conversation
…ng redirect Cherry-pick of the main fix (PR microsoft#16082) for consistency with rel/18.6. testhost.x86 and datacollector neither reference Microsoft.Extensions.FileSystemGlobbing nor ship the DLL beside their EXE in the Microsoft.TestPlatform.CLI nupkg (TestHostNetFramework folder). Same anti-pattern as the DiagnosticSource fix (microsoft#15776). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Amaury Levé (Evangelink)
enabled auto-merge (squash)
June 2, 2026 11:57
Jan Krivanek (JanKrivanek)
approved these changes
Jun 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #16082 to rel/18.7.
What
Remove the stale
Microsoft.Extensions.FileSystemGlobbing<bindingRedirect>fromsrc/testhost.x86/app.configandsrc/datacollector/app.config(kept insrc/vstest.console/app.config).Why
Neither
testhost.x86.exenordatacollector.exereferences the assembly, and the DLL doesn't ship beside them in theMicrosoft.TestPlatform.CLInupkg'sTestHostNetFrameworkfolder. Same anti-pattern as theDiagnosticSourcefix in #15776.The active failure is on the rel/18.6 VMR build (see #16083); rel/18.7 carries the same stale redirect and the same missing
DotNetBuild != 'true'skip on_VerifyNuGetPackages, so this backport keeps the branches consistent and prevents the same VMR failure if rel/18.7 packs in that context.