Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Control over snippets #9286

Closed
3 tasks done
jrieken opened this issue Jul 14, 2016 · 10 comments
Closed
3 tasks done

Control over snippets #9286

jrieken opened this issue Jul 14, 2016 · 10 comments
Assignees
Labels
feature-request Request for new features or functionality
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Jul 14, 2016

There are many different expectation wrt snippets and we should introduce some user settings and command to tackle that

@jrieken jrieken self-assigned this Jul 14, 2016
@jrieken jrieken added this to the July 2016 milestone Jul 14, 2016
@jrieken jrieken added the feature-request Request for new features or functionality label Jul 14, 2016
@egamma
Copy link
Member

egamma commented Jul 14, 2016

Suggest to also add a setting to not show snippets in intellisense, e.g., top, bottom, natural, none.

@jrieken
Copy link
Member Author

jrieken commented Jul 15, 2016

better naming ideas? favourites? @aeschli @alexandrudima

  • snippetOrder: 'top' | 'bottom' | 'normal' or
  • snippetSuggestionsSortOrder: 'top' | 'bottom' | 'normal'; or
  • snippetSorting: 'top' | 'bottom' | 'normal'

and then analog to editor.wordBasedSuggestions I'd add

editor.snippetSuggestions: boolean,

@alexdima
Copy link
Member

I would go with one setting, it is IMHO more difficult for me to have to configure two settings which somewhat influence eachother

editor.snippetSuggestions : "top" | "bottom" | "mixed" | "none"

I would go for "mixed" or "inline" instead of "normal" because nobody knows what normal is :).

@alexdima
Copy link
Member

@jrieken Is this item changing also the out of the box sort order? (i.e. is #8758 really a dup of this one?)

@jrieken
Copy link
Member Author

jrieken commented Jul 15, 2016

Yeah, makes sense. To summarise: editor.snippetSuggestions : "top" | "bottom" | "inline" | "none" or instead of "inline" | "none" it could be boolean where true means inline and false means none?

@jrieken
Copy link
Member Author

jrieken commented Jul 15, 2016

snippetSuggestions: 'top' | 'bottom' | 'inline' | 'none'; it is

jrieken added a commit that referenced this issue Jul 15, 2016
jrieken added a commit that referenced this issue Jul 15, 2016
jrieken added a commit that referenced this issue Jul 20, 2016
jrieken added a commit that referenced this issue Jul 21, 2016
jrieken added a commit that referenced this issue Jul 25, 2016
new action 'Show Snippets' which opens quick pick with a list of snippets for the current mode
jrieken added a commit that referenced this issue Jul 25, 2016
@jrieken jrieken closed this as completed Jul 25, 2016
@shreyas-a
Copy link

is this feature live yet. if not when we can expect this

@dsifford
Copy link

dsifford commented Feb 7, 2017

@shreyas-a Yep, it's live. In your settings search for editor.snippetSuggestions. From there you can choose between top, bottom, inline, or none.

@shreyas-a
Copy link

Thanks, works perfectly. Don't you think the default option should be "inline"
I got easily confused about how my snippet suggestions suddenly started appearing at bottom. I'm sure many folks must be having same problem.

@potterdai
Copy link

There should be an option of "inline-top".
Using current "inline" option, snippets will always come last.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

6 participants