Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Something is severely different with intellisense and snippets #8758

Closed
alexdima opened this issue Jul 5, 2016 · 11 comments
Closed

Something is severely different with intellisense and snippets #8758

alexdima opened this issue Jul 5, 2016 · 11 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s)

Comments

@alexdima
Copy link
Member

alexdima commented Jul 5, 2016

I believe snippets were not offered before when the line had content on it.

I expect getTabFocusMode to be selected when intellisense pops up.

image

@alexdima alexdima added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority labels Jul 5, 2016
@alexdima alexdima added this to the June 2016 milestone Jul 5, 2016
@alexdima
Copy link
Member Author

alexdima commented Jul 5, 2016

1.2.1 shows the same bad behaviour

@alexdima
Copy link
Member Author

alexdima commented Jul 5, 2016

1.1.1 also looks bad

@alexdima
Copy link
Member Author

alexdima commented Jul 5, 2016

Works better in 0.10.6

image

@alexdima alexdima removed this from the June 2016 milestone Jul 5, 2016
@alexdima alexdima removed the important Issue identified as high-priority label Jul 5, 2016
@joaomoreno joaomoreno assigned jrieken, aeschli and joaomoreno and unassigned jrieken and aeschli Jul 6, 2016
@joaomoreno
Copy link
Member

@jrieken @aeschli We gotta get a grip on this. What has changed and why?

@jrieken jrieken removed their assignment Jul 6, 2016
@aeschli
Copy link
Contributor

aeschli commented Jul 6, 2016

There hasn't been any changes recently, but that the strategy:
To avoid that snippets are too prominent in the intellisense proposals:
Offer a snippet only if the name matches the current word or if the completion position is after a whitespace/new line.

We had a more restricting policy for a short time where we would offer snippets only after a whitespace/new line, but had to change that again after user complaints.

The sort order changes were made by @jrieken.
IMO snippets must go out of code complete and we should have a separate key.

@joaomoreno
Copy link
Member

IMO snippets must go out of code complete and we should have a separate key.

All in for that. Do we have a third, @jrieken ?

@jrieken
Copy link
Member

jrieken commented Jul 7, 2016

I agree but I know it's thin ice. Just add options to control snippet sorting. We have users that want snippets sorted to the top, we have users that want the opposite.

@empz
Copy link

empz commented Jul 9, 2016

Related issue: #6667

We already know there are people that want snippets on top of everything and other people that want them at the bottom. As I suggested in the related issue, I'm pretty sure the snippets lovers would we just fine if the snippets are shown on top only if the cursor is on a empty line and outside function parenthesis and object literal brackets.

@aeschli
Copy link
Contributor

aeschli commented Jul 14, 2016

duplicate of #5223

@aeschli aeschli closed this as completed Jul 14, 2016
@alexdima
Copy link
Member Author

@aeschli I'm sorry I do not agree this is a duplicate of #5223 - [sql] add support for mysql

@alexdima alexdima reopened this Jul 15, 2016
@joaomoreno
Copy link
Member

I believe he meant #9286

@alexdima alexdima mentioned this issue Jul 15, 2016
3 tasks
@aeschli aeschli added *duplicate Issue identified as a duplicate of another issue(s) and removed bug Issue identified by VS Code Team member as probable bug labels Jul 28, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s)
Projects
None yet
Development

No branches or pull requests

5 participants