-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autocomplete for "console.log()" in JavaScript and TypeScript is wrong. #9072
Comments
@VladimirAmiorkov do you have an extension installed that adds snippets. Looks like you selected a snippet. I can't reproduce this using 1.3.0 |
Please ping if you see this on a vanilla VSCode install. A test project showing the error would be helpful |
Hi @dbaeumer , I can confirm that without any extensions I can reproduce this issue in a TypeScript file (.ts) in JavaScript it seams to be ok after removing 3 extensions (TypeScript extension, Angular 2 and NativeScript). But the fact that it was ok for both TypeScript and JavaScript with those 3 extension before upgrading to the latest version is troubling. |
@jrieken assigning to you since this is not caused by TS/JS. Looks like that an extensions adds a snippet and the snippet now wins over the TS proposal. |
I do not own snippets |
As I understand the issue the user has an extension which snippets win over TS/JS proposal. Did something change in regards of sorting/priority. It seemed to work for 1.2.x |
@dbaeumer No - this is because TypeScript ships with a |
@jrieken yes I know, but we always did. @VladimirAmiorkov pointed out this happened after upgrading to 1.3.0 (see #9072 (comment)) For JS his problem disappeared after uninstalling the extensions. Interestingly we don't ship with a log snippet for JS. This is why I ask you whether something has changed in the code to pick the first match. For TS this is a very strange behavior and I don't know whether its is you or @joaomoreno. See the screen cast. When you first type the 'l' the log method is selected when you go back the snippet is selected. This is with VSCode 1.2.1 And this is with 1.3.x |
@aeschli owns the |
The problem is IMO not that the snippet proposal appears: Its name prefix-matches the current word, that's why it appears. The problem is that it get's ranked before any of the language proposals in particular the |
closing as duplicate of #9286 |
Steps to Reproduce:
It looks like not the method "log" is autocompleted but the entire class + function.
The text was updated successfully, but these errors were encountered: