Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Provide a separate 'Insert snippet' command that allows the user to pick a snippet #9697

Closed
3 tasks done
Tyriar opened this issue Jul 25, 2016 · 10 comments
Closed
3 tasks done
Assignees
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jul 25, 2016

Test for #9072, #9122, #6320, #9286:

There is a new command to insert snippets. Verify that

  • there is a Show Snippets command in F1, and that
  • it does what you expect
@Tyriar Tyriar added this to the July 2016 milestone Jul 25, 2016
@egamma egamma mentioned this issue Jul 25, 2016
89 tasks
@waderyan
Copy link

waderyan commented Jul 26, 2016

I'm not seeing a Show Snippets command.

image

On macOS.

@DonJayamanne
Copy link
Contributor

@waderyan, @Tyriar, that's odd I just tested this on my OSX and it works! Thought I'd mention that.
@Tyriar, yes I have tested this on windows and it works as expected (thought I'd test on OSX as well, as that's my primary OS)

@Tyriar
Copy link
Member Author

Tyriar commented Jul 27, 2016

@DonJayamanne are you on the same commit as Wade's in the screenshot?

@DonJayamanne
Copy link
Contributor

DonJayamanne commented Jul 27, 2016

@Tyriar, identital
screen shot 2016-07-27 at 12 57 38

screen shot 2016-07-27 at 12 59 08

@egamma
Copy link
Member

egamma commented Jul 27, 2016

Works for me on both OS X and Windows.

@egamma
Copy link
Member

egamma commented Jul 27, 2016

Suggest to make labels matching Snippets (Show Snippets, Preferences: Snippets) more distinct, e.g.,:
Expand Snippet, Preferences: Edit Snippets

image

@waderyan
Copy link

Ok I see it now. Weird it didn't show yesterday.

@bpasero
Copy link
Member

bpasero commented Aug 5, 2016

@jrieken maybe this was discussed when I was on vacation but is there a reason we cannot show the list of snippets in the intellisense widget (e.g. you invoke the command via keybinding and you get a list of suggestions filtered to all snippets)? I find it better to show the snippets closer to where I am typing.

@jrieken
Copy link
Member

jrieken commented Aug 5, 2016

Yeah, it's mostly to be aligned with other editors and to avoid ambiguity between snippets and the current line text wrt to filtering, selection etc. Last there technical debt that didn't allow it ;-) We figured ship it and wait for feedback ;-)

@bpasero
Copy link
Member

bpasero commented Aug 6, 2016

Ok. because I think it would be cool if I could assign a keybinding like

{ "key": "ctrl+space", "command": "editor.action.showSnippets", "when": "editorTextFocus && suggestWidgetVisible" }

And then essentially I could show snippets only by pressing Ctrl+Space twice (similar to Eclipse).

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

8 participants