[boost-modular-build-helper] Attempt to pass flags more correctly into b2 by ras0219-msft · Pull Request #23001 · microsoft/vcpkg

ras0219-msft · 2022-02-08T19:57:46Z

This PR attempts to address #22477, #20697, #22840, and #22371 via #22371 (comment).

Looking at the documentation, it seems like we can actually take a much simpler approach here.
using gcc : 5 : : <cxxflags>"-std=c++14 -O2" ;
is claimed to work. This means that instead of trying to split on spaces, we should be able to do a very simple fix of:

Get everything concatenated into a single string a la CXXFLAGS/CFLAGS like all the other buildsystems

Escape \ and " with \ (either as one step via regex or two simple string replacements)

Wrap the whole enchilada in quotes and prepend the appropriate <fooflags>.

As part of this, I've changed the precise return values of vcpkg_cmake_get_vars(). Instead of the previous approach which extracted some CMake values raw and some values semi-composited, I've instead taken the structured approach of:

Some subset of CMake values are exported directly as VCPKG_DETECTED_<VAR>. Generally, these should not need to be used by consumers.
Fully composited values intended for direct use by consumers are exported as VCPKG_COMBINED_<LANG>_FLAGS_<CONFIG>. This is important to ensure consumers are completely decoupled from specific CMake implementation details, like common vs config-specific flags or CMake flags that aren't kept in the normal CMAKE_<LANG>_FLAGS variable and are instead added during the rule processing phase.

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for boost-modular-build-helper but no changes to version or port version.
-- Version: 1.78.0#2
-- Old SHA: 9400b3bfdc93a165b3b509a76c59107c020113a6
-- New SHA: f5071551137953297ec6d58d12bac7c5a00205c8
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for boost-modular-build-helper but no changes to version or port version.
-- Version: 1.78.0#2
-- Old SHA: 9400b3bfdc93a165b3b509a76c59107c020113a6
-- New SHA: f5071551137953297ec6d58d12bac7c5a00205c8
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

Neumann-A · 2022-02-08T20:04:17Z

ports/boost-modular-build-helper/CMakeLists.txt

Looks like this would partly conflict with the uwp settings in #22831

Neumann-A · 2022-02-09T09:31:27Z

c1xx: fatal error C1083: Cannot open source file: 'Files': No such file or directory
c1xx: fatal error C1083: Cannot open source file: 'Kits\\10\\ExtensionSDKs\\Microsoft.VCLibs\\14.0\\References\\CommonConfiguration\\neutral"': No such file or directory
c1xx: fatal error C1083: Cannot open source file: 'Files': No such file or directory
c1xx: fatal error C1083: Cannot open source file: '(x86)\\Microsoft': No such file or directory
c1xx: fatal error C1083: Cannot open source file: 'SDKs\\Windows': No such file or directory

Have I said that even outlook has problems with usernames containing spaces?

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for ffmpeg but no changes to version or port version.
-- Version: 4.4.1#8
-- Old SHA: 03b7a2329bc927de9637d45738c23e607e4f4387
-- New SHA: 01a49f27efac32fb86b3381353ae365a442911c5
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Error: Local changes detected for vcpkg-cmake but no changes to version or port version.
-- Version: 2022-01-19
-- Old SHA: b7c050fe60f91dcedef6d87a3f87584151bf8aee
-- New SHA: 6f18f91ec5a38e8fbc9266993055cbf57a226d63
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Error: Local changes detected for vcpkg-qmake but no changes to version or port version.
-- Version: 2021-10-23
-- Old SHA: 1b1cd1cfcca489897822287c15af473fa4380cb1
-- New SHA: 4df08ac2a801250f2e7c6bdea23c21600e9a765b
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout cef0e8a8c7e5493283f2895c9c6fd8431d166b43 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/b-/boost-modular-build-helper.json b/versions/b-/boost-modular-build-helper.json
index e45e0fb..009760d 100644
--- a/versions/b-/boost-modular-build-helper.json
+++ b/versions/b-/boost-modular-build-helper.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "6ec70423606d92d7c5778e96b30cd2e8a8c572fa",
+      "version": "1.78.0",
+      "port-version": 3
+    },
     {
       "git-tree": "9400b3bfdc93a165b3b509a76c59107c020113a6",
       "version": "1.78.0",
diff --git a/versions/baseline.json b/versions/baseline.json
index 85e73d1..e7b916c 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -822,7 +822,7 @@
     },
     "boost-modular-build-helper": {
       "baseline": "1.78.0",
-      "port-version": 2
+      "port-version": 3
     },
     "boost-move": {
       "baseline": "1.78.0",

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/boost-modular-build-helper/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for ffmpeg but no changes to version or port version.
-- Version: 4.4.1#8
-- Old SHA: 03b7a2329bc927de9637d45738c23e607e4f4387
-- New SHA: 01a49f27efac32fb86b3381353ae365a442911c5
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Error: Local changes detected for vcpkg-cmake but no changes to version or port version.
-- Version: 2022-01-19
-- Old SHA: b7c050fe60f91dcedef6d87a3f87584151bf8aee
-- New SHA: dd313fd2fa062b95a4122479ad5a75471a4705ca
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Error: Local changes detected for vcpkg-qmake but no changes to version or port version.
-- Version: 2021-10-23
-- Old SHA: 1b1cd1cfcca489897822287c15af473fa4380cb1
-- New SHA: 4df08ac2a801250f2e7c6bdea23c21600e9a765b
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout cef0e8a8c7e5493283f2895c9c6fd8431d166b43 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/b-/boost-modular-build-helper.json b/versions/b-/boost-modular-build-helper.json
index e45e0fb..f241ef2 100644
--- a/versions/b-/boost-modular-build-helper.json
+++ b/versions/b-/boost-modular-build-helper.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "3228b78ef41e18cdc4b8ffe7aa9fc02ca7c8e208",
+      "version": "1.78.0",
+      "port-version": 3
+    },
     {
       "git-tree": "9400b3bfdc93a165b3b509a76c59107c020113a6",
       "version": "1.78.0",
diff --git a/versions/baseline.json b/versions/baseline.json
index 85e73d1..e7b916c 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -822,7 +822,7 @@
     },
     "boost-modular-build-helper": {
       "baseline": "1.78.0",
-      "port-version": 2
+      "port-version": 3
     },
     "boost-move": {
       "baseline": "1.78.0",

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/boost-modular-build-helper/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for ffmpeg but no changes to version or port version.
-- Version: 4.4.1#8
-- Old SHA: 03b7a2329bc927de9637d45738c23e607e4f4387
-- New SHA: 01a49f27efac32fb86b3381353ae365a442911c5
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Error: Local changes detected for vcpkg-cmake but no changes to version or port version.
-- Version: 2022-01-19
-- Old SHA: b7c050fe60f91dcedef6d87a3f87584151bf8aee
-- New SHA: dd313fd2fa062b95a4122479ad5a75471a4705ca
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Error: Local changes detected for vcpkg-qmake but no changes to version or port version.
-- Version: 2021-10-23
-- Old SHA: 1b1cd1cfcca489897822287c15af473fa4380cb1
-- New SHA: 4df08ac2a801250f2e7c6bdea23c21600e9a765b
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout cef0e8a8c7e5493283f2895c9c6fd8431d166b43 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/b-/boost-modular-build-helper.json b/versions/b-/boost-modular-build-helper.json
index e45e0fb..fe9a727 100644
--- a/versions/b-/boost-modular-build-helper.json
+++ b/versions/b-/boost-modular-build-helper.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "68a9a82d6b1b7a2040ceb1dd4459aa4423846813",
+      "version": "1.78.0",
+      "port-version": 3
+    },
     {
       "git-tree": "9400b3bfdc93a165b3b509a76c59107c020113a6",
       "version": "1.78.0",
diff --git a/versions/baseline.json b/versions/baseline.json
index 85e73d1..e7b916c 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -822,7 +822,7 @@
     },
     "boost-modular-build-helper": {
       "baseline": "1.78.0",
-      "port-version": 2
+      "port-version": 3
     },
     "boost-move": {
       "baseline": "1.78.0",

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/boost-modular-build-helper/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for ffmpeg but no changes to version or port version.
-- Version: 4.4.1#8
-- Old SHA: 03b7a2329bc927de9637d45738c23e607e4f4387
-- New SHA: 01a49f27efac32fb86b3381353ae365a442911c5
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Error: Local changes detected for vcpkg-cmake but no changes to version or port version.
-- Version: 2022-01-19
-- Old SHA: b7c050fe60f91dcedef6d87a3f87584151bf8aee
-- New SHA: dd313fd2fa062b95a4122479ad5a75471a4705ca
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Error: Local changes detected for vcpkg-qmake but no changes to version or port version.
-- Version: 2021-10-23
-- Old SHA: 1b1cd1cfcca489897822287c15af473fa4380cb1
-- New SHA: 4df08ac2a801250f2e7c6bdea23c21600e9a765b
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout cef0e8a8c7e5493283f2895c9c6fd8431d166b43 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/b-/boost-modular-build-helper.json b/versions/b-/boost-modular-build-helper.json
index e45e0fb..00fffbe 100644
--- a/versions/b-/boost-modular-build-helper.json
+++ b/versions/b-/boost-modular-build-helper.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "a9c7c402ef134b2e4c6dc1961832d645f9827a2d",
+      "version": "1.78.0",
+      "port-version": 3
+    },
     {
       "git-tree": "9400b3bfdc93a165b3b509a76c59107c020113a6",
       "version": "1.78.0",
diff --git a/versions/baseline.json b/versions/baseline.json
index 4058e15..1d53232 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -822,7 +822,7 @@
     },
     "boost-modular-build-helper": {
       "baseline": "1.78.0",
-      "port-version": 2
+      "port-version": 3
     },
     "boost-move": {
       "baseline": "1.78.0",

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/boost-modular-build-helper/vcpkg.json

Valid values for the license field can be found in the documentation

ports/vcpkg-cmake/cmake_get_vars/CMakeLists.txt

ports/vcpkg-qmake/vcpkg_qmake_configure.cmake

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for ffmpeg but no changes to version or port version.
-- Version: 4.4.1#8
-- Old SHA: 03b7a2329bc927de9637d45738c23e607e4f4387
-- New SHA: 2e6103d7bec716a5691b82663dec4bf300eda84a
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Error: Local changes detected for vcpkg-cmake but no changes to version or port version.
-- Version: 2022-01-19
-- Old SHA: b7c050fe60f91dcedef6d87a3f87584151bf8aee
-- New SHA: dd313fd2fa062b95a4122479ad5a75471a4705ca
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
Error: Local changes detected for vcpkg-qmake but no changes to version or port version.
-- Version: 2021-10-23
-- Old SHA: 1b1cd1cfcca489897822287c15af473fa4380cb1
-- New SHA: 4df08ac2a801250f2e7c6bdea23c21600e9a765b
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout cef0e8a8c7e5493283f2895c9c6fd8431d166b43 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/b-/boost-modular-build-helper.json b/versions/b-/boost-modular-build-helper.json
index e45e0fb..00fffbe 100644
--- a/versions/b-/boost-modular-build-helper.json
+++ b/versions/b-/boost-modular-build-helper.json
@@ -1,5 +1,10 @@
 {
   "versions": [
+    {
+      "git-tree": "a9c7c402ef134b2e4c6dc1961832d645f9827a2d",
+      "version": "1.78.0",
+      "port-version": 3
+    },
     {
       "git-tree": "9400b3bfdc93a165b3b509a76c59107c020113a6",
       "version": "1.78.0",
diff --git a/versions/baseline.json b/versions/baseline.json
index 4058e15..1d53232 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -822,7 +822,7 @@
     },
     "boost-modular-build-helper": {
       "baseline": "1.78.0",
-      "port-version": 2
+      "port-version": 3
     },
     "boost-move": {
       "baseline": "1.78.0",

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/boost-modular-build-helper/vcpkg.json

Valid values for the license field can be found in the documentation

PhoebeHui · 2022-02-14T02:45:04Z

/Library/Developer/CommandLineTools/usr/bin/../include/c++/v1/string.h:60:15: fatal error: 'string.h' file not found
#include_next <string.h>
              ^~~~~~~~~~

/Users/vagrant/Data/installed/x64-osx/include/boost/config/detail/posix_features.hpp:18:15: fatal error: 'unistd.h' file not found
#     include <unistd.h>

/Users/vagrant/Data/installed/x64-osx/include/boost/assert.hpp:58:11: fatal error: 'assert.h' file not found
# include <assert.h> // .h to support old libraries w/o <cassert> - effect is the same

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for vcpkg-qmake but no changes to version or port version.
-- Version: 2021-10-23
-- Old SHA: 1b1cd1cfcca489897822287c15af473fa4380cb1
-- New SHA: 4df08ac2a801250f2e7c6bdea23c21600e9a765b
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/boost-modular-build-helper/vcpkg.json
ports/ffmpeg/vcpkg.json
ports/vcpkg-cmake/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/boost-modular-build-helper/vcpkg.json
ports/ffmpeg/vcpkg.json
ports/vcpkg-cmake/vcpkg.json
ports/vcpkg-qmake/vcpkg.json

Valid values for the license field can be found in the documentation

ports/vcpkg-cmake/cmake_get_vars/CMakeLists.txt

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/boost-modular-build-helper/vcpkg.json
ports/ffmpeg/vcpkg.json
ports/vcpkg-cmake/vcpkg.json
ports/vcpkg-qmake/vcpkg.json

Valid values for the license field can be found in the documentation

github-actions

You have modified or added at least one vcpkg.json where a "license" field is missing.

Details

If you feel able to do so, please consider adding a "license" field to the following files:

ports/boost-modular-build-helper/vcpkg.json
ports/ffmpeg/vcpkg.json
ports/vcpkg-cmake/vcpkg.json
ports/vcpkg-qmake/vcpkg.json

Valid values for the license field can be found in the documentation

ports/boost-modular-build-helper/CMakeLists.txt

ras0219-msft · 2022-03-11T01:10:41Z

/azp run

azure-pipelines · 2022-03-11T01:10:51Z

Azure Pipelines successfully started running 1 pipeline(s).

PhoebeHui · 2022-03-11T07:39:02Z

Baseline issues would be fixed by #23431 and #23478

…roschuma/b2

PhoebeHui · 2022-03-16T05:46:36Z

@dan-shaw, could you help merge this PR firstly?

PhoebeHui · 2022-03-17T06:37:24Z

@vicroms, could you please help merge this PR? it also blocks internal users.

ports/boost-modular-build-helper/CMakeLists.txt

ports/ffmpeg/portfile.cmake

dg0yt · 2022-03-31T20:23:01Z

@ras0219-msft With this change merged, boost-exception:x64-linux now fails on my Ubuntu 18.04 machine. For some reason it starts to pass -m32 instead of -m64.

dg0yt · 2022-03-31T20:32:24Z

ports/boost-modular-build-helper/CMakeLists.txt

 endif()

-if(CMAKE_SIZEOF_VOID_P EQUAL 8)
+if(VCPKG_DETECTED_CMAKE_SIZEOF_VOID_P EQUAL "8")


This variable is not set. (And why no longer CMAKE_SIZEOF_VOID_P)?

Anwer to the question: No languages enabled here.

This variable is not set.

... because I didn't update vcpkg-cmake at the same time.

Why can't we use version>= for such dependencies?

Why can't we use version>= for such dependencies?

manifest mode would have automatically reinstalled here. Just always start from scratch if you use classic mode and do git operations.

manifest mode would have automatically reinstalled here.

... unless I (the user) would pin a different version. That's why I think it is useful to make the versioned dependencies explicit.

christophe-calmejane · 2022-04-05T09:57:09Z

Hi,
unfortunately this patch does not fix what #18529 broke regarding iOS compilation.
Forcing macosx-version-min for non-macOS target causes compilation error when ios-version-min is specified.

A check should be added when CMAKE_OSX_DEPLOYMENT_TARGET is defined, either adding macosx-version-min or ios-version-min based on CMAKE_SYSTEM_NAME (either Darwin or iOS)

Fix based on microsoft#23001

* Fix for #18529 that broke iOS compilation Fix based on #23001 * Updated version database

ras0219-msft force-pushed the dev/roschuma/b2 branch from d944b13 to d722fff Compare February 8, 2022 19:58

github-actions bot requested changes Feb 8, 2022

View reviewed changes

Neumann-A reviewed Feb 8, 2022

View reviewed changes

PhoebeHui self-assigned this Feb 8, 2022

PhoebeHui added the category:port-bug The issue is with a library, which is something the port should already support label Feb 8, 2022

github-actions bot requested changes Feb 11, 2022

View reviewed changes

github-actions bot requested changes Feb 12, 2022

View reviewed changes

Neumann-A reviewed Feb 12, 2022

View reviewed changes

ports/vcpkg-cmake/cmake_get_vars/CMakeLists.txt Outdated Show resolved Hide resolved

Neumann-A reviewed Feb 12, 2022

View reviewed changes

ports/vcpkg-cmake/cmake_get_vars/CMakeLists.txt Outdated Show resolved Hide resolved

Neumann-A reviewed Feb 12, 2022

View reviewed changes

ports/vcpkg-qmake/vcpkg_qmake_configure.cmake Outdated Show resolved Hide resolved

github-actions bot requested changes Feb 12, 2022

View reviewed changes

PhoebeHui mentioned this pull request Feb 14, 2022

[boost-modular-build-helper] Wrap compiler flags with quotes #22371

Closed

ras0219-msft force-pushed the dev/roschuma/b2 branch from 252cba6 to 7fd7b65 Compare February 14, 2022 20:18

github-actions bot requested changes Feb 14, 2022

View reviewed changes

ras0219-msft force-pushed the dev/roschuma/b2 branch from 7fd7b65 to aff68db Compare February 14, 2022 20:20

github-actions bot approved these changes Feb 14, 2022

View reviewed changes

Neumann-A reviewed Feb 14, 2022

View reviewed changes

ports/vcpkg-cmake/cmake_get_vars/CMakeLists.txt Outdated Show resolved Hide resolved

ras0219-msft force-pushed the dev/roschuma/b2 branch from aff68db to e323436 Compare February 15, 2022 22:23

github-actions bot approved these changes Feb 15, 2022

View reviewed changes

BillyONeal mentioned this pull request Feb 16, 2022

[boost-modular-build-helper] Ensure CMAKE_STATIC_LINKER_FLAGS makes it to the link.exe command line when building Boost as a static lib with MSVC. #20697

Closed

Neumann-A mentioned this pull request Feb 16, 2022

[Fix uwp toolchain|world rebuild] make ninja work for uwp #22831

Merged

ras0219-msft force-pushed the dev/roschuma/b2 branch from e323436 to 813b207 Compare February 16, 2022 21:16

github-actions bot approved these changes Feb 16, 2022

View reviewed changes

BillyONeal reviewed Feb 17, 2022

View reviewed changes

ports/boost-modular-build-helper/CMakeLists.txt Outdated Show resolved Hide resolved

BillyONeal reviewed Feb 17, 2022

View reviewed changes

ports/boost-modular-build-helper/CMakeLists.txt Outdated Show resolved Hide resolved

PhoebeHui linked an issue Mar 10, 2022 that may be closed by this pull request

How do I install boost lib compiled with /guard:cf & /Qspectre flags #23388

Closed

PhoebeHui mentioned this pull request Mar 10, 2022

New vcpkg version causes ncurses to build additional libraries on x64-linux #23476

Closed

Merge branch 'master' of https://github.com/Microsoft/vcpkg into dev/…

c7366f8

…roschuma/b2

PhoebeHui removed the requires:author-response label Mar 15, 2022

PhoebeHui approved these changes Mar 16, 2022

View reviewed changes

PhoebeHui added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Mar 16, 2022

Merge branch 'master' of github.com:microsoft/vcpkg into dev/roschuma/b2

caa6b43

strega-nil reviewed Mar 17, 2022

View reviewed changes

dan-shaw added requires:author-response and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Mar 17, 2022

ras0219-msft added 2 commits March 21, 2022 14:37

[boost-modular-build-helper] Add <linkflags> to requirements

74bc293

Address PR comments

326cbff

github-actions bot approved these changes Mar 29, 2022

View reviewed changes

ras0219-msft merged commit 5495128 into microsoft:master Mar 30, 2022

ras0219-msft deleted the dev/roschuma/b2 branch March 30, 2022 21:52

dg0yt reviewed Mar 31, 2022

View reviewed changes

christophe-calmejane mentioned this pull request Apr 5, 2022

[vcpkg CMake] Fix for #18529 that broke iOS compilation #23989

Merged

christophe-calmejane added a commit to christophe-calmejane/vcpkg that referenced this pull request Apr 5, 2022

Fix for microsoft#18529 that broke iOS compilation

99b82f8

Fix based on microsoft#23001

strega-nil-ms pushed a commit that referenced this pull request Apr 6, 2022

[vcpkg CMake] Fix for #18529 that broke iOS compilation (#23989)

436d98d

* Fix for #18529 that broke iOS compilation Fix based on #23001 * Updated version database

This was referenced Apr 12, 2022

[boost-exception] build failure #24075

Closed

[vcpkg-cmake] Fix usage of CMAKE_CXX_COMPILER_TARGET #24101

Merged

Sibras mentioned this pull request Jun 1, 2024

[ffmpeg] Update to 7.0. #38011

Merged

Conversation

ras0219-msft commented Feb 8, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Neumann-A Feb 8, 2022

Choose a reason for hiding this comment

Uh oh!

Neumann-A commented Feb 9, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

PhoebeHui commented Feb 14, 2022

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

ras0219-msft commented Mar 11, 2022

Uh oh!

azure-pipelines bot commented Mar 11, 2022

Uh oh!

PhoebeHui commented Mar 11, 2022

Uh oh!

PhoebeHui commented Mar 16, 2022

Uh oh!

PhoebeHui commented Mar 17, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dg0yt commented Mar 31, 2022

Uh oh!

dg0yt Mar 31, 2022

Choose a reason for hiding this comment

Uh oh!

dg0yt Mar 31, 2022

Choose a reason for hiding this comment

Uh oh!

dg0yt Mar 31, 2022

Choose a reason for hiding this comment

Uh oh!

Neumann-A Mar 31, 2022

Choose a reason for hiding this comment

ras0219-msft commented Feb 8, 2022 •

edited

Loading

christophe-calmejane commented Apr 5, 2022 •

edited

Loading