[vcpkg-cmake] Fix usage of CMAKE_CXX_COMPILER_TARGET#24101
Merged
strega-nil-ms merged 2 commits intomicrosoft:masterfrom Apr 18, 2022
Merged
[vcpkg-cmake] Fix usage of CMAKE_CXX_COMPILER_TARGET#24101strega-nil-ms merged 2 commits intomicrosoft:masterfrom
strega-nil-ms merged 2 commits intomicrosoft:masterfrom
Conversation
Contributor
Author
|
For mingw gcc, we get due the stand-alone Before #23001, this didn't happen because vcpkg/ports/boost-modular-build-helper/CMakeLists.txt Lines 143 to 151 in 93d397c AFAIU Clang always takes that parameter, so I didn't restore the guard before that line. |
Contributor
|
@LilyWangLL request for a review. |
LilyWangLL
approved these changes
Apr 18, 2022
Contributor
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does your PR fix?
Fixes [boost-exception] build failure #24075 (mingw native or cross).
Amends [boost-modular-build-helper] Attempt to pass flags more correctly into b2 #23001 - CC @ras0219-msft
More details in [vcpkg-cmake] Fix usage of CMAKE_CXX_COMPILER_TARGET #24101 (comment).
Which triplets are supported/not supported? Have you updated the CI baseline?
all, no
Does your PR follow the maintainer guide?
yes
If you have added/updated a port: Have you run
./vcpkg x-add-version --alland committed the result?yes