[vcpkg baseline] Fix ports build on Linux#23478
Merged
vicroms merged 12 commits intomicrosoft:masterfrom Mar 11, 2022
Merged
Conversation
added 2 commits
March 9, 2022 23:00
added 2 commits
March 9, 2022 23:03
added 2 commits
March 9, 2022 23:24
Contributor
|
Contributor
|
…jack/vcpkg-baseline-20220310
JackBoosY
commented
Mar 11, 2022
ports/ncurses/vcpkg.json
Outdated
| @@ -1,6 +1,9 @@ | |||
| { | |||
| "name": "ncurses", | |||
| "version-string": "6.3", | |||
Contributor
Author
There was a problem hiding this comment.
Suggested change
| "version-string": "6.3", | |
| "version": "6.3", |
Contributor
Author
There was a problem hiding this comment.
@BillyONeal The failure of our PR suggestion agent should be due to an incorrect version field in the manifest file, but no specific error message is mentioned in the log:
.\vcpkg.exe x-add-version --overwrite-version ncurses
Use the version scheme "version" instead of "version-string" in port "ncurses".
Use `--skip-version-format-check` to disable this check.
That should caused by the vcpkg-tool changes.
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout e6509c997fef840f7cfdb84cf6e757b70ee283a8 -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/n-/ncurses.json b/versions/n-/ncurses.json
index f4b5db2..26698d5 100644
--- a/versions/n-/ncurses.json
+++ b/versions/n-/ncurses.json
@@ -1,8 +1,8 @@
{
"versions": [
{
- "git-tree": "46f36d51c287c33525346dcf6fb903ddeea5a4d7",
- "version-string": "6.3",
+ "git-tree": "ea7aecbf38cef7f64f929c679d55812e679ca496",
+ "version": "6.3",
"port-version": 1
},
{
JackBoosY
commented
Mar 11, 2022
Contributor
Author
|
@BillyONeal @vicroms Please merge this PR first after review. |
LilyWangLL
approved these changes
Mar 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That's because this port can only be built as release. Use cmake build system instead.
Related: #23476 #23429