[boost-modular-build-helper] Wrap compiler flags with quotes#22371
[boost-modular-build-helper] Wrap compiler flags with quotes#22371ahojnnes wants to merge 4 commits intomicrosoft:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for boost-modular-build-helper but no changes to version or port version.
-- Version: 1.77.0#4
-- Old SHA: aea8b4dbb8063db29d8ac843ef6aac35478bebaa
-- New SHA: 749698488fe29b5dcf41abc98e3b8dba3cc47341
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
PRs must add only one version and must not modify any published versions
When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.
Error: Local changes detected for boost-modular-build-helper but no changes to version or port version.
-- Version: 1.77.0#4
-- Old SHA: aea8b4dbb8063db29d8ac843ef6aac35478bebaa
-- New SHA: fc56d2cf8e172d909ee1341effe945fea6c72541
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***
|
@ahojnnes, could you report an issue for this PR? what compiler flag do you apply? |
|
I am trying to be a good citizen :-) and enable /guard:cf and other related flags to address binskim suggestions. |
PhoebeHui
added
the
category:port-bug
|
@PhoebeHui Yes, exactly, that's what I was trying to achieve. |
|
@PhoebeHui @ahojnnes If I understand correctly build doesn't fail. |
|
@yurybura The warnings are not a blocker, but see the annotated code line above. Without this, the linker flags are just ignored. |
@Kojoley Could you help to understand why linker flags defined in the user_config.jam are ignored? Thanks in advance. |
That's a bug in B2, and it seems that there should be the same bug for asmflags. For some historical reasons msvc.jam uses different names than common.handle-options and other toolsets use. |
|
Relate to #20697 |
…/joschonb/boost-modular-build-helper
There was a problem hiding this comment.
You have modified or added at least one vcpkg.json where a "license" field is missing.
If you feel able to do so, please consider adding a "license" field to the following files:
ports/boost-modular-build-helper/vcpkg.json
Valid values for the license field are listed at https://spdx.org/licenses/
PhoebeHui
added
the
info:needs-maintainer-attention
|
Adding this doc link for posterity: https://grafikrobot.github.io/b2doc/#jam.language.lexical |
|
Looking at the documentation, it seems like we can actually take a much simpler approach here. is claimed to work. This means that instead of trying to split on spaces, we should be able to do a very simple fix of:
I believe this should fix multiple current issues, including this one and #22840. I think when I originally wrote this code I didn't find that part of the docs and assumed that boost build would apply its own layers of escaping to the arguments (such as surrounding every |
BillyONeal
removed
the
info:needs-maintainer-attention
|
Ping @ahojnnes for your response! |
|
What @ras0219-msft proposes seems like the right approach and simplifies the whole script. I am supporting to take this approach, but I don't have any cycles to tackle the issues anytime soon to be honest. |
|
Closing in favor of #23001. |
7 participants
Without this PR, building boost packages under Windows with custom compiler flags fails as follows: