[soundtouch] enable static build by daschuer · Pull Request #19377 · microsoft/vcpkg

daschuer · 2021-08-05T09:45:46Z

Describe the pull request

What does your PR fix?

Static build of soundtouch

Which triplets are supported/not supported? Have you updated the CI baseline?

all,!uwp, Yes
Does your PR follow the maintainer guide?

Yes
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

If you are still working on the PR, open it as a Draft: https://github.blog/2019-02-14-introducing-draft-pull-requests/

ports/soundtouch/CONTROL

ports/soundtouch/portfile.cmake

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout d2019e507caf9469d8d5c93bfcd3f6d26548ca12 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/s-/soundtouch.json b/versions/s-/soundtouch.json
index 850c076..4fa4ff4 100644
--- a/versions/s-/soundtouch.json
+++ b/versions/s-/soundtouch.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "f4202922ea3ee86069d2139332006625e431334d",
+      "git-tree": "5d7286ce3a1cb5028b7a01ff6537444c8d1a1f78",
       "version-string": "2.0.0-7",
       "port-version": 0
     },

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout d2019e507caf9469d8d5c93bfcd3f6d26548ca12 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index 37cc36f..d052d82 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -5977,8 +5977,8 @@
       "port-version": 0
     },
     "soundtouch": {
-      "baseline": "2.0.0-7",
-      "port-version": 0
+      "baseline": "2.0.0",
+      "port-version": 7
     },
     "soxr": {
       "baseline": "0.1.3",
diff --git a/versions/s-/soundtouch.json b/versions/s-/soundtouch.json
index 850c076..86ab66f 100644
--- a/versions/s-/soundtouch.json
+++ b/versions/s-/soundtouch.json
@@ -1,9 +1,9 @@
 {
   "versions": [
     {
-      "git-tree": "f4202922ea3ee86069d2139332006625e431334d",
-      "version-string": "2.0.0-7",
-      "port-version": 0
+      "git-tree": "17fa46b1b27b240742aca88ecb585012ed0b6c39",
+      "version-string": "2.0.0",
+      "port-version": 7
     },
     {
       "git-tree": "c70fc01038afbb6850538b0a4789b91c83113a8d",

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout d2019e507caf9469d8d5c93bfcd3f6d26548ca12 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/s-/soundtouch.json b/versions/s-/soundtouch.json
index 0a10064..86ab66f 100644
--- a/versions/s-/soundtouch.json
+++ b/versions/s-/soundtouch.json
@@ -5,11 +5,6 @@
       "version-string": "2.0.0",
       "port-version": 7
     },
-    {
-      "git-tree": "f4202922ea3ee86069d2139332006625e431334d",
-      "version-string": "2.0.0-7",
-      "port-version": 0
-    },
     {
       "git-tree": "c70fc01038afbb6850538b0a4789b91c83113a8d",
       "version-string": "2.0.0-6",

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 57bd7102d9fd880daa1b0958692294c4a125f6d8 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/s-/soundtouch.json b/versions/s-/soundtouch.json
index 0a10064..86ab66f 100644
--- a/versions/s-/soundtouch.json
+++ b/versions/s-/soundtouch.json
@@ -5,11 +5,6 @@
       "version-string": "2.0.0",
       "port-version": 7
     },
-    {
-      "git-tree": "f4202922ea3ee86069d2139332006625e431334d",
-      "version-string": "2.0.0-7",
-      "port-version": 0
-    },
     {
       "git-tree": "c70fc01038afbb6850538b0a4789b91c83113a8d",
       "version-string": "2.0.0-6",

daschuer · 2021-08-07T22:35:12Z

Done

NancyLi1013 · 2021-08-09T03:14:14Z

/azp run

azure-pipelines · 2021-08-09T03:14:25Z

Azure Pipelines successfully started running 1 pipeline(s).

ports/soundtouch/vcpkg.json

daschuer · 2021-08-09T16:40:21Z

Done

NancyLi1013 · 2021-09-29T02:46:06Z

Needs to solve the conflicts here. @daschuer

Be-ing · 2021-09-29T14:19:51Z

This PR is obsolete. #20017 implemented support for static builds.

daschuer · 2021-09-29T21:11:31Z

The only missing bit was the ci.baseline.txt change. I have rebased this PR accordingly.

https://dev.azure.com/vcpkg/public/_build/results?buildId=60445 PASSING, REMOVE FROM FAIL LIST: soundtouch:x64-windows-static Probably fixed by: microsoft#19377 REGRESSION: mosquitto:x86-windows REGRESSION: mosquitto:x64-windows Probably broken by: microsoft#20148 ``` The following EXEs were found in /bin or /debug/bin. EXEs are not valid distribution targets. D:/packages/mosquitto_x86-windows/bin/mosquitto_ctrl.exe The following EXEs were found in /bin or /debug/bin. EXEs are not valid distribution targets. D:/packages/mosquitto_x86-windows/debug/bin/mosquitto_ctrl.exe Found 2 error(s). Please correct the portfile: C:\a\1\s\ports\mosquitto\portfile.cmake -- Performing post-build validation done ``` The upstream build system has this: ``` option(WITH_CJSON "Build with cJSON support (required for dynamic security plugin and useful for mosquitto_sub)?" ON) if (WITH_CJSON) FIND_PACKAGE(cJSON) if (CJSON_FOUND) message(STATUS ${CJSON_FOUND}) else (CJSON_FOUND) message(STATUS "Optional dependency cJSON not found. Some features will be disabled.") endif(CJSON_FOUND) endif() ``` and indeed, I repro the problem if cjson is installed first. Disable WITH_CJSON as a fix. OSX never finishing: Hopefully fixed by microsoft#20388

BillyONeal · 2021-09-29T21:21:53Z

This PR is also (accidentally) included in #20435

https://dev.azure.com/vcpkg/public/_build/results?buildId=60445 PASSING, REMOVE FROM FAIL LIST: soundtouch:x64-windows-static Probably fixed by: #19377 REGRESSION: mosquitto:x86-windows REGRESSION: mosquitto:x64-windows Probably broken by: #20148 ``` The following EXEs were found in /bin or /debug/bin. EXEs are not valid distribution targets. D:/packages/mosquitto_x86-windows/bin/mosquitto_ctrl.exe The following EXEs were found in /bin or /debug/bin. EXEs are not valid distribution targets. D:/packages/mosquitto_x86-windows/debug/bin/mosquitto_ctrl.exe Found 2 error(s). Please correct the portfile: C:\a\1\s\ports\mosquitto\portfile.cmake -- Performing post-build validation done ``` The upstream build system has this: ``` option(WITH_CJSON "Build with cJSON support (required for dynamic security plugin and useful for mosquitto_sub)?" ON) if (WITH_CJSON) FIND_PACKAGE(cJSON) if (CJSON_FOUND) message(STATUS ${CJSON_FOUND}) else (CJSON_FOUND) message(STATUS "Optional dependency cJSON not found. Some features will be disabled.") endif(CJSON_FOUND) endif() ``` and indeed, I repro the problem if cjson is installed first. Disable WITH_CJSON as a fix. OSX never finishing: Hopefully fixed by #20388

BillyONeal · 2021-09-30T01:04:50Z

Thanks for your contribution! Unfortunately it looks like all the edits here are already applied in master :)

github-actions bot approved these changes Aug 5, 2021

View reviewed changes

JonLiu1993 assigned NancyLi1013 Aug 6, 2021

NancyLi1013 added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label Aug 6, 2021

NancyLi1013 suggested changes Aug 6, 2021

View reviewed changes

ports/soundtouch/CONTROL Outdated Show resolved Hide resolved

ports/soundtouch/portfile.cmake Outdated Show resolved Hide resolved

ports/soundtouch/portfile.cmake Outdated Show resolved Hide resolved

ports/soundtouch/portfile.cmake Outdated Show resolved Hide resolved

NancyLi1013 added the requires:author-response label Aug 6, 2021

github-actions bot requested changes Aug 7, 2021

View reviewed changes

daschuer force-pushed the soundtouch_static branch from 4a3a506 to 5a97237 Compare August 7, 2021 22:20

github-actions bot requested changes Aug 7, 2021

View reviewed changes

daschuer force-pushed the soundtouch_static branch from 5a97237 to edb88b8 Compare August 7, 2021 22:34

github-actions bot approved these changes Aug 7, 2021

View reviewed changes

NancyLi1013 suggested changes Aug 9, 2021

View reviewed changes

ports/soundtouch/vcpkg.json Outdated Show resolved Hide resolved

github-actions bot approved these changes Aug 9, 2021

View reviewed changes

[soundtouch] no longer fail x64-windows-static ci

cac8f7a

daschuer force-pushed the soundtouch_static branch from 256861c to cac8f7a Compare September 29, 2021 21:08

github-actions bot approved these changes Sep 29, 2021

View reviewed changes

BillyONeal mentioned this pull request Sep 29, 2021

Build fixes from 2021-09-28's nightly build. #20435

Merged

BillyONeal added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Sep 29, 2021

BillyONeal closed this Sep 30, 2021

daschuer deleted the soundtouch_static branch January 5, 2023 07:33

Conversation

daschuer commented Aug 5, 2021

What does your PR fix?

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

daschuer commented Aug 7, 2021

Uh oh!

NancyLi1013 commented Aug 9, 2021

Uh oh!

azure-pipelines bot commented Aug 9, 2021

Uh oh!

Uh oh!

daschuer commented Aug 9, 2021

Uh oh!

NancyLi1013 commented Sep 29, 2021

Uh oh!

Be-ing commented Sep 29, 2021

Uh oh!

daschuer commented Sep 29, 2021

Uh oh!

BillyONeal commented Sep 29, 2021

Uh oh!

BillyONeal commented Sep 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?