[macos ci] move out tensorflow#20388
Merged
BillyONeal merged 3 commits intomicrosoft:masterfrom Sep 29, 2021
Merged
Conversation
strega-nil-ms
force-pushed
the
macos-ci-move-out-tensorflow
branch
from
ed65084 to
5c2cc28
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
Author
|
/azp run |
|
Azure Pipelines failed to run 1 pipeline(s). |
PhoebeHui
added
category:infrastructure
strega-nil-ms
force-pushed
the
macos-ci-move-out-tensorflow
branch
from
298067a to
0bc05c2
Compare
BillyONeal
reviewed
Sep 28, 2021
BillyONeal
reviewed
Sep 28, 2021
BillyONeal
approved these changes
Sep 28, 2021
# Conflicts: # scripts/azure-pipelines/azure-pipelines.yml # scripts/azure-pipelines/osx/azure-pipelines.yml # scripts/azure-pipelines/test-modified-ports.ps1
BillyONeal
reviewed
Sep 29, 2021
Member
BillyONeal
left a comment
BillyONeal
left a comment
There was a problem hiding this comment.
Thanks for making ci more reliable!
BillyONeal
added a commit
to BillyONeal/vcpkg
that referenced
this pull request
Sep 29, 2021
https://dev.azure.com/vcpkg/public/_build/results?buildId=60445 PASSING, REMOVE FROM FAIL LIST: soundtouch:x64-windows-static Probably fixed by: microsoft#19377 REGRESSION: mosquitto:x86-windows REGRESSION: mosquitto:x64-windows Probably broken by: microsoft#20148 ``` The following EXEs were found in /bin or /debug/bin. EXEs are not valid distribution targets. D:/packages/mosquitto_x86-windows/bin/mosquitto_ctrl.exe The following EXEs were found in /bin or /debug/bin. EXEs are not valid distribution targets. D:/packages/mosquitto_x86-windows/debug/bin/mosquitto_ctrl.exe Found 2 error(s). Please correct the portfile: C:\a\1\s\ports\mosquitto\portfile.cmake -- Performing post-build validation done ``` The upstream build system has this: ``` option(WITH_CJSON "Build with cJSON support (required for dynamic security plugin and useful for mosquitto_sub)?" ON) if (WITH_CJSON) FIND_PACKAGE(cJSON) if (CJSON_FOUND) message(STATUS ${CJSON_FOUND}) else (CJSON_FOUND) message(STATUS "Optional dependency cJSON not found. Some features will be disabled.") endif(CJSON_FOUND) endif() ``` and indeed, I repro the problem if cjson is installed first. Disable WITH_CJSON as a fix. OSX never finishing: Hopefully fixed by microsoft#20388
BillyONeal
added a commit
that referenced
this pull request
Sep 30, 2021
https://dev.azure.com/vcpkg/public/_build/results?buildId=60445 PASSING, REMOVE FROM FAIL LIST: soundtouch:x64-windows-static Probably fixed by: #19377 REGRESSION: mosquitto:x86-windows REGRESSION: mosquitto:x64-windows Probably broken by: #20148 ``` The following EXEs were found in /bin or /debug/bin. EXEs are not valid distribution targets. D:/packages/mosquitto_x86-windows/bin/mosquitto_ctrl.exe The following EXEs were found in /bin or /debug/bin. EXEs are not valid distribution targets. D:/packages/mosquitto_x86-windows/debug/bin/mosquitto_ctrl.exe Found 2 error(s). Please correct the portfile: C:\a\1\s\ports\mosquitto\portfile.cmake -- Performing post-build validation done ``` The upstream build system has this: ``` option(WITH_CJSON "Build with cJSON support (required for dynamic security plugin and useful for mosquitto_sub)?" ON) if (WITH_CJSON) FIND_PACKAGE(cJSON) if (CJSON_FOUND) message(STATUS ${CJSON_FOUND}) else (CJSON_FOUND) message(STATUS "Optional dependency cJSON not found. Some features will be disabled.") endif(CJSON_FOUND) endif() ``` and indeed, I repro the problem if cjson is installed first. Disable WITH_CJSON as a fix. OSX never finishing: Hopefully fixed by #20388
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
due to hitting the 1-day mark