[soundtouch] update to 2.3.1 by Be-ing · Pull Request #20017 · microsoft/vcpkg

Be-ing · 2021-09-07T01:48:47Z

Describe the pull request
I worked with upstream to implement a CMake build system, so I
removed the CMakeLists.txt from this port.

What does your PR fix?
- Headers were not installed by the port before.
- The port did not allow dynamic linking before.
- pkgconfig and CMake config files were not installed before.
Which triplets are supported/not supported? Have you updated the CI baseline?

all but UWP
Does your PR follow the maintainer guide?

yes
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

yes

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 71422c627264daedcbcd46f01f1ed0dcd8460f1b -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/s-/soundtouch.json b/versions/s-/soundtouch.json
index a6919da..21e2b9c 100644
--- a/versions/s-/soundtouch.json
+++ b/versions/s-/soundtouch.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "ce0caddead031b61d55d090755f9b18925a9d51e",
+      "git-tree": "1543b3d35dc78c0660da5aa34023d25187975741",
       "version-string": "2.3.1",
       "port-version": 0
     },

ports/soundtouch/vcpkg.json

JonLiu1993 · 2021-09-07T06:16:31Z

@Be-ing ,Have you tested the features locally? I tested the features in x86-windows and x64-windows but all failed:
install-x86-windows-dbg-out.log

Be-ing · 2021-09-07T12:46:30Z

It seems the soundtouchdll feature does not work on Windows...

Be-ing · 2021-09-07T13:45:23Z

Upstream merge request to fix SoundTouchDLL build with MSVC: https://gitlab.com/soundtouch/soundtouch/-/merge_requests/18

Be-ing · 2021-09-07T16:41:05Z

Upstream merged my fix for the soundtouchdll feature and moved the 2.3.1 tag to include it. I updated the hash.

JonLiu1993 · 2021-09-08T02:56:32Z

@Be-ing ,All feature are tetsed successfully in the following triplet:

x86-windows
x64-windows
x64-linux
but in x64-windows-static triplet failed:

DLLs should not be present in a static build, but the following DLLs were found:

    F:/test-pr/1/vcpkg/packages/soundtouch_x64-windows-static/bin/SoundTouchDLL.dll
    F:/test-pr/1/vcpkg/packages/soundtouch_x64-windows-static/debug/bin/SoundTouchDLL.dll

There should be no bin\ directory in a static build, but F:\test-pr\1\vcpkg\packages\soundtouch_x64-windows-static\bin is present.
There should be no debug\bin\ directory in a static build, but F:\test-pr\1\vcpkg\packages\soundtouch_x64-windows-static\debug/bin is present.
If the creation of bin\ and/or debug\bin\ cannot be disabled, use this in the portfile to remove them

    if(VCPKG_LIBRARY_LINKAGE STREQUAL "static")
        file(REMOVE_RECURSE "${CURRENT_PACKAGES_DIR}/bin" "${CURRENT_PACKAGES_DIR}/debug/bin")
    endif()

Found 2 error(s). Please correct the portfile:

Be-ing · 2021-09-08T12:36:08Z

SoundTouchDLL is only meant to be built as a DLL, hence the name. It is hardcoded in the upstream build system as a shared library. So if that warning is a problem, the only solution I think would be to disable the soundtouchdll feature for static builds.

JonLiu1993 · 2021-09-10T11:53:02Z

@Be-ing ,Could you please fix the x64-windows-static triplet error and handle the Conflicting files?

Be-ing · 2021-09-10T15:46:24Z

I need an answer how to handle the interaction between the soundtouchdll feature and static linking. I can think of a few options:

Fatal error if soundtouchdll is enabled with static linking.
Nonfatal warning if soundtouchdll is enabled with static linking.

I don't particularly care what the answer is; I don't have a need for SoundTouchDLL. It was made to implement Delphi and Pascal bindings for SoundTouch, but SoundTouch is primarily intended to be used as a C++ library.

JonLiu1993 · 2021-09-22T09:09:24Z

/azp run

azure-pipelines · 2021-09-22T09:09:33Z

Azure Pipelines successfully started running 1 pipeline(s).

JonLiu1993 · 2021-09-22T09:24:50Z

@Be-ing ,Please confirm If upstream follows semantic versioning. and if no please change version-semver to version.I don't have permission to help you fix it. By the way, merge master

Be-ing · 2021-09-26T18:15:18Z

Yes upstream follows semver.

JonLiu1993 · 2021-09-27T02:50:25Z

/azp run

azure-pipelines · 2021-09-27T02:50:38Z

Azure Pipelines successfully started running 1 pipeline(s).

JonLiu1993 · 2021-09-27T05:53:33Z

@Be-ing ,Please merge master,

JackBoosY

Did you test the usage?

ports/soundtouch/vcpkg.json

I worked with upstream to implement a CMake build system, so I removed the CMakeLists.txt from this port. This fixes multiple issues: * Headers were not installed by the port before. * The port did not allow dynamic linking before. * pkgconfig and CMake config files were not installed before.

BillyONeal · 2021-09-29T00:10:58Z

Thanks for the help working with upstream!

Be-ing · 2021-09-29T14:13:51Z

One less port in the overlays! :)

since microsoft#20017 was merged

github-actions bot requested changes Sep 7, 2021

View reviewed changes

Be-ing force-pushed the soundtouch_2.3.1 branch from d0664e7 to 74305af Compare September 7, 2021 02:01

github-actions bot approved these changes Sep 7, 2021

View reviewed changes

JonLiu1993 self-assigned this Sep 7, 2021

JonLiu1993 added category:port-update The issue is with a library, which is requesting update new revision category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist labels Sep 7, 2021

JonLiu1993 suggested changes Sep 7, 2021

View reviewed changes

ports/soundtouch/vcpkg.json Outdated Show resolved Hide resolved

JonLiu1993 added the requires:all-feature-testing label Sep 7, 2021

JonLiu1993 added the requires:author-response label Sep 7, 2021

Be-ing force-pushed the soundtouch_2.3.1 branch from 74305af to cb5b113 Compare September 7, 2021 12:34

github-actions bot approved these changes Sep 7, 2021

View reviewed changes

Be-ing force-pushed the soundtouch_2.3.1 branch from cb5b113 to 40cd38d Compare September 7, 2021 16:40

github-actions bot approved these changes Sep 7, 2021

View reviewed changes

Be-ing force-pushed the soundtouch_2.3.1 branch from 40cd38d to 7e272b5 Compare September 7, 2021 16:42

github-actions bot approved these changes Sep 7, 2021

View reviewed changes

Be-ing force-pushed the soundtouch_2.3.1 branch from 7e272b5 to c1f795e Compare September 7, 2021 16:51

github-actions bot approved these changes Sep 7, 2021

View reviewed changes

JonLiu1993 removed the requires:author-response label Sep 8, 2021

JonLiu1993 added the requires:author-response label Sep 8, 2021

JonLiu1993 removed the requires:author-response label Sep 10, 2021

JonLiu1993 added the requires:author-response label Sep 10, 2021

JonLiu1993 removed the requires:author-response label Sep 13, 2021

Be-ing force-pushed the soundtouch_2.3.1 branch from 8eaf06b to c3ef900 Compare September 17, 2021 22:40

JonLiu1993 removed the requires:author-response label Sep 27, 2021

JonLiu1993 added the requires:author-response label Sep 27, 2021

Be-ing force-pushed the soundtouch_2.3.1 branch from c3ef900 to b049559 Compare September 27, 2021 15:15

github-actions bot approved these changes Sep 27, 2021

View reviewed changes

JackBoosY removed the requires:author-response label Sep 28, 2021

JackBoosY requested a review from JonLiu1993 September 28, 2021 01:32

JackBoosY approved these changes Sep 28, 2021

View reviewed changes

JackBoosY added the requires:all-feature-testing label Sep 28, 2021

JonLiu1993 suggested changes Sep 28, 2021

View reviewed changes

ports/soundtouch/vcpkg.json Outdated Show resolved Hide resolved

JonLiu1993 added the requires:author-response label Sep 28, 2021

Be-ing force-pushed the soundtouch_2.3.1 branch from b049559 to 2085db4 Compare September 28, 2021 23:02

github-actions bot approved these changes Sep 28, 2021

View reviewed changes

BillyONeal merged commit 33fb841 into microsoft:master Sep 29, 2021

JackBoosY removed the requires:author-response label Sep 29, 2021

Be-ing deleted the soundtouch_2.3.1 branch September 29, 2021 14:13

Be-ing mentioned this pull request Sep 29, 2021

Vcpkg update / Python 3 package update tenacityteam/tenacity-legacy#650

Merged

5 tasks

Be-ing added a commit to mixxxdj/vcpkg that referenced this pull request Sep 29, 2021

[soundtouch] remove from overlay; use 2.3.1 from upstream

0ed91eb

since microsoft#20017 was merged

Be-ing mentioned this pull request Sep 29, 2021

[soundtouch] enable static build #19377

Closed

BillyONeal mentioned this pull request Sep 29, 2021

Build fixes from 2021-09-28's nightly build. #20435

Merged

Conversation

Be-ing commented Sep 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What does your PR fix?

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

JonLiu1993 commented Sep 7, 2021

Uh oh!

Be-ing commented Sep 7, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Be-ing commented Sep 7, 2021

Uh oh!

Be-ing commented Sep 7, 2021

Uh oh!

JonLiu1993 commented Sep 8, 2021

Uh oh!

Be-ing commented Sep 8, 2021

Uh oh!

JonLiu1993 commented Sep 10, 2021

Uh oh!

Be-ing commented Sep 10, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JonLiu1993 commented Sep 22, 2021

Uh oh!

azure-pipelines bot commented Sep 22, 2021

Uh oh!

JonLiu1993 commented Sep 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Be-ing commented Sep 26, 2021

Uh oh!

JonLiu1993 commented Sep 27, 2021

Uh oh!

azure-pipelines bot commented Sep 27, 2021

Uh oh!

JonLiu1993 commented Sep 27, 2021

Uh oh!

JackBoosY left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

BillyONeal commented Sep 29, 2021

Uh oh!

Be-ing commented Sep 29, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Be-ing commented Sep 7, 2021 •

edited

Loading

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?

Be-ing commented Sep 7, 2021 •

edited

Loading

Be-ing commented Sep 10, 2021 •

edited

Loading

JonLiu1993 commented Sep 22, 2021 •

edited

Loading