[mosquitto] Update to 2.0.12 by ahoarau · Pull Request #20148 · microsoft/vcpkg

ahoarau · 2021-09-14T07:02:15Z

Describe the pull request

What does your PR fix?

Updates mosquitto to 2.0.12. Needed to compile libwebsockets with -DLWS_WITH_EXTERNAL_POLL=ON
Which triplets are supported/not supported? Have you updated the CI baseline?

x64-windows
x64-windows-static
Does your PR follow the maintainer guide?

Yes
If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Yes

JonLiu1993 · 2021-09-15T02:40:11Z

@ahoarau ,Could you please take a look?
install-x64-osx-dbg-out.log

ports/mosquitto/vcpkg.json

ports/mosquitto/portfile.cmake

ports/libwebsockets/vcpkg.json

ports/mosquitto/portfile.cmake

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout e201002b4f4827d7b7b672f0c5c672a77fc3b77d -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index bd3829e..a5439a5 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -4302,7 +4302,7 @@
     },
     "mosquitto": {
       "baseline": "2.0.12",
-      "port-version": 1
+      "port-version": 0
     },
     "mozjpeg": {
       "baseline": "2020-06-02",
diff --git a/versions/m-/mosquitto.json b/versions/m-/mosquitto.json
index 1104207..38cda79 100644
--- a/versions/m-/mosquitto.json
+++ b/versions/m-/mosquitto.json
@@ -1,9 +1,9 @@
 {
   "versions": [
     {
-      "git-tree": "2e46b2468a5fc3e65b85fc427cfaaf8935e23748",
-      "version-string": "2.0.12",
-      "port-version": 1
+      "git-tree": "3fd2cb545018427f11003049816c9443680a6cbc",
+      "version-semver": "2.0.12",
+      "port-version": 0
     },
     {
       "git-tree": "e50ddad9108597e09097e1853e116a62d650044d",

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout e201002b4f4827d7b7b672f0c5c672a77fc3b77d -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index bd3829e..49a9286 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3886,7 +3886,7 @@
     },
     "libwebsockets": {
       "baseline": "4.2.2",
-      "port-version": 2
+      "port-version": 1
     },
     "libxdiff": {
       "baseline": "0.23",
@@ -4302,7 +4302,7 @@
     },
     "mosquitto": {
       "baseline": "2.0.12",
-      "port-version": 1
+      "port-version": 0
     },
     "mozjpeg": {
       "baseline": "2020-06-02",
diff --git a/versions/l-/libwebsockets.json b/versions/l-/libwebsockets.json
index de475d4..1a2f76b 100644
--- a/versions/l-/libwebsockets.json
+++ b/versions/l-/libwebsockets.json
@@ -1,9 +1,9 @@
 {
   "versions": [
     {
-      "git-tree": "9f2a3aa99d2abace2006f27a0ee6dc375a74da5b",
+      "git-tree": "0a15ca8624a958b887745ccbe09c18970b38cf7b",
       "version-semver": "4.2.2",
-      "port-version": 2
+      "port-version": 1
     },
     {
       "git-tree": "d3336ccb948156f48c50ee15980a5bb56374d3b3",
diff --git a/versions/m-/mosquitto.json b/versions/m-/mosquitto.json
index 1104207..38cda79 100644
--- a/versions/m-/mosquitto.json
+++ b/versions/m-/mosquitto.json
@@ -1,9 +1,9 @@
 {
   "versions": [
     {
-      "git-tree": "2e46b2468a5fc3e65b85fc427cfaaf8935e23748",
-      "version-string": "2.0.12",
-      "port-version": 1
+      "git-tree": "3fd2cb545018427f11003049816c9443680a6cbc",
+      "version-semver": "2.0.12",
+      "port-version": 0
     },
     {
       "git-tree": "e50ddad9108597e09097e1853e116a62d650044d",

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout e201002b4f4827d7b7b672f0c5c672a77fc3b77d -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index bd3829e..49a9286 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3886,7 +3886,7 @@
     },
     "libwebsockets": {
       "baseline": "4.2.2",
-      "port-version": 2
+      "port-version": 1
     },
     "libxdiff": {
       "baseline": "0.23",
@@ -4302,7 +4302,7 @@
     },
     "mosquitto": {
       "baseline": "2.0.12",
-      "port-version": 1
+      "port-version": 0
     },
     "mozjpeg": {
       "baseline": "2020-06-02",
diff --git a/versions/l-/libwebsockets.json b/versions/l-/libwebsockets.json
index de475d4..1a2f76b 100644
--- a/versions/l-/libwebsockets.json
+++ b/versions/l-/libwebsockets.json
@@ -1,9 +1,9 @@
 {
   "versions": [
     {
-      "git-tree": "9f2a3aa99d2abace2006f27a0ee6dc375a74da5b",
+      "git-tree": "0a15ca8624a958b887745ccbe09c18970b38cf7b",
       "version-semver": "4.2.2",
-      "port-version": 2
+      "port-version": 1
     },
     {
       "git-tree": "d3336ccb948156f48c50ee15980a5bb56374d3b3",
diff --git a/versions/m-/mosquitto.json b/versions/m-/mosquitto.json
index 1104207..82f68bf 100644
--- a/versions/m-/mosquitto.json
+++ b/versions/m-/mosquitto.json
@@ -1,9 +1,9 @@
 {
   "versions": [
     {
-      "git-tree": "2e46b2468a5fc3e65b85fc427cfaaf8935e23748",
-      "version-string": "2.0.12",
-      "port-version": 1
+      "git-tree": "1d34c11cd0111e5d87e722c6fcae8b8ae5b276c4",
+      "version-semver": "2.0.12",
+      "port-version": 0
     },
     {
       "git-tree": "e50ddad9108597e09097e1853e116a62d650044d",

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 93a8320399e2f0b22877e097dc8216d5c634b8dd -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index bd3829e..49a9286 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3886,7 +3886,7 @@
     },
     "libwebsockets": {
       "baseline": "4.2.2",
-      "port-version": 2
+      "port-version": 1
     },
     "libxdiff": {
       "baseline": "0.23",
@@ -4302,7 +4302,7 @@
     },
     "mosquitto": {
       "baseline": "2.0.12",
-      "port-version": 1
+      "port-version": 0
     },
     "mozjpeg": {
       "baseline": "2020-06-02",
diff --git a/versions/l-/libwebsockets.json b/versions/l-/libwebsockets.json
index de475d4..1a2f76b 100644
--- a/versions/l-/libwebsockets.json
+++ b/versions/l-/libwebsockets.json
@@ -1,9 +1,9 @@
 {
   "versions": [
     {
-      "git-tree": "9f2a3aa99d2abace2006f27a0ee6dc375a74da5b",
+      "git-tree": "0a15ca8624a958b887745ccbe09c18970b38cf7b",
       "version-semver": "4.2.2",
-      "port-version": 2
+      "port-version": 1
     },
     {
       "git-tree": "d3336ccb948156f48c50ee15980a5bb56374d3b3",
diff --git a/versions/m-/mosquitto.json b/versions/m-/mosquitto.json
index 1104207..82f68bf 100644
--- a/versions/m-/mosquitto.json
+++ b/versions/m-/mosquitto.json
@@ -1,9 +1,9 @@
 {
   "versions": [
     {
-      "git-tree": "2e46b2468a5fc3e65b85fc427cfaaf8935e23748",
-      "version-string": "2.0.12",
-      "port-version": 1
+      "git-tree": "1d34c11cd0111e5d87e722c6fcae8b8ae5b276c4",
+      "version-semver": "2.0.12",
+      "port-version": 0
     },
     {
       "git-tree": "e50ddad9108597e09097e1853e116a62d650044d",

JonLiu1993 · 2021-09-16T07:51:33Z

/azp run

azure-pipelines · 2021-09-16T07:51:42Z

Azure Pipelines successfully started running 1 pipeline(s).

JonLiu1993 · 2021-09-16T09:40:59Z

@ahoarau ,The CI test failed ,could you please take a look?
install-x64-osx-dbg-out.log

JonLiu1993 · 2021-09-16T09:43:06Z

After finish your changes,please run command "./vcpkg x-add-version mosquitto --overwrite-version" then commit the changes again

JonLiu1993 · 2021-09-22T09:22:52Z

@ahoarau, Could you please look the error log?

ahoarau · 2021-09-22T09:50:22Z

The error is :

Undefined symbols for architecture x86_64:
  "_mosquitto_callback_register", referenced from:
      _mosquitto_plugin_init in mosquitto_message_timestamp.c.o
  "_mosquitto_callback_unregister", referenced from:
      _mosquitto_plugin_cleanup in mosquitto_message_timestamp.c.o
  "_mosquitto_property_add_string_pair", referenced from:
      _callback_message in mosquitto_message_timestamp.c.o
ld: symbol(s) not found for architecture x86_64

Undefined symbols for architecture x86_64:
  "_mosquitto_callback_register", referenced from:
      _mosquitto_plugin_init in mosquitto_payload_modification.c.o
  "_mosquitto_callback_unregister", referenced from:
      _mosquitto_plugin_cleanup in mosquitto_payload_modification.c.o
  "_mosquitto_calloc", referenced from:
      _callback_message in mosquitto_payload_modification.c.o
ld: symbol(s) not found for architecture x86_64

This guy https://www.eclipse.org/lists/mosquitto-dev/msg02576.html seem to have the same error, and basically disabled PLUGINS.

As they are optional, I believe it is safe to simply not build them. They are not supported on windows anyways

https://github.com/eclipse/mosquitto/blob/master/include/mosquitto_plugin.h

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 93a8320399e2f0b22877e097dc8216d5c634b8dd -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index f4e1ca1..3e52feb 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3890,7 +3890,7 @@
     },
     "libwebsockets": {
       "baseline": "4.2.2",
-      "port-version": 2
+      "port-version": 1
     },
     "libxdiff": {
       "baseline": "0.23",
@@ -4310,7 +4310,7 @@
     },
     "mosquitto": {
       "baseline": "2.0.12",
-      "port-version": 1
+      "port-version": 0
     },
     "mozjpeg": {
       "baseline": "2020-06-02",
diff --git a/versions/l-/libwebsockets.json b/versions/l-/libwebsockets.json
index de475d4..1a2f76b 100644
--- a/versions/l-/libwebsockets.json
+++ b/versions/l-/libwebsockets.json
@@ -1,9 +1,9 @@
 {
   "versions": [
     {
-      "git-tree": "9f2a3aa99d2abace2006f27a0ee6dc375a74da5b",
+      "git-tree": "0a15ca8624a958b887745ccbe09c18970b38cf7b",
       "version-semver": "4.2.2",
-      "port-version": 2
+      "port-version": 1
     },
     {
       "git-tree": "d3336ccb948156f48c50ee15980a5bb56374d3b3",
diff --git a/versions/m-/mosquitto.json b/versions/m-/mosquitto.json
index 1104207..238d683 100644
--- a/versions/m-/mosquitto.json
+++ b/versions/m-/mosquitto.json
@@ -1,9 +1,9 @@
 {
   "versions": [
     {
-      "git-tree": "2e46b2468a5fc3e65b85fc427cfaaf8935e23748",
-      "version-string": "2.0.12",
-      "port-version": 1
+      "git-tree": "5e49649f79a44e0df51e2808f9d21aa79ceae280",
+      "version-semver": "2.0.12",
+      "port-version": 0
     },
     {
       "git-tree": "e50ddad9108597e09097e1853e116a62d650044d",

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/mosquitto/portfile.cmake

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 93a8320399e2f0b22877e097dc8216d5c634b8dd -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/baseline.json b/versions/baseline.json
index aa83b24..3e52feb 100644
--- a/versions/baseline.json
+++ b/versions/baseline.json
@@ -3890,7 +3890,7 @@
     },
     "libwebsockets": {
       "baseline": "4.2.2",
-      "port-version": 2
+      "port-version": 1
     },
     "libxdiff": {
       "baseline": "0.23",
diff --git a/versions/l-/libwebsockets.json b/versions/l-/libwebsockets.json
index de475d4..1a2f76b 100644
--- a/versions/l-/libwebsockets.json
+++ b/versions/l-/libwebsockets.json
@@ -1,9 +1,9 @@
 {
   "versions": [
     {
-      "git-tree": "9f2a3aa99d2abace2006f27a0ee6dc375a74da5b",
+      "git-tree": "0a15ca8624a958b887745ccbe09c18970b38cf7b",
       "version-semver": "4.2.2",
-      "port-version": 2
+      "port-version": 1
     },
     {
       "git-tree": "d3336ccb948156f48c50ee15980a5bb56374d3b3",
diff --git a/versions/m-/mosquitto.json b/versions/m-/mosquitto.json
index 9553593..238d683 100644
--- a/versions/m-/mosquitto.json
+++ b/versions/m-/mosquitto.json
@@ -5,11 +5,6 @@
       "version-semver": "2.0.12",
       "port-version": 0
     },
-    {
-      "git-tree": "2e46b2468a5fc3e65b85fc427cfaaf8935e23748",
-      "version-string": "2.0.12",
-      "port-version": 1
-    },
     {
       "git-tree": "e50ddad9108597e09097e1853e116a62d650044d",
       "version-string": "1.6.8",

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/mosquitto/portfile.cmake

JonLiu1993 · 2021-09-22T10:04:39Z

@ahoarau ,please run command "./vcpkg x-add-version mosquitto --overwrite-version" then commit the changes again

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 93a8320399e2f0b22877e097dc8216d5c634b8dd -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/l-/libwebsockets.json b/versions/l-/libwebsockets.json
index d1be551..1a2f76b 100644
--- a/versions/l-/libwebsockets.json
+++ b/versions/l-/libwebsockets.json
@@ -5,11 +5,6 @@
       "version-semver": "4.2.2",
       "port-version": 1
     },
-    {
-      "git-tree": "9f2a3aa99d2abace2006f27a0ee6dc375a74da5b",
-      "version-semver": "4.2.2",
-      "port-version": 2
-    },
     {
       "git-tree": "d3336ccb948156f48c50ee15980a5bb56374d3b3",
       "version-semver": "4.2.2",
diff --git a/versions/m-/mosquitto.json b/versions/m-/mosquitto.json
index 9553593..238d683 100644
--- a/versions/m-/mosquitto.json
+++ b/versions/m-/mosquitto.json
@@ -5,11 +5,6 @@
       "version-semver": "2.0.12",
       "port-version": 0
     },
-    {
-      "git-tree": "2e46b2468a5fc3e65b85fc427cfaaf8935e23748",
-      "version-string": "2.0.12",
-      "port-version": 1
-    },
     {
       "git-tree": "e50ddad9108597e09097e1853e116a62d650044d",
       "version-string": "1.6.8",

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/mosquitto/portfile.cmake

versions/l-/libwebsockets.json

versions/m-/mosquitto.json

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 93a8320399e2f0b22877e097dc8216d5c634b8dd -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/l-/libwebsockets.json b/versions/l-/libwebsockets.json
index d1be551..1a2f76b 100644
--- a/versions/l-/libwebsockets.json
+++ b/versions/l-/libwebsockets.json
@@ -5,11 +5,6 @@
       "version-semver": "4.2.2",
       "port-version": 1
     },
-    {
-      "git-tree": "9f2a3aa99d2abace2006f27a0ee6dc375a74da5b",
-      "version-semver": "4.2.2",
-      "port-version": 2
-    },
     {
       "git-tree": "d3336ccb948156f48c50ee15980a5bb56374d3b3",
       "version-semver": "4.2.2",

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/mosquitto/portfile.cmake

github-actions

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/mosquitto/portfile.cmake

ports/mosquitto/portfile.cmake

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>

github-actions

This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!

PRs must add only one version and must not modify any published versions

When making any changes to a library, the version or port-version in vcpkg.json or CONTROL must be modified.

Error: Local changes detected for libwebsockets but no changes to version or port version.
-- Version: 4.2.2#1
-- Old SHA: 1f861f30fa2d88ebb0547f48940266517b015cc3
-- New SHA: 30615e7ce9a1ce09d473a05260da695fb0ee56d3
-- Did you remember to update the version or port version?
-- Pass `--overwrite-version` to bypass this check.
***No files were updated.***

After committing all other changes, the version database must be updated

git add -u && git commit
git checkout 8275003fd8c5119cb9438fea1425ebe774f2e527 -- versions
./vcpkg x-add-version --all

Diff

diff --git a/versions/l-/libwebsockets.json b/versions/l-/libwebsockets.json
index 4d2d9b9..6ececa6 100644
--- a/versions/l-/libwebsockets.json
+++ b/versions/l-/libwebsockets.json
@@ -1,7 +1,7 @@
 {
   "versions": [
     {
-      "git-tree": "30615e7ce9a1ce09d473a05260da695fb0ee56d3",
+      "git-tree": "1f861f30fa2d88ebb0547f48940266517b015cc3",
       "version-semver": "4.2.2",
       "port-version": 1
     },

You have modified or added at least one portfile where deprecated functions are used.

Details

If you feel able to do so, please consider migrating them to the new functions:
vcpkg_install_cmake -> vcpkg_cmake_install (from port vcpkg-cmake)
vcpkg_build_cmake -> vcpkg_cmake_build (from port vcpkg-cmake)
vcpkg_configure_cmake -> vcpkg_cmake_configure (Please remove the option PREFER_NINJA) (from port vcpkg-cmake)
vcpkg_fixup_cmake_targets -> vcpkg_cmake_config_fixup (from port vcpkg-cmake-config)

In the ports that use the new function, you have to add the corresponding dependencies:

{
  "name": "vcpkg-cmake",
  "host": true
},
{
  "name": "vcpkg-cmake-config",
  "host": true
}

The following files are affected:

ports/mosquitto/portfile.cmake

ahoarau · 2021-09-25T13:31:41Z

@JonLiu1993 Not sure to understand this CI build error. It was passing before your last suggestion.

BillyONeal · 2021-09-28T00:51:10Z

Thanks for the version update!

https://dev.azure.com/vcpkg/public/_build/results?buildId=60445 PASSING, REMOVE FROM FAIL LIST: soundtouch:x64-windows-static Probably fixed by: microsoft#19377 REGRESSION: mosquitto:x86-windows REGRESSION: mosquitto:x64-windows Probably broken by: microsoft#20148 ``` The following EXEs were found in /bin or /debug/bin. EXEs are not valid distribution targets. D:/packages/mosquitto_x86-windows/bin/mosquitto_ctrl.exe The following EXEs were found in /bin or /debug/bin. EXEs are not valid distribution targets. D:/packages/mosquitto_x86-windows/debug/bin/mosquitto_ctrl.exe Found 2 error(s). Please correct the portfile: C:\a\1\s\ports\mosquitto\portfile.cmake -- Performing post-build validation done ``` The upstream build system has this: ``` option(WITH_CJSON "Build with cJSON support (required for dynamic security plugin and useful for mosquitto_sub)?" ON) if (WITH_CJSON) FIND_PACKAGE(cJSON) if (CJSON_FOUND) message(STATUS ${CJSON_FOUND}) else (CJSON_FOUND) message(STATUS "Optional dependency cJSON not found. Some features will be disabled.") endif(CJSON_FOUND) endif() ``` and indeed, I repro the problem if cjson is installed first. Disable WITH_CJSON as a fix. OSX never finishing: Hopefully fixed by microsoft#20388

https://dev.azure.com/vcpkg/public/_build/results?buildId=60445 PASSING, REMOVE FROM FAIL LIST: soundtouch:x64-windows-static Probably fixed by: #19377 REGRESSION: mosquitto:x86-windows REGRESSION: mosquitto:x64-windows Probably broken by: #20148 ``` The following EXEs were found in /bin or /debug/bin. EXEs are not valid distribution targets. D:/packages/mosquitto_x86-windows/bin/mosquitto_ctrl.exe The following EXEs were found in /bin or /debug/bin. EXEs are not valid distribution targets. D:/packages/mosquitto_x86-windows/debug/bin/mosquitto_ctrl.exe Found 2 error(s). Please correct the portfile: C:\a\1\s\ports\mosquitto\portfile.cmake -- Performing post-build validation done ``` The upstream build system has this: ``` option(WITH_CJSON "Build with cJSON support (required for dynamic security plugin and useful for mosquitto_sub)?" ON) if (WITH_CJSON) FIND_PACKAGE(cJSON) if (CJSON_FOUND) message(STATUS ${CJSON_FOUND}) else (CJSON_FOUND) message(STATUS "Optional dependency cJSON not found. Some features will be disabled.") endif(CJSON_FOUND) endif() ``` and indeed, I repro the problem if cjson is installed first. Disable WITH_CJSON as a fix. OSX never finishing: Hopefully fixed by #20388

Antoine Hoarau added 2 commits September 14, 2021 08:57

update mosquitto to 2.0.12

3856c13

update json

729f1af

github-actions bot approved these changes Sep 14, 2021

View reviewed changes

PhoebeHui assigned JonLiu1993 Sep 14, 2021

JonLiu1993 added the category:port-update The issue is with a library, which is requesting update new revision label Sep 14, 2021

JonLiu1993 added the requires:author-response label Sep 15, 2021

JonLiu1993 suggested changes Sep 15, 2021

View reviewed changes

ports/mosquitto/vcpkg.json Outdated Show resolved Hide resolved

ports/mosquitto/portfile.cmake Show resolved Hide resolved

JonLiu1993 suggested changes Sep 15, 2021

View reviewed changes

ports/libwebsockets/vcpkg.json Outdated Show resolved Hide resolved

dg0yt reviewed Sep 15, 2021

View reviewed changes

ports/mosquitto/portfile.cmake Show resolved Hide resolved

ahoarau and others added 2 commits September 15, 2021 09:54

Update ports/mosquitto/vcpkg.json

a9dc22a

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>

Update ports/libwebsockets/vcpkg.json

b50723e

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>

github-actions bot requested changes Sep 15, 2021

View reviewed changes

add head ref

037f82d

github-actions bot requested changes Sep 15, 2021

View reviewed changes

Merge remote-tracking branch 'origin/master' into HEAD

d9ce434

github-actions bot requested changes Sep 15, 2021

View reviewed changes

JonLiu1993 removed the requires:author-response label Sep 16, 2021

JonLiu1993 added the requires:author-response label Sep 16, 2021

Antoine Hoarau added 2 commits September 22, 2021 11:51

remove plugins

8b900c7

update jsons

99444ae

github-actions bot requested changes Sep 22, 2021

View reviewed changes

JonLiu1993 removed the requires:author-response label Sep 22, 2021

JonLiu1993 added the requires:author-response label Sep 22, 2021

update libwebsockets

ca09343

github-actions bot requested changes Sep 22, 2021

View reviewed changes

JonLiu1993 suggested changes Sep 22, 2021

View reviewed changes

versions/l-/libwebsockets.json Outdated Show resolved Hide resolved

versions/m-/mosquitto.json Outdated Show resolved Hide resolved

ahoarau and others added 2 commits September 22, 2021 12:18

Update versions/m-/mosquitto.json

b30a412

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>

Update versions/l-/libwebsockets.json

2a17dcb

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>

github-actions bot requested changes Sep 22, 2021

View reviewed changes

github-actions bot approved these changes Sep 22, 2021

View reviewed changes

JonLiu1993 removed the requires:author-response label Sep 23, 2021

JonLiu1993 reviewed Sep 23, 2021

View reviewed changes

ports/mosquitto/portfile.cmake Outdated Show resolved Hide resolved

JonLiu1993 added the requires:author-response label Sep 23, 2021

ahoarau and others added 3 commits September 24, 2021 08:52

Update ports/mosquitto/portfile.cmake

ece5fa7

Co-authored-by: JonLiu1993 <63675417+JonLiu1993@users.noreply.github.com>

formatting vcpkg.json

0d070c3

update version

b2b0f13

github-actions bot requested changes Sep 24, 2021

View reviewed changes

JonLiu1993 removed the requires:author-response label Sep 26, 2021

JonLiu1993 approved these changes Sep 26, 2021

View reviewed changes

JonLiu1993 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Sep 26, 2021

BillyONeal merged commit 5aec72b into microsoft:master Sep 28, 2021

BillyONeal mentioned this pull request Sep 29, 2021

Build fixes from 2021-09-28's nightly build. #20435

Merged

Conversation

ahoarau commented Sep 14, 2021

What does your PR fix?

Which triplets are supported/not supported? Have you updated the CI baseline?

Does your PR follow the maintainer guide?

If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

Uh oh!

JonLiu1993 commented Sep 15, 2021

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

JonLiu1993 commented Sep 16, 2021

Uh oh!

azure-pipelines bot commented Sep 16, 2021

Uh oh!

JonLiu1993 commented Sep 16, 2021

Uh oh!

JonLiu1993 commented Sep 16, 2021

Uh oh!

JonLiu1993 commented Sep 22, 2021

Uh oh!

ahoarau commented Sep 22, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

JonLiu1993 commented Sep 22, 2021

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot left a comment

Choose a reason for hiding this comment

Uh oh!

ahoarau commented Sep 25, 2021

Uh oh!

BillyONeal commented Sep 28, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

If you have added/updated a port: Have you run `./vcpkg x-add-version --all` and committed the result?

ahoarau commented Sep 22, 2021 •

edited

Loading