[vcpkg_fixup_cmake_targets] Fix up OSX system development path by JackBoosY · Pull Request #16706 · microsoft/vcpkg

JackBoosY · 2021-03-15T08:07:21Z

In OSX, some cmake configuration files contain the absolute path of the system development kits, such as:

/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/IOKit.framework

\$<\$<PLATFORM_ID:Darwin>:/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk/System/Library/Frameworks/CoreFoundation.framework>

And they should be:

-framework IOKit

\$<\$<PLATFORM_ID:Darwin>:-framework CoreFoundation>

Fix this.

Fixes #16259.

JackBoosY · 2021-03-15T08:09:13Z

@davidebeatrici Can you please test this PR?

Thanks.

ports/vcpkg-cmake-config/vcpkg_cmake_config_fixup.cmake

scripts/cmake/vcpkg_fixup_cmake_targets.cmake

davidebeatrici · 2021-03-18T04:29:13Z

Sorry for the delay.

The issue was fixed for abslTargets.cmake, but not for unofficial-angle-config.cmake:

set_target_properties(unofficial::angle::angle_gpu_info_util PROPERTIES
  INTERFACE_LINK_LIBRARIES "/Library/Developer/CommandLineTools/SDKs/MacOSX11.1.sdk/System/Library/Frameworks/IOKit.framework;/Library/Developer/CommandLineTools/SDKs/MacOSX11.1.sdk/System/Library/Frameworks/CoreFoundation.framework;/Library/Developer/CommandLineTools/SDKs/MacOSX11.1.sdk/System/Library/Frameworks/CoreGraphics.framework;\$<LINK_ONLY:unofficial::angle::angle_common>"
)

scripts/cmake/vcpkg_fixup_cmake_targets.cmake

JackBoosY · 2021-03-21T10:10:37Z

@davidebeatrici Should be good now.

JackBoosY · 2021-03-23T08:30:28Z

Need wait for #16837 merge first.

davidebeatrici · 2021-03-23T08:52:56Z

I confirm it's fixed.

JackBoosY · 2021-03-26T17:28:47Z

/azp run

azure-pipelines · 2021-03-26T17:28:56Z

Azure Pipelines successfully started running 1 pipeline(s).

…jack/16259

JackBoosY · 2021-04-14T02:20:11Z

paraview:x64-osx:

CMake Error in Remoting/Views/CMakeLists.txt:
  Imported target "VTK::opengl" includes non-existent path

    "-framework OpenGL"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.

INTERFACE_INCLUDE_DIRECTORIES "/Library/Developer/CommandLineTools/SDKs/MacOSX11.1.sdk/System/Library/Frameworks/OpenGL.framework"

ports/vcpkg-cmake-config/vcpkg_cmake_config_fixup.cmake

scripts/cmake/vcpkg_fixup_cmake_targets.cmake

ports/vcpkg-cmake-config/vcpkg_cmake_config_fixup.cmake

scripts/cmake/vcpkg_fixup_cmake_targets.cmake

ports/vcpkg-cmake-config/vcpkg_cmake_config_fixup.cmake

scripts/cmake/vcpkg_fixup_cmake_targets.cmake

Fix exported osx framework config

…jack/16259

…nto dev/jack/16259

JackBoosY · 2021-06-16T07:28:16Z

CMake Error at scripts/cmake/vcpkg_configure_cmake.cmake:72 (message):
  The tensorpipe port already depends on vcpkg-cmake; using both vcpkg-cmake
  and vcpkg_configure_cmake in the same port is unsupported.
Call Stack (most recent call first):
  scripts/cmake/vcpkg_internal_get_cmake_vars.cmake:49 (vcpkg_configure_cmake)
  /Users/vagrant/Data/installed/x64-osx/share/vcpkg-cmake-config/vcpkg_cmake_config_fixup.cmake:245 (vcpkg_internal_get_cmake_vars)
  ports/tensorpipe/portfile.cmake:40 (vcpkg_cmake_config_fixup)
  scripts/ports.cmake:139 (include)

Should fix this first.

JackBoosY · 2021-08-02T06:59:17Z

@strega-nil-ms Which rollup will contains this PR's changes?

strega-nil-ms · 2021-08-03T17:43:31Z

@JackBoosY oops, it's gotta be marked or I'll miss; marking now.

strega-nil-ms · 2021-08-09T17:52:42Z

Closed for rollup #19469.

[vcpkg_fixup_cmake_targets] Fix up OSX system development path

@JackBoosY

* [rollup:2021-08-09] PR #16706 (@JackBoosY) [vcpkg_fixup_cmake_targets] Fix up OSX system development path * [rollup:2021-08-09] PR #19238 (@strega-nil) [scripts-audit] vcpkg_download_distfile * [rollup:2021-08-09] PR #19239 (@strega-nil) [scripts-audit] vcpkg_find_fortran * [rollup:2021-08-09] PR #19338 (@strega-nil) [tinyfiledialogs] Fix for good * [rollup:2021-08-09] PR #19348 (@strega-nil) [scripts-audit] vcpkg_fixup_pkgconfig * fix ports.cmake with newer vcpkg_download_distfile * fix vcpkg create * move vcpkg_common_definitions down so that it's not incorrect * fix vcpkg_internal_get_cmake_vars Co-authored-by: nicole mazzuca <mazzucan@outlook.com> Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com> Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>

[vcpkg_fixup_cmake_targets] Fix up OSX system development path

20e3836

JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal category:tool-update The issue is with build tool or build script, which requires update or should be executed correctly labels Mar 15, 2021

JackBoosY assigned PhoebeHui Mar 15, 2021

JackBoosY requested a review from strega-nil March 15, 2021 08:08

strega-nil reviewed Mar 15, 2021

View reviewed changes

ports/vcpkg-cmake-config/vcpkg_cmake_config_fixup.cmake Outdated Show resolved Hide resolved

scripts/cmake/vcpkg_fixup_cmake_targets.cmake Outdated Show resolved Hide resolved

fixing scripts tree rules

7b57ce2

JackBoosY commented Mar 18, 2021

View reviewed changes

scripts/cmake/vcpkg_fixup_cmake_targets.cmake Outdated Show resolved Hide resolved

JackBoosY commented Mar 21, 2021

View reviewed changes

scripts/cmake/vcpkg_fixup_cmake_targets.cmake Outdated Show resolved Hide resolved

Update scripts/cmake/vcpkg_fixup_cmake_targets.cmake

0e1daee

JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label Mar 23, 2021

JackBoosY removed the depends:different-pr This PR or Issue depends on a PR which has been filed label Mar 26, 2021

Merge branch 'master' of https://github.com/JackBoosY/vcpkg into dev/…

34669a6

…jack/16259

This was referenced Apr 6, 2021

[libui] Export system libs on OSX #17095

Merged

[fltk] Fix link to system libs #17094

Merged

JackBoosY commented Apr 14, 2021

View reviewed changes

ports/vcpkg-cmake-config/vcpkg_cmake_config_fixup.cmake Outdated Show resolved Hide resolved

scripts/cmake/vcpkg_fixup_cmake_targets.cmake Outdated Show resolved Hide resolved

JackBoosY added 2 commits April 14, 2021 12:23

Update ports/vcpkg-cmake-config/vcpkg_cmake_config_fixup.cmake

473fc2c

Update scripts/cmake/vcpkg_fixup_cmake_targets.cmake

8e6212d

JackBoosY commented Apr 16, 2021

View reviewed changes

ports/vcpkg-cmake-config/vcpkg_cmake_config_fixup.cmake Outdated Show resolved Hide resolved

scripts/cmake/vcpkg_fixup_cmake_targets.cmake Outdated Show resolved Hide resolved

JackBoosY added 2 commits April 16, 2021 10:27

Update ports/vcpkg-cmake-config/vcpkg_cmake_config_fixup.cmake

151d004

Update scripts/cmake/vcpkg_fixup_cmake_targets.cmake

e6b400e

dg0yt reviewed May 11, 2021

View reviewed changes

ports/vcpkg-cmake-config/vcpkg_cmake_config_fixup.cmake Outdated Show resolved Hide resolved

scripts/cmake/vcpkg_fixup_cmake_targets.cmake Outdated Show resolved Hide resolved

Fix exported osx framework config

73714eb

dg0yt mentioned this pull request May 16, 2021

Fix exported osx framework config JackBoosY/vcpkg#2

Merged

dg0yt and others added 11 commits May 16, 2021 14:06

Revise patterns

3ffe3d1

Match line from keyword to newline

1d85d58

Fix usage of vcpkg_internal_get_cmake_vars

da963a4

Fix pattern matching

6f629ad

Copy changes to vcpkg_fixup_cmake_targets.cmake

f112ecf

Use separate build dir for getting cmake vars

d77688e

Use pristine get_cmake_vars

17ab5e6

Fix variable name

d71129e

Merge pull request #2 from dg0yt/osx-framework-config

96c2367

Fix exported osx framework config

Merge branch 'master' of https://github.com/microsoft/vcpkg into dev/…

3415629

…jack/16259

Merge branch 'dev/jack/16259' of https://github.com/JackBoosY/vcpkg i…

f251599

…nto dev/jack/16259

JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label Jun 16, 2021

dg0yt mentioned this pull request Jul 6, 2021

[scripts-audit] z_vcpkg_get_cmake_vars #18837

Closed

strega-nil mentioned this pull request Jul 6, 2021

[scripts-audit] z_vcpkg_get_cmake_vars #18839

Closed

strega-nil-ms added the info:next-rollup label Aug 3, 2021

strega-nil-ms mentioned this pull request Aug 9, 2021

[rollup:2021-08-09] Rollup PR #19469

Merged

strega-nil-ms closed this Aug 9, 2021

strega-nil-ms pushed a commit to strega-nil/vcpkg that referenced this pull request Aug 11, 2021

[rollup:2021-08-09] PR microsoft#16706 (@JackBoosY)

c145cbc

[vcpkg_fixup_cmake_targets] Fix up OSX system development path

aizuon mentioned this pull request Aug 19, 2021

[ffmpeg] build failure #19647

Closed

JackBoosY deleted the dev/jack/16259 branch May 26, 2022 07:48

Conversation

JackBoosY commented Mar 15, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

JackBoosY commented Mar 15, 2021

Uh oh!

Uh oh!

Uh oh!

davidebeatrici commented Mar 18, 2021

Uh oh!

Uh oh!

Uh oh!

JackBoosY commented Mar 21, 2021

Uh oh!

JackBoosY commented Mar 23, 2021

Uh oh!

davidebeatrici commented Mar 23, 2021

Uh oh!

JackBoosY commented Mar 26, 2021

Uh oh!

azure-pipelines bot commented Mar 26, 2021

Uh oh!

JackBoosY commented Apr 14, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

JackBoosY commented Jun 16, 2021

Uh oh!

JackBoosY commented Aug 2, 2021

Uh oh!

strega-nil-ms commented Aug 3, 2021

Uh oh!

strega-nil-ms commented Aug 9, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

JackBoosY commented Mar 15, 2021 •

edited

Loading

JackBoosY commented Apr 14, 2021 •

edited

Loading