[scripts-audit] z_vcpkg_get_cmake_vars#18837
Closed
strega-nil-ms wants to merge 4 commits intomicrosoft:masterfrom
Closed
[scripts-audit] z_vcpkg_get_cmake_vars#18837strega-nil-ms wants to merge 4 commits intomicrosoft:masterfrom
strega-nil-ms wants to merge 4 commits intomicrosoft:masterfrom
Conversation
this does not change anything, so there's no reason to
Contributor
|
Contributor
|
I wish there was a way to silence the output of this function. It causes an extra "Configuring " which is quite confusing. |
Contributor
Author
|
Closing because this is the wrong account -.- |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rename
vcpkg_internal_get_cmake_vars->z_vcpkg_get_cmake_vars, and do an audit. Also add a cache variable so we don't rerun, and remove theOPTIONSvariable since it probably shouldn't be used.