[scripts-audit] vcpkg_find_fortran#19239
Closed
strega-nil wants to merge 2 commits intomicrosoft:masterfrom
Closed
[scripts-audit] vcpkg_find_fortran#19239strega-nil wants to merge 2 commits intomicrosoft:masterfrom
strega-nil wants to merge 2 commits intomicrosoft:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
strega-nil-ms
force-pushed
the
vcpkg_find_fortran
branch
from
fbf6d31 to
fc596a5
Compare
NancyLi1013
added
category:scripts-audit
category:tool-update
51 tasks
BillyONeal
approved these changes
Aug 3, 2021
Neumann-A
reviewed
Aug 6, 2021
Comment on lines
+130
to
133
| set(vcpkg_find_fortran_MSYS_ROOT "${msys_root}" PARENT_SCOPE) | ||
| set(VCPKG_USE_INTERNAL_Fortran TRUE PARENT_SCOPE) | ||
| set(VCPKG_POLICY_SKIP_DUMPBIN_CHECKS enabled PARENT_SCOPE) | ||
| set(VCPKG_CHAINLOAD_TOOLCHAIN_FILE "${SCRIPTS}/toolchains/mingw.cmake" PARENT_SCOPE) # Switching to MinGW toolchain for Fortran |
Contributor
There was a problem hiding this comment.
should probably be CACHE variables ?
Contributor
|
Closed for rollup #19469. |
strega-nil-ms
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
Aug 11, 2021
[scripts-audit] vcpkg_find_fortran
strega-nil-ms
added a commit
that referenced
this pull request
Aug 16, 2021
* [rollup:2021-08-09] PR #16706 (@JackBoosY) [vcpkg_fixup_cmake_targets] Fix up OSX system development path * [rollup:2021-08-09] PR #19238 (@strega-nil) [scripts-audit] vcpkg_download_distfile * [rollup:2021-08-09] PR #19239 (@strega-nil) [scripts-audit] vcpkg_find_fortran * [rollup:2021-08-09] PR #19338 (@strega-nil) [tinyfiledialogs] Fix for good * [rollup:2021-08-09] PR #19348 (@strega-nil) [scripts-audit] vcpkg_fixup_pkgconfig * fix ports.cmake with newer vcpkg_download_distfile * fix vcpkg create * move vcpkg_common_definitions down so that it's not incorrect * fix vcpkg_internal_get_cmake_vars Co-authored-by: nicole mazzuca <mazzucan@outlook.com> Co-authored-by: Jack·Boos·Yu <47264268+JackBoosY@users.noreply.github.com> Co-authored-by: Billy Robert O'Neal III <bion@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.