[scripts-audit] z_vcpkg_get_cmake_vars#18839
[scripts-audit] z_vcpkg_get_cmake_vars#18839strega-nil wants to merge 8 commits intomicrosoft:masterfrom
Conversation
|
From @dg0yt:
OPTIONS allowed to query additional variable without changing this script. A pending use is in PR #16706. |
|
From @dg0yt: I wish there was a way to silence the output of this function. It causes an extra "Configuring " which is quite confusing. |
I'd say the way to do this is to add the variables to
this is a good point. |
strega-nil-ms
force-pushed
the
scripts-audit/z_vcpkg_get_cmake_vars
branch
3 times, most recently
from
9820af8 to
1857759
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
This is a new experimental fast check for PR issues. Please let us know if this bot is helpful!
After committing all other changes, the version database must be updated
git add -u && git commit
git checkout 4990d2b9510876531eb7e73eeba09210178e804f -- versions
./vcpkg x-add-version --allDiff
diff --git a/versions/f-/ffmpeg.json b/versions/f-/ffmpeg.json
index 85acde8..ed13062 100644
--- a/versions/f-/ffmpeg.json
+++ b/versions/f-/ffmpeg.json
@@ -1,7 +1,7 @@
{
"versions": [
{
- "git-tree": "87ed46717cf5268cc6f4502bafabc28a01bce39c",
+ "git-tree": "337b3b6207cf0bf424472af73439176f835497e1",
"version": "4.4",
"port-version": 11
},
strega-nil-ms
force-pushed
the
scripts-audit/z_vcpkg_get_cmake_vars
branch
from
7212597 to
54573b5
Compare
this does not change anything, so there's no reason to
strega-nil-ms
force-pushed
the
scripts-audit/z_vcpkg_get_cmake_vars
branch
from
1496b1b to
ce9f179
Compare
strega-nil-ms
force-pushed
the
scripts-audit/z_vcpkg_get_cmake_vars
branch
from
ce9f179 to
0045609
Compare
|
Closed for rollup |
[scripts-audit] z_vcpkg_get_cmake_vars
* [rollup:2021-07-26 1/6] PR #18783 (@strega-nil) [scripts-audit] vcpkg_copy_tools and friends * [rollup:2021-07-26 2/6] PR #18898 (@dg0yt) [vcpkg] Fix toolchain compatibility with cmake < 3.15 * [rollup:2021-07-26 3/6] PR #18980 (@strega-nil) [cmake-guidelines] Minor update, for `if()` * [rollup:2021-07-26 4/6] PR #18981 (@strega-nil) [scripts-audit] vcpkg_check_linkage * [rollup:2021-07-26 5/6] PR #19158 (@Hoikas) [vcpkg.cmake] Fix variable case. * [rollup:2021-07-26 6/6] PR #18839 [scripts-audit] z_vcpkg_get_cmake_vars Co-authored-by: nicole mazzuca <mazzucan@outlook.com>
6 participants
Rename vcpkg_internal_get_cmake_vars -> z_vcpkg_get_cmake_vars, and do an audit. Also add a cache variable so we don't rerun, and remove the OPTIONS variable since it probably shouldn't be used.