Skip to content

[scripts] vcpkg_configure_make: do not set --build on macOS#16596

Merged
ras0219-msft merged 2 commits intomicrosoft:masterfrom
autoantwort:osx-no-build
Mar 22, 2021
Merged

[scripts] vcpkg_configure_make: do not set --build on macOS#16596
ras0219-msft merged 2 commits intomicrosoft:masterfrom
autoantwort:osx-no-build

Conversation

@autoantwort
Copy link
Copy Markdown
Contributor

Describe the pull request

See last discussion on #16595

@autoantwort autoantwort changed the title [scripts] vcpkg_configure_make: do not set --host on macOS [scripts] vcpkg_configure_make: do not set --build on macOS Mar 8, 2021
@Neumann-A
Copy link
Copy Markdown
Contributor

closes #16595
closes #16464
wasn't there another PR of you which touched the BUILD_TRIPLET?

@autoantwort
Copy link
Copy Markdown
Contributor Author

wasn't there another PR of you which touched the BUILD_TRIPLET?

None of mine, or not in that way. But I have multiple PRs that fix apple silicon builds.

@autoantwort
Copy link
Copy Markdown
Contributor Author

Hm, but this breaks for example gmp
build-x64-osx-dbg-err.log

@Neumann-A
Copy link
Copy Markdown
Contributor

hmm gmp seems to be on skip on osx?

@autoantwort
Copy link
Copy Markdown
Contributor Author

hmm gmp seems to be on skip on osx?

now with the valid cmake script it builds successfully on my machine

@PhoebeHui PhoebeHui added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Mar 9, 2021
@autoantwort autoantwort requested a review from strega-nil March 14, 2021 14:57
@strega-nil
Copy link
Copy Markdown
Contributor

@autoantwort if it works, can you remove the skip in ci.baseline.txt?

@autoantwort
Copy link
Copy Markdown
Contributor Author

@autoantwort if it works, can you remove the skip in ci.baseline.txt?

There is no skip on osx for gmp or nettle?

@PhoebeHui
Copy link
Copy Markdown
Contributor

PhoebeHui commented Mar 16, 2021

gmp with osx and linux skipped by 'supports' which will be fixed by PR #15957.

After the PR merged, we should rerun this PR.

@PhoebeHui PhoebeHui added the depends:different-pr This PR or Issue depends on a PR which has been filed label Mar 16, 2021
@ras0219-msft
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@ras0219-msft
Copy link
Copy Markdown
Contributor

#15957 has been merged

@autoantwort
Copy link
Copy Markdown
Contributor Author

autoantwort commented Mar 17, 2021

I can not reproduce the libgnutls build error and x264 did not worked before this change (on my mashine). Maybe simply rerun the pipeline?

@PhoebeHui
Copy link
Copy Markdown
Contributor

@autoantwort, I have rerun the CI testing.

@wrobelda
Copy link
Copy Markdown
Contributor

The libgnutls error is unrelated to this PR. I also cannot build it locally from master, even though I could at the time when I created a PR for it (#14242). It should be added as skip in ci.baseline.txt for the time being, I'll look into fixing it.

@PhoebeHui
Copy link
Copy Markdown
Contributor

The libgnutls:x64-osx failed with following failures:

Undefined symbols for architecture x86_64:
  "_libintl_dgettext", referenced from:
      _print_one_paragraph in libopts.a(libopts_la-libopts.o)
  "_libintl_gettext", referenced from:
      _aoGetsText in libcmd-serv.a(serv-args.o)
      _print_one_paragraph in libopts.a(libopts_la-libopts.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[4]: *** [gnutls-serv] Error 1
ld: warning: directory not found for option '-L/Users/vagrant/Data/installed/x64-osx/debug/lib/manual-link'
ld: warning: directory not found for option '-L/Users/vagrant/Data/installed/x64-osx/debug/lib/manual-link/'
Undefined symbols for architecture x86_64:
  "_libintl_dgettext", referenced from:
      _print_one_paragraph in libopts.a(libopts_la-libopts.o)
  "_libintl_gettext", referenced from:
      _aoGetsText in libcmd-cli.a(cli-args.o)
      _print_one_paragraph in libopts.a(libopts_la-libopts.o)
ld: warning: directory not found for option '-L/Users/vagrant/Data/installed/x64-osx/debug/lib/manual-link'
ld: warning: directory not found for option '-L/Users/vagrant/Data/installed/x64-osx/debug/lib/manual-link/'
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[4]: *** [gnutls-cli] Error 1
Undefined symbols for architecture x86_64:
  "_libintl_dgettext", referenced from:
      _print_one_paragraph in libopts.a(libopts_la-libopts.o)
  "_libintl_gettext", referenced from:
      _print_one_paragraph in libopts.a(libopts_la-libopts.o)
      _aoGetsText in libcmd-srp.a(srptool-args.o)
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[4]: *** [srptool] Error 1
make[3]: *** [all-recursive] Error 1
make[2]: *** [all] Error 2
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

@wrobelda
Copy link
Copy Markdown
Contributor

@PhoebeHui yes, this is the issue I was referring to.

@PhoebeHui
Copy link
Copy Markdown
Contributor

PhoebeHui commented Mar 19, 2021

@wrobelda, thanks for confirming this issue! I will submit a PR to disable it.

@ras0219-msft
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@ras0219-msft
Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

@wrobelda
Copy link
Copy Markdown
Contributor

Can confirm this fixes #16464 for me (nettle x64 build on Apple Silicon)

@ras0219-msft ras0219-msft merged commit 7497632 into microsoft:master Mar 22, 2021
@ras0219-msft
Copy link
Copy Markdown
Contributor

This LGTM, thanks everyone!

@autoantwort autoantwort deleted the osx-no-build branch September 1, 2021 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed depends:different-pr This PR or Issue depends on a PR which has been filed

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[nettle] fails to build an x64-osx triplet on Apple Silicon

6 participants