[nettle] fix build on apple arm macs#16595
[nettle] fix build on apple arm macs#16595autoantwort wants to merge 4 commits intomicrosoft:masterfrom
Conversation
|
|
||
| if(VCPKG_TARGET_IS_OSX AND VCPKG_TARGET_ARCHITECTURE MATCHES "x64") | ||
| # fix for apple arm macs (see #16464) | ||
| set(VCPKG_MAKE_BUILD_TRIPLET "--host=x86_64-apple-darwin") |
There was a problem hiding this comment.
Isn't this an error in _vcpkg_determine_autotools_host_arch_mac ?
editted out
There was a problem hiding this comment.
ah wait. it is in _vcpkg_determine_autotools_target_arch_mac
There was a problem hiding this comment.
vcpkg/scripts/cmake/vcpkg_configure_make.cmake
Lines 146 to 160 in c47216a
needs to be fixed for your use case. don't add this extra arguments in every port
There was a problem hiding this comment.
_vcpkg_determine_autotools_host_arch_mac is right. It created the following call:
Command failed: /bin/bash ./../src/48e146e54f-e59f545639.clean/configure --build=arm64-apple-darwin --host=x86_64-apple-darwin ...
The Problem is, that the nettle configure tool can not handle arm64-apple-darwin
There was a problem hiding this comment.
If you only pass --host=x86_64-apple-darwin, everything works. But this is a specific problem of the nettle configure tool. E.g. the icu configure tool can handle --build=arm64-apple-darwin
There was a problem hiding this comment.
why not remove
generally? Configure should be able to figure it out any way. Windows just needs it because configure is not common on windows and needs some help in figuring out the correct one which everywhere works.
There was a problem hiding this comment.
Configure should be able to figure it out any way.
Yeah ok. Then we can remove it.
There was a problem hiding this comment.
Configure should be able to figure it out any way.
As you can see in #16596, gmp does not build without --build=... and I only have tested one package. Because of that I think it is better to stick with the solution of this PR.
There was a problem hiding this comment.
gmp on apple arm seems to be problematic anyway according to the release notes at https://gmplib.org/
There was a problem hiding this comment.
But it currently builds (and it is a dependency of nettle)
|
Waiting to merge #16596 first |
|
Already fixed by #16596 |
Describe the pull request