Skip to content

[gmp] correct supports field to run CI for other platforms#15957

Merged
ras0219-msft merged 9 commits intomicrosoft:masterfrom
Neumann-A:gmp_supports
Mar 16, 2021
Merged

[gmp] correct supports field to run CI for other platforms#15957
ras0219-msft merged 9 commits intomicrosoft:masterfrom
Neumann-A:gmp_supports

Conversation

@Neumann-A
Copy link
Contributor

No description provided.

@NancyLi1013
Copy link
Contributor

This PR is just to test, right? @Neumann-A

@Neumann-A
Copy link
Contributor Author

@NancyLi1013. Not really. The supports field is wrong in gmp and needs fixing. The CI errors is just fallout of the fact that gmp is now actually considered by CI. The errors in mpfr in linux/osx seems to need a VM update but I cannot test what is needed locally.

@NancyLi1013 NancyLi1013 added category:port-bug The issue is with a library, which is something the port should already support and removed invalid labels Feb 2, 2021
@PhoebeHui PhoebeHui self-assigned this Feb 2, 2021
@PhoebeHui
Copy link
Contributor

I will take a look at the CI test failures, @Neumann-A, thanks for fixing this issue!

@PhoebeHui
Copy link
Contributor

PhoebeHui commented Feb 2, 2021

mpfr:x64-linux: after I installed 'texinfo' package, it passed.
build-x64-linux-dbg-err.log:

/mnt/vcpkg-ci/buildtrees/mpfr/src/mpfr-4-8955d4bc66.clean/missing: 81: /mnt/vcpkg-ci/buildtrees/mpfr/src/mpfr-4-8955d4bc66.clean/missing: makeinfo: not found
WARNING: 'makeinfo' is missing on your system.
         You should only need it if you modified a '.texi' file, or
         any other file indirectly affecting the aspect of the manual.
         You might want to install the Texinfo package:
         <http://www.gnu.org/software/texinfo/>
         The spurious makeinfo call might also be the consequence of
         using a buggy 'make' (AIX, DU, IRIX), in which case you might
         want to install GNU make:
         <http://www.gnu.org/software/make/>
make[1]: *** [.././../src/mpfr-4-8955d4bc66.clean/doc/mpfr.info] Error 127
make: *** [all-recursive] Error 1

mpfr:x64-osx: AX_PTHREAD is missing, same failures with #13081 (comment), it requires 'autoconf-archive' package on test machine.

autoreconf: Entering directory `.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --force -I m4
aclocal: warning: couldn't open directory 'm4': No such file or directory
autoreconf: configure.ac: tracing
autoreconf: running: glibtoolize --copy --force
autoreconf: running: /usr/local/Cellar/autoconf/2.69/bin/autoconf --force
configure:14268: error: possibly undefined macro: AX_PTHREAD
      If this token and others are legitimate, please use m4_pattern_allow.
      See the Autoconf documentation.
autoreconf: /usr/local/Cellar/autoconf/2.69/bin/autoconf failed with exit status: 1

mpfr:x86-windows: it requires to update port version

Error: While reading versions for port gmp from file: C:\a\1\s\versions\g-\gmp.json
       File declares version `6.2.1#3` with SHA: 079a172e3fb283db5e4983f392758553aecea189
       But local port with the same verion has a different SHA: 3b7459d7ea886b86c9c80890c0b697df9df3cce1
       Please update the port's version fields and then run:
           vcpkg x-add-version gmp
       to add a new version.

To attempt to resolve all errors at once, run:
    vcpkg x-add-version --all

@PhoebeHui PhoebeHui added the depends:vm-update PR contains changes to the VM provisioning scripts label Feb 2, 2021
@PhoebeHui PhoebeHui requested a review from BillyONeal February 2, 2021 05:56
@PhoebeHui PhoebeHui marked this pull request as ready for review March 16, 2021 08:25
@PhoebeHui PhoebeHui added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Mar 16, 2021
@PhoebeHui
Copy link
Contributor

@ras0219-msft, could you help review and merge this PR?

@ras0219-msft ras0219-msft merged commit 6d3a6a3 into microsoft:master Mar 16, 2021
@ras0219-msft
Copy link
Contributor

LGTM, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support depends:vm-update PR contains changes to the VM provisioning scripts info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants