[gmp] correct supports field to run CI for other platforms#15957
Merged
ras0219-msft merged 9 commits intomicrosoft:masterfrom Mar 16, 2021
Merged
[gmp] correct supports field to run CI for other platforms#15957ras0219-msft merged 9 commits intomicrosoft:masterfrom
ras0219-msft merged 9 commits intomicrosoft:masterfrom
Conversation
Contributor
|
This PR is just to test, right? @Neumann-A |
Contributor
Author
|
@NancyLi1013. Not really. The supports field is wrong in gmp and needs fixing. The CI errors is just fallout of the fact that gmp is now actually considered by CI. The errors in mpfr in linux/osx seems to need a VM update but I cannot test what is needed locally. |
Contributor
|
I will take a look at the CI test failures, @Neumann-A, thanks for fixing this issue! |
Contributor
|
mpfr:x64-linux: after I installed 'texinfo' package, it passed. mpfr:x64-osx: AX_PTHREAD is missing, same failures with #13081 (comment), it requires 'autoconf-archive' package on test machine. mpfr:x86-windows: it requires to update port version |
PhoebeHui
approved these changes
Feb 2, 2021
This was referenced Mar 16, 2021
Contributor
|
@ras0219-msft, could you help review and merge this PR? |
Contributor
|
LGTM, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.