[gdal] Fix usage and add dependencies on UNIX#16088
Closed
JackBoosY wants to merge 8 commits intomicrosoft:masterfrom
Closed
[gdal] Fix usage and add dependencies on UNIX#16088JackBoosY wants to merge 8 commits intomicrosoft:masterfrom
JackBoosY wants to merge 8 commits intomicrosoft:masterfrom
Conversation
JackBoosY
added
category:port-bug
JackBoosY
added
the
depends:different-pr
JackBoosY
changed the title
JackBoosY
removed
the
depends:different-pr
ras0219
reviewed
Feb 9, 2021
ports/gdal/vcpkg-cmake-wrapper.cmake
Outdated
|
|
||
| select_library_configurations(GDAL) | ||
|
|
||
| if (UNIX) |
Contributor
There was a problem hiding this comment.
This should probably switch based on static/dynamic, not on UNIX. This likely means the file should be renamed to vcpkg-cmake-wrapper.cmake.in, this line should become if("@VCPKG_LIBRARY_LINKAGE@" STREQUAL "static"), and we should use configure_file( @ONLY).
Contributor
Author
There was a problem hiding this comment.
@ras0219 I think this suitable for WINDOWS & dynamic and UNIX & (dynamic | static).
What do you think about?
Contributor
Author
|
Waiting for merge #16138. |
JackBoosY
added
depends:different-pr
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
This may also be fixed by #15808 |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
@ras0219-msft Since your PR may last a long time, do I need to continue this PR? |
Member
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
This was referenced Mar 26, 2021
Merged
Contributor
Author
|
Replaced by #15808. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since gdal relies on many ports, and using static gdal library under Unix also needs to use these dependencies, fix the dependencies in Unix.
Add required dependencies giflib and zstd.
Depends on #16085.
Related: #15375.