[ffmpeg] Fix FindFFMPEG lib versions for building opencv[ffmpeg]#16882
[ffmpeg] Fix FindFFMPEG lib versions for building opencv[ffmpeg]#16882vicroms merged 6 commits intomicrosoft:masterfrom genevanmeter:master
Conversation
libavutil, libavdevice, etc. define their versions separate from FFMPEG main version in a version.h file located with each component headers. This change fixes building opencv[ffmpeg] when it attempts to discover the individual versions of FFMPEG libs. Before this change opencv[ffmpeg] would build but the FFMPEG functionality was disabled since all the lib versions were set to 4.3.1
Cheney-W
left a comment
There was a problem hiding this comment.
- Please modify the
Port-Versionof CONTROL to 13. - Please run
.\vcpkg.exe x-add-version ffmpegto update the json file.
Ran vcpkg.exe x-add-version ffmpeg
|
About port's json file, each of your commit changes will modify its git tree value, which means you need to update json file after you have done all the changes and executed the git commit -m "XXX" command. The specific sequence is as follows: If you haven't executed the BTW, osgearth:x64-linux failure is not related with your PR, this is a CI issue, it will be fixed by PR: #16904. |
|
This is great in principle, however I'm not in favour of hardcoding these versions. May I suggest instead to extract the versions from the source files (e.g. from the version.h file of each library, such as https://github.com/FFmpeg/FFmpeg/blob/master/libavcodec/version.h)? |
|
Please solve the file conflicts first. Thanks. |
libavutil, libavdevice, etc. define their versions separate from FFMPEG main version in a version.h file located with each component headers.
This change fixes building opencv[ffmpeg] when it attempts to discover the individual versions of FFMPEG libs. Before this change opencv[ffmpeg] would build but the FFMPEG functionality was disabled since all the lib versions were set to 4.3.1 and didn't meet its requirements.