Skip to content

[netcdf-c] Fix usage#16085

Merged
ras0219-msft merged 2 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/fix-netcdf-c-usage
Feb 8, 2021
Merged

[netcdf-c] Fix usage#16085
ras0219-msft merged 2 commits intomicrosoft:masterfrom
JackBoosY:dev/jack/fix-netcdf-c-usage

Conversation

@JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Feb 7, 2021 •
edited
Loading

  • netcdf-c generates cmake configure files in directory netcdf, not netcdf-c. Fix this.
  • Remove usage since vcpkg can automatic generate it.

Related: #15375.

@JackBoosY JackBoosY added category:port-bug The issue is with a library, which is something the port should already support info:internal labels Feb 7, 2021
@JackBoosY JackBoosY requested a review from NancyLi1013 February 7, 2021 08:27
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Feb 7, 2021
@JackBoosY JackBoosY mentioned this pull request Feb 7, 2021
Closed
@ras0219-msft ras0219-msft merged commit 7a43817 into microsoft:master Feb 8, 2021
@ras0219-msft
Copy link
Contributor

ras0219-msft commented Feb 8, 2021

LGTM, thanks!

@JackBoosY JackBoosY deleted the dev/jack/fix-netcdf-c-usage branch February 9, 2021 01:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NancyLi1013 NancyLi1013

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JackBoosY @ras0219-msft @NancyLi1013