Skip to content

[libcbor] New port#16884

Merged
vicroms merged 4 commits intomicrosoft:masterfrom
xgcssch:master
Mar 29, 2021
Merged

[libcbor] New port#16884
vicroms merged 4 commits intomicrosoft:masterfrom
xgcssch:master

Conversation

@xgcssch
Copy link
Contributor

@xgcssch xgcssch commented Mar 25, 2021

This is a new port for libcbor - https://github.com/PJK/libcbor

  • What does your PR fix?
    -/-

  • Which triplets are supported/not supported?
    x64-windows
    x86-windows
    x64-windows-static

  • Have you updated the CI baseline?
    No, as i haven't seen the results

  • Does your PR follow the maintainer guide?
    Yes

This port is an dependency for fido2 which i will add as an new port when this port is merged

Best regards
Sönke

@Cheney-W Cheney-W self-assigned this Mar 26, 2021
@Cheney-W Cheney-W added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Mar 26, 2021
@Cheney-W
Copy link
Contributor

Thanks for your PR!
Please run .\vcpkg.exe format-manifest --all to update your vcpkg.json file.

@Cheney-W
Copy link
Contributor

Please run .\vcpkg.exe x-add-version {port name} --overwrite-version to update the {port}.json file.

@xgcssch
Copy link
Contributor Author

xgcssch commented Mar 26, 2021

Hi!
Must x-add-version be run every time a change was made as part of a commit?

@Cheney-W
Copy link
Contributor

About port's json file, each of your commit changes will modify its git tree value, which means you need to update json file after you have done all the changes and executed the git commit -m "XXX" command. The specific sequence is as follows:

Git checkout -b "xxx"
Modify the local files
Git diff
Git add .
Git commit -m "comments description"
.\vcpkg x-add-version {Port name}
Git add .
Git commit -m "comments description"
git push

If you haven't executed the '. \vcpkg x-add-version {port name}' on the current branch, you need to use it after your modification is completed and submitted.
If you have executed this command on the current branch, you need to execute the following command when you need to update the json file:
.\vcpkg.exe x-add-version {port name} --overwrite-version

@xgcssch
Copy link
Contributor Author

xgcssch commented Mar 26, 2021

Thanks for the clarification!

@Cheney-W
Copy link
Contributor

Cheney-W commented Mar 26, 2021

osgearth:x64-linux failure is a CI issue, it will be fixed by PR #16904.

@JackBoosY JackBoosY added the depends:different-pr This PR or Issue depends on a PR which has been filed label Mar 26, 2021
@Cheney-W Cheney-W added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed depends:different-pr This PR or Issue depends on a PR which has been filed labels Mar 29, 2021
@vicroms vicroms merged commit d4c34fd into microsoft:master Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:new-port The issue is requesting a new library to be added; consider making a PR! info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants