[mpc/mpfr] Add new port / update mpfr#13081
Merged
dan-shaw merged 16 commits intomicrosoft:masterfrom Jan 25, 2021
Merged
Conversation
Contributor
Author
|
@BillyONeal: depends VM update: 2c2f1e4 . AX_PTHREAD missing. https://www.gnu.org/software/autoconf-archive/ax_pthread.html |
JackBoosY
added
category:new-port
NancyLi1013
suggested changes
Aug 24, 2020
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
JackBoosY
approved these changes
Aug 24, 2020
JackBoosY
added
depends:vm-update
NancyLi1013
approved these changes
Aug 25, 2020
Contributor
|
mipr:x64-linux: |
Contributor
Author
|
@NancyLi1013: Why requires author-response? autoconf-archive is missing which is why the error is there. See comment #13081 (comment) |
Contributor
|
Thanks for your reply. @Neumann-A |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
|
The failure on x86-windows: |
Contributor
Author
|
@NancyLi1013: Probably due to the changes to msys. Will only touch it if linux vm has the required deps installed otherwise CI will just be red any way. |
Contributor
|
/azp run |
|
No pipelines are associated with this pull request. |
Contributor
Contributor
|
@Neumann-A I will try to repro it manually. icu doesn't have any dependencies. Totally there are 248 ports were built before building icu. |
Contributor
|
Although I installed these all 248 ports before install icu, I still can't repro this regression. |
Contributor
|
Install scintilla before install icu, this regression can't repro too. @BillyONeal Do you have any suggestions to repro this? |
Contributor
|
log about icu regression: |
Contributor
Author
|
Yeah green ... but i am curious what happened to the regression |
JackBoosY
approved these changes
Jan 19, 2021
Contributor
|
@Neumann-A Anyway, I recorded that in this PR. |
JackBoosY
added
the
info:needs-maintainer-attention
vicroms
reviewed
Jan 19, 2021
| { | ||
| "name": "gmp", | ||
| "version-string": "6.2.1-2", | ||
| "version-string": "6.2.1", |
Member
There was a problem hiding this comment.
Since this already uses a manifest file, why not use version-semver or version versioning schemes?
Contributor
Author
There was a problem hiding this comment.
Why should it? This is a vcpkg internal update.
As such port-version is the correct thing and should have been from the beginning.
Member
There was a problem hiding this comment.
In my opinion we should start switching packages to their correct versioning schemes.
Since "version-string" are non-orderable (except by their port version number) by design, continuing to use them will seriously limit the usefulness of "version>=" constraints.
Contributor
Author
There was a problem hiding this comment.
I am just doing what vcpkg x-add-version does. If you want "version": "6.2.1", here please tell/teach the command to do that.
vicroms
approved these changes
Jan 19, 2021
JackBoosY
approved these changes
Jan 22, 2021
Contributor
full log Will try to rerun the test. |
Contributor
|
It seems a baseline regression. |
Contributor
|
Already merged from master. |
dan-shaw
approved these changes
Jan 25, 2021
Jimmy-Hu
added a commit
to Jimmy-Hu/vcpkg
that referenced
this pull request
Jan 25, 2021
[mpc/mpfr] Add new port / update mpfr (microsoft#13081)
Contributor
|
@BillyONeal this is an example of what I was trying to discuss with you earlier: this PR changed a dependency, from mpir to gmp, without any additional note, and broke downstream check in CI for other ports without anyone noticing. The problem is that now, due to already accepted failures in baseline, all ports that were depending on mpir and mpfr are now broken by default, since gmp cannot be installed if mpir is installed. TL;DR : try to install openmvs now. It depends on both gmp and mpir and so it's bound to fail. It was not before. It is completely untested by ci now, and it was not before. This is only an example. |
Contributor
|
That's similar to what I experience always with the opencv port. Somehow, externally it gets broken and no-one gets notified about that. That just means more work to fix parallel unrelated ports every time I want to update it (and make it really work of course, not just pretending it) |
Contributor
Author
probably due to #13081 (comment). Need to install Trying to fix it in #15860 but I really need an inverse dependency lookup for those issues (e.g. |
Contributor
|
Yes, you should put a note in the port file for linux and osx to install autoconf-archive (both on apt and in brew). |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
might depend on #12936 if windows CI fails