Skip to content

[gmp/nettle] Update to latest release revision#15236

Merged
BillyONeal merged 6 commits intomicrosoft:masterfrom
PhoebeHui:dev/Phoebe/gmp
Dec 28, 2020
Merged

[gmp/nettle] Update to latest release revision#15236
BillyONeal merged 6 commits intomicrosoft:masterfrom
PhoebeHui:dev/Phoebe/gmp

Conversation

@PhoebeHui
Copy link
Contributor

@PhoebeHui PhoebeHui commented Dec 21, 2020 •
edited
Loading

Fixes #13172

gmp:

  1. The source issue [VS2019 16.7.2]error MSB3843: Project "libgmp" targets platform "Windows", but references SDK "Visual C++ 2015 Runtime for Universal Windows Platform Apps v14.0" which targets platform "UAP ShiftMediaProject/gmp#9 has been fixed in upstream in latest revision, update the revision to fix issue with x64-uwp when build with vs2019.
  2. Update the patch to match the source changes.
  3. Merge patch runtime.patch and prefix.patch

nettle:

  1. nettle need update togather with gmp
  2. Update to latest release revision 3.6
  3. Update the patch to match the source change
  4. Merge patch runtime.nettle.patch and runtime.hogweed.patch

No new patches involved in this PR. there is no features need to be tested locally.

@PhoebeHui PhoebeHui added category:port-bug The issue is with a library, which is something the port should already support info:internal category:port-update The issue is with a library, which is requesting update new revision labels Dec 21, 2020
@PhoebeHui PhoebeHui marked this pull request as draft December 22, 2020 06:32
@PhoebeHui PhoebeHui marked this pull request as ready for review December 22, 2020 07:26
@PhoebeHui PhoebeHui marked this pull request as draft December 22, 2020 10:48
@PhoebeHui PhoebeHui marked this pull request as ready for review December 23, 2020 07:42
@PhoebeHui PhoebeHui changed the title [gmp] Update to 6.2.1-2 [gmp/nettle] Update to latest release revision Dec 23, 2020
@JackBoosY JackBoosY added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Dec 24, 2020
BillyONeal
BillyONeal reviewed Dec 27, 2020
View reviewed changes
ports/gmp/vcpkg.json
"name": "gmp",
"version-string": "6.2.0",
"port-version": 5,
"version-string": "6.2.1-2",
Copy link
Member

@BillyONeal BillyONeal Dec 27, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note to other reviewers: this -2 is in the upstream versioning scheme and is unrelated to our port-version conventions.

@JackBoosY JackBoosY added requires:author-response and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Dec 28, 2020
@JackBoosY JackBoosY added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:author-response labels Dec 28, 2020
@BillyONeal BillyONeal merged commit da09069 into microsoft:master Dec 28, 2020
ryukw7 pushed a commit to ryukw7/vcpkg that referenced this pull request Dec 29, 2020
@PhoebeHui
[gmp/nettle] Update to latest release revision (microsoft#15236)
e964baa
cenit
cenit reviewed Feb 1, 2021
View reviewed changes
ports/gmp/vcpkg.json
"version-string": "6.2.1-2",
"description": "The GNU Multiple Precision Arithmetic Library",
"homepage": "https://gmplib.org",
"supports": "windows & !(arm | arm64)",
Copy link
Contributor

@cenit cenit Feb 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This precise line removed GMP tests from CI for many configs without further notice @Neumann-A #15957 .
It should be highlighted much more @BillyONeal . This "Supports:" field is bound for "disaster" otherwise as already happened.
Also, similar but independent issue, IMHO CI should test even non-supported configs, and then accept failure if told so. Similar to ci.baseline.txt, so to speak...

Copy link
Member

@BillyONeal BillyONeal Feb 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I must have missed this on review and shouldn't have merged that. Oops!

Copy link
Contributor

@cenit cenit Feb 1, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It happens, don't worry :)
But tools should help us avoid these mistakes, that's what I wanted to highlight!

Copy link
Contributor Author

@PhoebeHui PhoebeHui Feb 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my fault, sorry for my mistakes! I will submit a PR to fix it.

Copy link
Contributor

@cenit cenit Feb 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Neumann-A already did it

@PhoebeHui PhoebeHui deleted the dev/Phoebe/gmp branch February 7, 2021 06:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@BillyONeal BillyONeal BillyONeal left review comments

+3 more reviewers

@cenit cenit cenit left review comments

@NancyLi1013 NancyLi1013 NancyLi1013 approved these changes

@JackBoosY JackBoosY JackBoosY approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@NancyLi1013 NancyLi1013

@JackBoosY JackBoosY

Labels

category:port-bug The issue is with a library, which is something the port should already support category:port-update The issue is with a library, which is requesting update new revision info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[gmp] Visual Studio 2019 version 16.7 breaks gmp:x64-uwp

5 participants

@PhoebeHui @cenit @BillyONeal @NancyLi1013 @JackBoosY