[vcpkg baseline] [vs-yasm] Build yasm instead of downloading it to work around memory corruption bugs in yasm itself.#14003
Merged
BillyONeal merged 20 commits intomicrosoft:masterfrom Oct 28, 2020
Conversation
… from source. Works around yasm/yasm#153 . Should resolve microsoft#12237 .
PhoebeHui
added
the
category:port-feature
C:\Dev\vcpkg\buildtrees\gmp\x64-windows-static-rel\adcc6b3cc4-2b6258d695.clean\SMP\obj\Release\x64\libgmp\addaddmul_1msb0.obj : fatal error LNK1106: invalid file or disk full: cannot seek to 0x23B :(
Member
Author
|
/azp run |
|
No pipelines are associated with this pull request. |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…_find_acquire_program(YASM) with yasm-tool-helper
Contributor
|
This seems like an issue for cross-compilation; have you considered the fallout there? |
Member
Author
|
@strega-nil Yes, but I don't see another way. We can't be shipping ports which fail every 2 seconds because their build tools have memory corruption bugs. |
Contributor
|
hm. I don't like it but yeah, you're right. We seriously need to ship tool ports. |
# Conflicts: # toolsrc/src/vcpkg/base/files.cpp
PhoebeHui
changed the title
This was referenced Oct 28, 2020
ras0219
approved these changes
Oct 28, 2020
Contributor
ras0219
left a comment
ras0219
left a comment
There was a problem hiding this comment.
LGTM once comments are addressed
| #ifdef _WIN32 | ||
| fs::path win32_fix_path_case(const fs::path& source) | ||
| { | ||
| using fs::is_slash; |
Contributor
There was a problem hiding this comment.
Suggested change
| using fs::is_slash; |
since the use below is qualified?
Member
Author
There was a problem hiding this comment.
The use below is not qualified:
if (last - first >= 3 && is_slash(first[0]) && is_slash(first[1]) && !is_slash(first[2]))
GitHub's review tool failed you.
ports/yasm-tool/portfile.cmake
Outdated
| @@ -0,0 +1,37 @@ | |||
| vcpkg_fail_port_install(MESSAGE "The yasm-tool port currently only supports Windows" ON_TARGET "Linux" "OSX" ON_ARCH "x64" "arm") | |||
Contributor
There was a problem hiding this comment.
Suggested change
| vcpkg_fail_port_install(MESSAGE "The yasm-tool port currently only supports Windows" ON_TARGET "Linux" "OSX" ON_ARCH "x64" "arm") | |
| vcpkg_fail_port_install(MESSAGE "The yasm-tool port is only intended to be built for x86 Windows" ON_TARGET "Linux" "OSX" ON_ARCH "x64" "arm") |
| @@ -9,14 +9,15 @@ if(VCPKG_TARGET_IS_WINDOWS) | |||
| REF e140dfc8668e96d7e56cbd46467945adcc6b3cc4 #v6.2.0 | |||
Contributor
There was a problem hiding this comment.
This is missing a port-version update.
Member
Author
There was a problem hiding this comment.
That was intentional because there are no changes in the output but...
arthurt
added a commit
to arthurt/libsndfile
that referenced
this pull request
Nov 30, 2020
arthurt
added a commit
to arthurt/libsndfile
that referenced
this pull request
Nov 30, 2020
arthurt
added a commit
to arthurt/libsndfile
that referenced
this pull request
Dec 21, 2020
arthurt
added a commit
to arthurt/libsndfile
that referenced
this pull request
Jan 4, 2021
arthurt
added a commit
to arthurt/libsndfile
that referenced
this pull request
Jan 23, 2021
arthurt
added a commit
to arthurt/libsndfile
that referenced
this pull request
Mar 22, 2021
arthurt
added a commit
to libsndfile/libsndfile
that referenced
this pull request
Mar 25, 2021
strega-nil
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
May 5, 2021
…rk around memory corruption bugs in yasm itself. (microsoft#14003)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Works around yasm/yasm#153 .
Should resolve #12237 .