Skip to content

[vcpkg] mingw: Add compiler executable name into toolchain file#14269

Merged
BillyONeal merged 1 commit intomicrosoft:masterfrom
longnguyen2004:mingw-compiler-detection
Oct 30, 2020
Merged

[vcpkg] mingw: Add compiler executable name into toolchain file#14269
BillyONeal merged 1 commit intomicrosoft:masterfrom
longnguyen2004:mingw-compiler-detection

Conversation

@longnguyen2004
Copy link
Contributor

@longnguyen2004 longnguyen2004 commented Oct 28, 2020

Describe the pull request

  • What does your PR fix?
    As CMake doesn't automatically detect gcc when the target is windows-gnu anymore, we have to set CMAKE_C_COMPILER and CMAKE_CXX_COMPILER by ourselves.
  • Which triplets are supported/not supported? Have you updated the CI baseline?
    All mingw triplets
  • Does your PR follow the maintainer guide?
    Yes

@longnguyen2004 longnguyen2004 changed the title mingwAdd compiler executable name into toolchain file mingw: Add compiler executable name into toolchain file Oct 28, 2020
@LilyWangL LilyWangL self-assigned this Oct 28, 2020
@LilyWangL LilyWangL added the category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed label Oct 28, 2020
@LilyWangL LilyWangL changed the title mingw: Add compiler executable name into toolchain file [vcpkg] mingw: Add compiler executable name into toolchain file Oct 28, 2020
@LilyWangL
Copy link
Contributor

LilyWangL commented Oct 28, 2020

Baseline error will be fixed in PR #14003.

@LilyWangL LilyWangL added the depends:different-pr This PR or Issue depends on a PR which has been filed label Oct 28, 2020
@BillyONeal
Copy link
Member

BillyONeal commented Oct 29, 2020

/azp run

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 29, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@LilyWangL LilyWangL added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed depends:different-pr This PR or Issue depends on a PR which has been filed labels Oct 29, 2020
@BillyONeal BillyONeal merged commit 6edef9f into microsoft:master Oct 30, 2020
@BillyONeal
Copy link
Member

BillyONeal commented Oct 30, 2020

Thanks!

@longnguyen2004 longnguyen2004 deleted the mingw-compiler-detection branch October 31, 2020 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@LilyWangL LilyWangL LilyWangL approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@LilyWangL LilyWangL

Labels

category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@longnguyen2004 @LilyWangL @BillyONeal