Skip to content

[libjuice] Update libjuice for libdatachannel port.#14213

Merged
strega-nil merged 4 commits intomicrosoft:masterfrom
Nemirtingas:libjuice_update
Nov 18, 2020
Merged

[libjuice] Update libjuice for libdatachannel port.#14213
strega-nil merged 4 commits intomicrosoft:masterfrom
Nemirtingas:libjuice_update

Conversation

@Nemirtingas
Copy link
Contributor

A version update for libjuice.

  • What does your PR fix?
    Need to update libjuice to merge libdatachannel port.

@NancyLi1013 NancyLi1013 added the category:port-update The issue is with a library, which is requesting update new revision label Oct 26, 2020
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013
Copy link
Contributor

The failure on x86-windows caused by gmp will be fixed via PR #14003.

@NancyLi1013 NancyLi1013 added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label Oct 29, 2020
@NancyLi1013
Copy link
Contributor

LGTM now, thanks for your PR @Nemirtingas.

@BillyONeal
Copy link
Member

@Nemirtingas Upstream seems to release fairly frequently here and this updates the port from an orderable version to an unorderable version. Have you asked upstream (or @paullouisageneau or @hanseuljun who seem to contribute there) to drop a release?

Thanks!

@paullouisageneau
Copy link

I'm planning to do a 0.10.0 release of libdatachannel after integrating one last big PR, probably in one week or so. I'll release libjuice at the same time.

@BillyONeal BillyONeal added depends:upstream-changes Waiting on a change to the upstream project and removed info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. labels Nov 2, 2020
@BillyONeal
Copy link
Member

@paullouisageneau Thanks! Can you let us know when that happens? We'll update this to your released copy.

@paullouisageneau
Copy link

paullouisageneau commented Nov 15, 2020

@BillyONeal @Nemirtingas Hello, libjuice v0.6.0 and libdatachannel v0.10.1 have been released, thanks for you patience!

@Nemirtingas
Copy link
Contributor Author

Hi, I'll work on the vcpkg port then, ty.

@Nemirtingas
Copy link
Contributor Author

Libjuice is updated to v0.6.0.

@NancyLi1013
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@NancyLi1013 NancyLi1013 removed the depends:upstream-changes Waiting on a change to the upstream project label Nov 17, 2020
Co-authored-by: NancyLi1013 <46708020+NancyLi1013@users.noreply.github.com>
@strega-nil
Copy link
Contributor

Thanks @Nemirtingas !

@strega-nil strega-nil merged commit e93bc55 into microsoft:master Nov 18, 2020
@Nemirtingas Nemirtingas deleted the libjuice_update branch November 22, 2020 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-update The issue is with a library, which is requesting update new revision

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants