[sdl2] skip ibus on linux#14275
Conversation
JackBoosY
added
the
category:port-bug
|
The gmp regression is not related to this PR's changes and will be fixed in #14003. |
JackBoosY
added
the
info:needs-maintainer-attention
|
Thanks for your contribution! |
|
I'm not an expert in all this stuff or how pkg-config works, but why were the ibus dependencies ending up in pkg-config in the first place? SDL2 dynamically loads everything at runtime and I can't see any references to these libraries in the pkg-config file for, say |
|
That change was more two years ago, and the patch was dropped half a year ago. |
|
I did some more looking around and it does look like this older version of SDL didn't link dynamically at runtime, so I guess this was necessary at the time. However ibus is still disabled to this day in the port which is probably something worth fixing nowadays. |
This was disabled in microsoft#14275 because it caused the relevant libraries (ibus, glib, ...) to be depended on transitively. Nowadays, SDL2 loads these completely at runtime, only needing the headers and such at compile time, so it's safe to re-enable this again. Ibus is gated behind the "ibus" feature, which like the existing x11/wayland ones warn at installation that you need the necessary system packages to use it. The ibus feature is enabled by default.
* [sdl2] Re-enable ibus as feature This was disabled in #14275 because it caused the relevant libraries (ibus, glib, ...) to be depended on transitively. Nowadays, SDL2 loads these completely at runtime, only needing the headers and such at compile time, so it's safe to re-enable this again. Ibus is gated behind the "ibus" feature, which like the existing x11/wayland ones warn at installation that you need the necessary system packages to use it. The ibus feature is enabled by default. * [sdl2] Update baseline
5 participants
Describe the pull request
This patch removes all ibus detection on linux. When detected, ibus will add glib-2.0, gobject-2.0, gio-2.0 and ibus-1.0 as link libraries to the resulting sdl2 library. By skipping ibus entirely, we avoid having to declare these libraries as system libraries and adding a dependency on glib2.
What does your PR fix? Fixes [sdl2] Fix pkgconfig: missing system libs #13551
Which triplets are supported/not supported? Have you updated the CI baseline?
The patch applies to a Linux-only part of sdl2's CMakeLists. Baseline updated before opening PR.
Yes