Skip to content

[vcpkg] Move CI cleaning back out of the 'ci' command into a separate command to restore cross-compilation preinstalls.#11545

Merged
BillyONeal merged 1 commit intomicrosoft:masterfrom
BillyONeal:preinstall_ci
May 28, 2020
Merged

[vcpkg] Move CI cleaning back out of the 'ci' command into a separate command to restore cross-compilation preinstalls.#11545
BillyONeal merged 1 commit intomicrosoft:masterfrom
BillyONeal:preinstall_ci

Conversation

@BillyONeal
Copy link
Member

No description provided.

@LilyWangL
Copy link
Contributor

Please remove the following command in scripts/ci.baseline.txt. Thanks.

protobuf:x64-uwp=ignore
protobuf:arm64-windows=ignore
protobuf:arm-uwp=ignore

@NancyLi1013
Copy link
Contributor

@BillyONeal

Could you help also add this for ignition-msgs5?
#11538 (comment)

@BillyONeal
Copy link
Member Author

@NancyLi1013 This PR appears unrelated to that one other than that this one should merge first because it restores a workaround in CI upon which the other one depends.

… command to restore cross-compilation preinstalls.
@NancyLi1013
Copy link
Contributor

@BillyONeal Thanks for your clarification. Seems the CI in that PR has passed now.

@JackBoosY
Copy link
Contributor

Related: #11502.

@PhoebeHui
Copy link
Contributor

@BillyONeal, does this changes test by CI system actually?

@BillyONeal
Copy link
Member Author

@PhoebeHui This change just puts a workaround back in place that I accidentally removed in f2c46e7

I have been testing the change as part of the effort to refresh the workers, which does a complete rebuild. ( #11365 ) (There are a few failures there, but none related to this)

@BillyONeal BillyONeal merged commit d9b4acf into microsoft:master May 28, 2020
@BillyONeal BillyONeal deleted the preinstall_ci branch May 28, 2020 01:40
strega-nil pushed a commit to strega-nil/vcpkg that referenced this pull request May 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:infrastructure Pertaining to the CI/Testing infrastrucutre

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants