Skip to content

[boost] MinGW build fixes#11427

Merged
dan-shaw merged 1 commit intomicrosoft:masterfrom
koprok:mingw-boost
Jun 5, 2020
Merged

[boost] MinGW build fixes#11427
dan-shaw merged 1 commit intomicrosoft:masterfrom
koprok:mingw-boost

Conversation

@koprok
Copy link
Contributor

@koprok koprok commented May 18, 2020

Fixes boost libraries build errors using MinGW toolchain.

@PhoebeHui
Copy link
Contributor

I summited PR #11496 for fixing the baseline failures which blocks this PR.

@PhoebeHui
Copy link
Contributor

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@PhoebeHui
Copy link
Contributor

PR #11545 would fix boost failures with arm64_windows.

@PhoebeHui PhoebeHui added the category:port-bug The issue is with a library, which is something the port should already support label May 26, 2020
@koprok
Copy link
Contributor Author

koprok commented May 28, 2020

@PhoebeHui, I have accumulated several more MinGW build fixes for other ports. What do you prefer, i.e. how it would be easier for you:

  • add all my MinGW port fixes to this branch for review and merge them all at once;
  • or make a separate merge request for any additional MinGW port fixes?

@PhoebeHui
Copy link
Contributor

@koprok, I suggest to make a separate merge request for any additional MinGW port fixes, it's more easier to review or to fix the failures in CI testing.

Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PhoebeHui PhoebeHui added the info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. label May 28, 2020
@dan-shaw dan-shaw merged commit cb8a9fe into microsoft:master Jun 5, 2020
@koprok koprok deleted the mingw-boost branch June 7, 2020 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:port-bug The issue is with a library, which is something the port should already support info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants