[vcpkg/scripts/meson] add cross file and some minor corrections#11543
[vcpkg/scripts/meson] add cross file and some minor corrections#11543Neumann-A wants to merge 5 commits intomicrosoft:masterfrom
Conversation
….cmake. Set debug to true or false
|
Do you know how to add meson to the linux/osx azure image ? |
|
probably should set |
- remove some unnecssary spaces - remove unnecessary prefix definition from pkg-config call (since *.pc files should have been made relocatable with vcpkg_fixup_pkgconfig)
PhoebeHui
added
category:vcpkg-feature
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
The failures in boost with arm64 should adress by #11545 |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
What is the status of this pr ? |
JackBoosY
added
the
info:needs-maintainer-attention
| @@ -0,0 +1,21 @@ | |||
| [binaries] | |||
There was a problem hiding this comment.
Is it possible to autogenerate this file from the toolchain?
There was a problem hiding this comment.
Probably Yes. Needs to be done anyway since vcpkg_configure_make also requires that information to correctly set all build flags.
We need some kind of vcpkg_determine_compile_settings_from_cmake or similar to generate the required information for vcpkg_configure_make and vcpkg_configure_meson and maybe other not CMake related ports.
There was a problem hiding this comment.
Also meson tries to do it the other way around e.g. have a meson crossfile and generate a cmake toolchain out of it.
There was a problem hiding this comment.
I think we should figure out how to autogenerate this file before merging this. Otherwise, we may have too many files to maintain.
There was a problem hiding this comment.
Existing places where we already do this kind of thing are in the boost helpers and openssl-unix ports:
https://github.com/microsoft/vcpkg/blob/master/ports/boost-modular-build-helper/boost-modular-build.cmake
https://github.com/microsoft/vcpkg/blob/master/ports/openssl-unix/CMakeLists.txt
There was a problem hiding this comment.
Nice those two scripts should be generalized.
A lot of that stuff is actually also required for vcpkg_configure_make and vcpkg_configure_qmake apart form vcpkg_configure_meson
JackBoosY
added
category:tool-update
|
Back to draft until somebody generalized #11543 (comment). |
|
(although meson does not allow to pass a cmake toolchain to the find_dep calls so we probably want to always use pkgconfig if possible |
strega-nil
added
requires:author-response
and removed
info:needs-maintainer-attention
8 participants
add cross file. Use same cmake prefix has vcpkg cmake. Set debug to true or false
closes #11230
(requires mesonbuild/meson#7190 to correctly work)
hmm should I set the crossfile in the triplet instead? any opinions about that?