ignition-msgs5: Add support for cross-compilation by traversaro · Pull Request #11538 · microsoft/vcpkg

traversaro · 2020-05-23T10:42:32Z

What does your PR fix?
This PR enables compilation of the ignition-msgs5 port on triplet that require compilation, i.e. among official supported triplets arm64-windows and arm-uwp .
Which triplets are supported/not supported? Have you updated the CI baseline?
This PR add support for compiling ignition-msgs5 for arm64-windows and arm-uwp, but I did not updated the CI baseline as the port will fail if ignition-msgs5:x86-windows is not installed, and I do not know how this is supposed to be handled at the CI baseline level.
Does your PR follow the maintainer guide?
Yes.

This PR also required some changes in the protobuf ( fd8143b ) and ignition-modularscripts (5405eda) ports, feel free to check the commit messages for more details on those changes.

ports/ignition-modularscripts/CONTROL

ports/ignition-msgs5/CONTROL

NancyLi1013 · 2020-05-26T10:25:21Z

I will test the features later. Once finished, I will update the results.

NancyLi1013 · 2020-05-27T06:11:44Z

The feature has passed with the following triplets:

x86-windows
x64-windows
x64-windows-static

dan-shaw · 2020-06-05T19:25:39Z

@traversaro I just merged a protobuf PR, could you resolve the conflicts?

traversaro · 2020-06-06T07:01:33Z

@traversaro I just merged a protobuf PR, could you resolve the conflicts?

Done.

traversaro · 2020-06-06T07:57:47Z

x86_windows and x64_osx faiures seems to be unrelated, while the arm64-windows fails with the following message:

CMake Error at ports/ignition-msgs5/portfile.cmake:29 (message):
  Cross-targetting ignition-msgs5 requires the x86-windows ignition-msgs5 to
  be available.  Please install ignition-msgs5:x86-windows first.
Call Stack (most recent call first):
  scripts/ports.cmake:76 (include)

That from #11538 (comment) it should be something that instead should be installed in the CI machines.

NancyLi1013 · 2020-06-11T09:01:50Z

@traversaro
Could you please resolve the conflicts?

traversaro · 2020-06-11T14:23:03Z

@traversaro
Could you please resolve the conflicts?

Done.

traversaro · 2020-06-11T15:13:13Z

The arm64-windows failure is due to:

CMake Error at ports/ignition-msgs5/portfile.cmake:29 (message):
Cross-targetting ignition-msgs5 requires the x86-windows ignition-msgs5 to
be available. Please install ignition-msgs5:x86-windows first.
Call Stack (most recent call first):
scripts/ports.cmake:76 (include)

Based on #11538 (comment) , this should be something installed in the CI machines.

NancyLi1013 · 2020-06-15T09:20:19Z

@traversaro
The regression on x64-osx should be fixed in this PR #11616.

CMake Error in src/CMakeLists.txt:
  Imported target "TINYXML2::TINYXML2" includes non-existent path

    "/Volumes/data/work/1/s/packages/tinyxml2_x64-osx/debug/include"

  in its INTERFACE_INCLUDE_DIRECTORIES.  Possible reasons include:

  * The path was deleted, renamed, or moved to another location.

  * An install or uninstall procedure did not complete successfully.

  * The installation package was faulty and references files it does not
  provide.

Could you please merge the latest commit on master to this PR?

traversaro · 2020-06-15T21:33:49Z

Could you please merge the latest commit on master to this PR?

Done.

NancyLi1013 · 2020-06-16T03:02:44Z

Seems it doesn't work. I noticed that this was the same reason with #11616. Could you look into this again?

azure-pipelines · 2020-07-16T02:46:00Z

Azure Pipelines successfully started running 1 pipeline(s).

NancyLi1013 · 2020-07-16T07:47:38Z

It seems the command /azp run doesn't work.

@traversaro
Could you please merge master to retrigger this PR?

traversaro · 2020-07-18T13:57:11Z

It seems the command /azp run doesn't work.

@traversaro
Could you please merge master to retrigger this PR?

I rebased the PR on the top of latest master.

ports/protobuf/CONTROL

traversaro · 2020-08-01T09:57:48Z

Sorry @JackBoosY, I had missed you request change. However, I solved the conflicts w.r.t. to the latest master.

JackBoosY · 2020-08-03T02:42:21Z

Sorry for late, I lost track with this PR.
These changes caused protobuf build failure on uwp triplet, could you fix it?

     6>D:\buildtrees\protobuf\src\dfb7589f92-61fbc4fa5f.clean\src\google\protobuf\compiler\subprocess.cc(104,46): error C2065: 'HANDLE_FLAG_INHERIT': undeclared identifier [D:\buildtrees\protobuf\arm-uwp-dbg\libprotoc.vcxproj]
     6>D:\buildtrees\protobuf\src\dfb7589f92-61fbc4fa5f.clean\src\google\protobuf\compiler\subprocess.cc(105,29): error C2065: 'HANDLE_FLAG_INHERIT': undeclared identifier [D:\buildtrees\protobuf\arm-uwp-dbg\libprotoc.vcxproj]
     6>D:\buildtrees\protobuf\src\dfb7589f92-61fbc4fa5f.clean\src\google\protobuf\compiler\subprocess.cc(109,48): error C2065: 'HANDLE_FLAG_INHERIT': undeclared identifier [D:\buildtrees\protobuf\arm-uwp-dbg\libprotoc.vcxproj]
     6>D:\buildtrees\protobuf\src\dfb7589f92-61fbc4fa5f.clean\src\google\protobuf\compiler\subprocess.cc(110,29): error C2065: 'HANDLE_FLAG_INHERIT': undeclared identifier [D:\buildtrees\protobuf\arm-uwp-dbg\libprotoc.vcxproj]
     6>D:\buildtrees\protobuf\src\dfb7589f92-61fbc4fa5f.clean\src\google\protobuf\compiler\subprocess.cc(119,26): error C2065: 'STARTF_USESTDHANDLES': undeclared identifier [D:\buildtrees\protobuf\arm-uwp-dbg\libprotoc.vcxproj]

NancyLi1013 · 2020-08-14T08:26:49Z

@traversaro
Could you please also resolve the conflicts?

traversaro · 2020-08-21T09:44:26Z

Hi @JackBoosY and @NancyLi1013 , I was away from keyboard for a bit, sorry for the lack of feedback. I will update the PR in the coming days, thanks!

…sscompiling Before this commit, the protobuf portfile when crosscompiling was not defining the protobuf::protoc target in its CMake config files, even if its definition was instead correctly patched in the port to point to the host version of the tool. Furthermore, the protobuf::libprotoc library (that is a library that can also be used in cross-compilation build) was not installed.

… options

Similar to the protobuf case, when cross-compiling it is required that the port is already installed in the host machine triplet, for now just x86-windows as for protobuf.

traversaro · 2020-09-05T09:18:05Z

@traversaro
Could you please also resolve the conflicts?

Hi @NancyLi1013 , the conflicts have been solved. @JackBoosY let's see if the uwp failure are still there, probably there is some upstream protobuf regression regarding compilation of the libprotoc library on uwp.

traversaro · 2020-09-05T10:33:51Z

There are several failures, but they do not seems to be related to this PR.

NancyLi1013 · 2020-09-07T02:25:22Z

/azp run

azure-pipelines · 2020-09-07T02:25:33Z

Azure Pipelines successfully started running 1 pipeline(s).

BillyONeal · 2020-09-07T03:49:05Z

The failures in CI are consistent with a malformed CONTROL file somewhere and they aren't happening outside of this PR. Just in case I pushed a merge with master, we'll see what comes back.

JackBoosY · 2020-10-09T08:10:35Z

/azp run

azure-pipelines · 2020-10-09T08:10:41Z

No pipelines are associated with this pull request.

…tion-msgs-support-crosscompilation

JackBoosY · 2020-10-26T06:29:50Z

@BillyONeal Any progress?

traversaro · 2020-10-31T10:55:56Z

@BillyONeal Any progress?

The failure on this are due to a regression in protobuf, that does not support anymore in the latest version compilation in uwp .
As they are already some active PR in the direction of getting protobuf to correctly cross compile (see #14165), let's try to see if those PR before starting to work again on this one.

traversaro · 2021-01-02T23:16:38Z

Related PR: #15424 .

traversaro mentioned this pull request May 23, 2020

Add CMake options to support cross-compilation gazebosim/gz-msgs#60

Merged

traversaro force-pushed the ignition-msgs-support-crosscompilation branch 4 times, most recently from a48e208 to c8bf0b0 Compare May 24, 2020 08:50

NancyLi1013 self-assigned this May 25, 2020

NancyLi1013 suggested changes May 25, 2020

View reviewed changes

ports/ignition-modularscripts/CONTROL Outdated Show resolved Hide resolved

ports/ignition-msgs5/CONTROL Outdated Show resolved Hide resolved

NancyLi1013 added category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist requires:author-response labels May 25, 2020

NancyLi1013 mentioned this pull request May 26, 2020

[vcpkg] Move CI cleaning back out of the 'ci' command into a separate command to restore cross-compilation preinstalls. #11545

Merged

NancyLi1013 approved these changes May 26, 2020

View reviewed changes

NancyLi1013 added requires:testing and removed requires:author-response labels May 26, 2020

NancyLi1013 added info:needs-maintainer-attention Lets the current 'on rotation' vcpkg maintainer know they need to look at this. and removed requires:testing labels May 27, 2020

dan-shaw approved these changes Jun 5, 2020

View reviewed changes

traversaro force-pushed the ignition-msgs-support-crosscompilation branch from 4a9d4b3 to b155d09 Compare June 6, 2020 07:01

traversaro force-pushed the ignition-msgs-support-crosscompilation branch from 8ecea64 to 3ee8fbc Compare June 11, 2020 14:22

traversaro force-pushed the ignition-msgs-support-crosscompilation branch from 3ee8fbc to ca2defd Compare June 15, 2020 21:33

NancyLi1013 added the requires:author-response label Jul 16, 2020

traversaro force-pushed the ignition-msgs-support-crosscompilation branch from ab802c9 to b2c8e94 Compare July 18, 2020 13:56

JackBoosY suggested changes Jul 20, 2020

View reviewed changes

ports/protobuf/CONTROL Outdated Show resolved Hide resolved

JackBoosY self-assigned this Aug 3, 2020

traversaro added 3 commits September 5, 2020 11:09

ignition-modularscripts: Add options to handle tools and custom CMAke…

cfd98a6

… options

ignition-msgs5: Add support for crosscompilation

6921ebe

Similar to the protobuf case, when cross-compiling it is required that the port is already installed in the host machine triplet, for now just x86-windows as for protobuf.

traversaro force-pushed the ignition-msgs-support-crosscompilation branch 2 times, most recently from 269e79a to 6921ebe Compare September 5, 2020 09:16

Merge remote-tracking branch 'origin/master' into HEAD

ded0872

Merge branch 'master' of https://github.com/microsoft/vcpkg into igni…

fa1b7de

…tion-msgs-support-crosscompilation

traversaro closed this Oct 31, 2020

traversaro mentioned this pull request Nov 4, 2020

[ignition] Updates on various pkgs 🤖 #14324

Merged

Conversation

traversaro commented May 23, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

NancyLi1013 commented May 26, 2020

Uh oh!

NancyLi1013 commented May 27, 2020

Uh oh!

dan-shaw commented Jun 5, 2020

Uh oh!

traversaro commented Jun 6, 2020

Uh oh!

traversaro commented Jun 6, 2020

Uh oh!

NancyLi1013 commented Jun 11, 2020

Uh oh!

traversaro commented Jun 11, 2020

Uh oh!

traversaro commented Jun 11, 2020

Uh oh!

NancyLi1013 commented Jun 15, 2020

Uh oh!

traversaro commented Jun 15, 2020

Uh oh!

NancyLi1013 commented Jun 16, 2020

Uh oh!

azure-pipelines bot commented Jul 16, 2020

Uh oh!

NancyLi1013 commented Jul 16, 2020

Uh oh!

traversaro commented Jul 18, 2020

Uh oh!

Uh oh!

traversaro commented Aug 1, 2020

Uh oh!

JackBoosY commented Aug 3, 2020

Uh oh!

NancyLi1013 commented Aug 14, 2020

Uh oh!

traversaro commented Aug 21, 2020

Uh oh!

traversaro commented Sep 5, 2020

Uh oh!

traversaro commented Sep 5, 2020

Uh oh!

NancyLi1013 commented Sep 7, 2020

Uh oh!

azure-pipelines bot commented Sep 7, 2020

Uh oh!

BillyONeal commented Sep 7, 2020

Uh oh!

JackBoosY commented Oct 9, 2020

Uh oh!

azure-pipelines bot commented Oct 9, 2020

Uh oh!

JackBoosY commented Oct 26, 2020

Uh oh!

traversaro commented Oct 31, 2020

Uh oh!

traversaro commented Jan 2, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

traversaro commented May 23, 2020 •

edited

Loading