Switch default Ninja minimal version to a reasonable value#1897
Merged
BillyONeal merged 1 commit intomicrosoft:mainfrom Jan 12, 2026
Merged
Switch default Ninja minimal version to a reasonable value#1897BillyONeal merged 1 commit intomicrosoft:mainfrom
BillyONeal merged 1 commit intomicrosoft:mainfrom
Conversation
The previous value (3.5.1) doesn't make much sense and it being that broke systems like FreeBSD which didn't have a tool download link.
BillyONeal
approved these changes
Jan 12, 2026
Member
BillyONeal
left a comment
BillyONeal
left a comment
There was a problem hiding this comment.
Wow, 8 year old copy pasto (3.5.1 is the minimal git version) from e6442b0
Contributor
Which means that this code is probably unused and should be removed. |
Member
It was unused because most platforms have a different value filled in from |
bsdcode
added a commit
to bsdcode/Ymir
that referenced
this pull request
Jan 29, 2026
Recent vcpkg switched to using "vcpkg fetch ninja" for providing Ninja to the build. This exposed a long-standing bug in the underlying vcpkg- tool, which tried to find Ninja with an unreasonable version number on platforms without a tool download link for Ninja. This broke the Ymir build on FreeBSD. Although this bug is already fixed in the master branch of vcpkg-tool, there isn't a tagged release with the fix yet and vcpkg itself still references the vcpkg-tool without the fix. To unbreak the Ymir build on FreeBSD, a patch is provided which points vcpkg to the first vcpkg-tool commit containing the fix. This patch is applied in the CI and istructions are given in COMPILING.md. References: microsoft/vcpkg#49242 microsoft/vcpkg-tool#1897 microsoft/vcpkg-tool@9cf284d
bsdcode
added a commit
to bsdcode/Ymir
that referenced
this pull request
Jan 29, 2026
Recent vcpkg switched to using "vcpkg fetch ninja" for providing Ninja to the build. This exposed a long-standing bug in the underlying vcpkg- tool, which tried to find Ninja with an unreasonable version number on platforms without a tool download link for Ninja. This broke the Ymir build on FreeBSD. Although this bug is already fixed in the master branch of vcpkg-tool, there isn't a tagged release with the fix yet and vcpkg itself still references the vcpkg-tool without the fix. To unbreak the Ymir build on FreeBSD, a patch is provided which points vcpkg to the first vcpkg-tool commit containing the fix. This patch is applied in the CI and instructions are given in COMPILING.md. References: microsoft/vcpkg#49242 microsoft/vcpkg-tool#1897 microsoft/vcpkg-tool@9cf284d
BillyONeal
added a commit
to BillyONeal/vcpkg
that referenced
this pull request
Feb 18, 2026
https://github.com/microsoft/vcpkg-tool/releases/tag/2026-02-17 Meaningful changes: * Test/fix internal dependencies in top level manifest. by @dg0yt in microsoft/vcpkg-tool#1890 * dependencies.cpp optimizations by @dg0yt in microsoft/vcpkg-tool#1891 * Switch default Ninja minimal version to a reasonable value by @cqundefine in microsoft/vcpkg-tool#1897 * Install files in parallel, redux by @BillyONeal in microsoft/vcpkg-tool#1896 * [tools] Fix missing executable permission on downloaded tools for Unix by @zynfly in microsoft/vcpkg-tool#1911 * Use libcurl rather than curl command line by @BillyONeal in microsoft/vcpkg-tool#1906 * Deduplicate "additional_file" in abi info. by @BillyONeal in microsoft/vcpkg-tool#1914 * Clamp invalid elapsed time instead of crashing in track_elapsed_us by @clee704 in microsoft/vcpkg-tool#1918
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous value (3.5.1) doesn't make much sense and it being that broke systems like FreeBSD which didn't have a tool download link.
This also comes with a question, while this solves the problem for now, what would be a more reasonable solution to keep the minimum versions in sync for all those platforms (like RISC-V Linux, *BSD, Solaris and more) that will most probably never have all download links added, should there a be separate JSON file listing minimal versions, should all those platforms get spoofed to x64 Linux for version checks or maybe something entirely else.