Clamp invalid elapsed time instead of crashing in track_elapsed_us#1918
Merged
BillyONeal merged 1 commit intomicrosoft:mainfrom Feb 13, 2026
Merged
Conversation
When high_resolution_clock goes backwards (e.g. in VMs/containers), track_elapsed_us() receives a negative value and hits Checks::unreachable, crashing vcpkg. Clamp negative and non-finite values to 0.0 instead, which causes the metric to be silently skipped in the JSON payload. Fixes microsoft#1907
clee704
force-pushed
the
fix/clamp-negative-elapsed-time
branch
from
0c0b5f0 to
61a9940
Compare
BillyONeal
added a commit
to BillyONeal/vcpkg
that referenced
this pull request
Feb 18, 2026
https://github.com/microsoft/vcpkg-tool/releases/tag/2026-02-17 Meaningful changes: * Test/fix internal dependencies in top level manifest. by @dg0yt in microsoft/vcpkg-tool#1890 * dependencies.cpp optimizations by @dg0yt in microsoft/vcpkg-tool#1891 * Switch default Ninja minimal version to a reasonable value by @cqundefine in microsoft/vcpkg-tool#1897 * Install files in parallel, redux by @BillyONeal in microsoft/vcpkg-tool#1896 * [tools] Fix missing executable permission on downloaded tools for Unix by @zynfly in microsoft/vcpkg-tool#1911 * Use libcurl rather than curl command line by @BillyONeal in microsoft/vcpkg-tool#1906 * Deduplicate "additional_file" in abi info. by @BillyONeal in microsoft/vcpkg-tool#1914 * Clamp invalid elapsed time instead of crashing in track_elapsed_us by @clee704 in microsoft/vcpkg-tool#1918
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
track_elapsed_us()crashes withChecks::unreachablewhen it receives a negative or non-finite elapsed time value. This can happen in containerized/VM environments wherestd::chrono::high_resolution_clockgoes backwards (e.g. due to NTP adjustments).Changes
src/vcpkg/metrics.cpp: Replace theChecks::unreachablecall with clamping to0.0for negative and non-finite values. Since downstream serialization already skipselapsed_us == 0.0, the invalid metric is silently omitted from the JSON payload rather than crashing.src/vcpkg-test/metrics.cpp: Added tests covering negative, NaN, ±infinity, valid positive, and zero inputs.Fixes #1907