Reapply "[vcpkg scripts] Use vcpkg fetch for available tools" (#48986)#49242
Merged
vicroms merged 2 commits intomicrosoft:masterfrom Jan 7, 2026
Merged
Reapply "[vcpkg scripts] Use vcpkg fetch for available tools" (#48986)#49242vicroms merged 2 commits intomicrosoft:masterfrom
vicroms merged 2 commits intomicrosoft:masterfrom
Conversation
…oft#48986) This reverts commit 7499ac9. # Conflicts: # scripts/cmake/vcpkg_find_acquire_program(GIT).cmake
vicroms
previously approved these changes
Jan 6, 2026
…etch` to being errors.
Member
Author
|
With some help from @AenBleidd showing that it happened even without the misconfiguration I got a repro on Arch. On Arch, the error variable had 'no such file or directory' and I think that is because That is fixed in b458d22 |
Member
Author
|
@AenBleidd told me over discord that this works for them so I'm saying that this fixes the issue. |
vicroms
approved these changes
Jan 7, 2026
bsdcode
added a commit
to bsdcode/Ymir
that referenced
this pull request
Jan 29, 2026
Recent vcpkg switched to using "vcpkg fetch ninja" for providing Ninja to the build. This exposed a long-standing bug in the underlying vcpkg- tool, which tried to find Ninja with an unreasonable version number on platforms without a tool download link for Ninja. This broke the Ymir build on FreeBSD. Although this bug is already fixed in the master branch of vcpkg-tool, there isn't a tagged release with the fix yet and vcpkg itself still references the vcpkg-tool without the fix. To unbreak the Ymir build on FreeBSD, a patch is provided which points vcpkg to the first vcpkg-tool commit containing the fix. This patch is applied in the CI and istructions are given in COMPILING.md. References: microsoft/vcpkg#49242 microsoft/vcpkg-tool#1897 microsoft/vcpkg-tool@9cf284d
bsdcode
added a commit
to bsdcode/Ymir
that referenced
this pull request
Jan 29, 2026
Recent vcpkg switched to using "vcpkg fetch ninja" for providing Ninja to the build. This exposed a long-standing bug in the underlying vcpkg- tool, which tried to find Ninja with an unreasonable version number on platforms without a tool download link for Ninja. This broke the Ymir build on FreeBSD. Although this bug is already fixed in the master branch of vcpkg-tool, there isn't a tagged release with the fix yet and vcpkg itself still references the vcpkg-tool without the fix. To unbreak the Ymir build on FreeBSD, a patch is provided which points vcpkg to the first vcpkg-tool commit containing the fix. This patch is applied in the CI and instructions are given in COMPILING.md. References: microsoft/vcpkg#49242 microsoft/vcpkg-tool#1897 microsoft/vcpkg-tool@9cf284d
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 7499ac9 ( #48986 ).
The issue that forced that revert for the holidays ( #48973 ) appears to be caused by a misconfiguration where an old vcpkg is used with a new scripts tree (or vice versa). We're working to make that misconfiguration less likely to happen but now that folks are back from the holidays this should be landed.
Fixes #48973