Merged
Conversation
Recent vcpkg switched to using "vcpkg fetch ninja" for providing Ninja to the build. This exposed a long-standing bug in the underlying vcpkg- tool, which tried to find Ninja with an unreasonable version number on platforms without a tool download link for Ninja. This broke the Ymir build on FreeBSD. Although this bug is already fixed in the master branch of vcpkg-tool, there isn't a tagged release with the fix yet and vcpkg itself still references the vcpkg-tool without the fix. To unbreak the Ymir build on FreeBSD, a patch is provided which points vcpkg to the first vcpkg-tool commit containing the fix. This patch is applied in the CI and instructions are given in COMPILING.md. References: microsoft/vcpkg#49242 microsoft/vcpkg-tool#1897 microsoft/vcpkg-tool@9cf284d
This adds the missing dependency libXtst and removes the explicit PKG_CONFIG_PATH setup. This was fixed by upstream vcpkg.
Ymir's commit 51fe01b removes the need for this precaution. Ymir will now startup and initialize successfully even if alsa-libs were installed during compilation.
Owner
|
Thanks! I was hoping you'd help out with this. I did take some time to try to understand the issue, but my complete lack of knowledge on FreeBSD stopped me from going further than noticing the strange version requirement for The RtMidi workaround was implemented because Ymir stopped working under WSL, which is how I usually test the Linux version. I'm glad this also helps eliminate a workaround for the FreeBSD version, and it should also fix problems with other systems that have incomplete or broken ALSA setups. |
Contributor
Author
|
No Problem! I was also VERY confused by this version error message :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
build: fix vcpkg fetch ninja on FreeBSD
Recent vcpkg switched to using "vcpkg fetch ninja" for providing Ninja to the build. This exposed a long-standing bug in the underlying vcpkg-tool, which tried to find Ninja with an unreasonable version number on platforms without a tool download link for Ninja. This broke the Ymir build on FreeBSD.
Although this bug is already fixed in the master branch of vcpkg-tool, there isn't a tagged release with the fix yet and vcpkg itself still references the vcpkg-tool without the fix.
To unbreak the Ymir build on FreeBSD, a patch is provided which points vcpkg to the first vcpkg-tool commit containing the fix. This patch is applied in the CI and instructions are given in
COMPILING.md.References:
microsoft/vcpkg#49242
microsoft/vcpkg-tool#1897
microsoft/vcpkg-tool@9cf284d
I put the patch inside the
cmakefolder while I'm not sure if this is the best place. Hopefully this patch isn't needed for long and vcpkg makes a proper release with the fix included.build: fix SDL3 build on FreeBSD
This adds the missing dependency
libXtstand removes the explicitPKG_CONFIG_PATHsetup. This was fixed by upstream vcpkg.docs: remove RtMidi note on FreeBSD
Ymir's commit 51fe01b removes the need for this precaution. Ymir will now startup and initialize successfully
even if
alsa-libswere installed during compilation.