-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistent/incorrect translations in Spanish localization for settings #12665
Comments
I like nit-picking at Spanish localizations. I would go through all the strings, but I couldn't find the resources file. |
Thanks for these suggestions! If you want to go through and nitpick more, the English strings are all listed in |
When filing these as an issue I need to file them as "English source string with key X (was translated as Y but) should be translated as Z" (see #14293 for instance). While it's extremely valuable that you brought up these issues, to be entirely frank, I'm unable to effectively submit them to the localization team. That aside, you also brought up two issues that are unrelated to the localization and need to be fixed by us independently:
I'll try to address them both in the near term. But I'm not sure what to do about the localization though... |
If you can point me to the localized .resw file, I can do that. I know it's not checked in, but maybe it's an artifact in some internal pipeline? |
Here's a dump of the latest localization as of yesterday: LocOutput.zip
At this point I should probably mention that we've been wishing for a way where we could properly accept community translations via GitHub. 🥲 Unfortunately we haven't had time to further pursue this and internally there's no real support for this either (nor is support planned by the localization team). |
Thanks. I'll go through it when I have some time :)
On winget-cli what we do is that we have the localized resource files checked in on the repository, so when someone has a suggestion they usually make a PR with the changes. We can't accept them there, but when we file a bug against the localization team to consider, we can just point them to the PR and there it's clear which string IDs are replaced by what text |
Oh... and you automatically merge any changes coming from the localization team into the repository? That's clever! I think we should do this too... |
Well, not automatically. We have a loc pipeline that we run manually to query the loc changes and produces a git patch. We then apply it and send the changes as a PR. Not sure why it was set up that way, maybe to avoid noise from frequent PRs. I think we only have to run that pipeline twice per release, once to send the new strings and once to get the updated translations. |
@florelis You have a link to how that works? We've been very curious about this topic, see: #10667 (comment) If we had the localizations from the pipeline just... checked in, then we'd be able to accept community translations? This might be a BIG deal |
Checked in resources in winget-cli repo: https://github.com/microsoft/winget-cli/tree/master/Localization/Resources Localization pipeline definition: https://github.com/microsoft/winget-cli/blob/master/azure-pipelines.loc.yml We do get suggestions for translation improvements from the community, like microsoft/winget-cli#3044 |
Maybe you already know, but there's some weirdness in the paths there. The resources for each locale seem to be inside the en-us folder, when they probably should be next to it. For example, there is |
Ohhhhh yes, this is by design according to the TDBuild folks. We have a build phase to move them about :| |
|
Internally filed as GCS-553438 in the |
Windows Terminal version
1.13.10395.0
Windows build number
10.0.22572.0
Other Software
No response
Steps to reproduce
Use Terminal in Spanish, then go to Configuración -> Acciones (Settings -> Actions)
Expected Behavior
No response
Actual Behavior
Some items are translated inconsistently or incorrectly.
Most actions use infinitive verbs, but some use imperative: "Cierre la ventana" should be "Cerrar ventana", "Desplácese hacia arriba una página" should be "Desplazarse hacia arriba una página" (likewise for "abajo").
Some ambiguous words are translated as nouns instead of verbs:
I would suggest adding notes for the localization team on all items like these that can be understood in multiple ways.
Next/Previous Tab are translated as "Pestaña anterior" and "Siguiente pestaña" (different order); I'd prefer "Pestaña siguiente" for consistency.
I also noticed that the sorting of the list for picking actions puts the lowercase items at the bottom, so it goes A...Za..z. I would expect it to be Aa...Zz.
The text was updated successfully, but these errors were encountered: