Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

inconsistent capitalization in Italian profile menu tooltip #12712

Closed
KalleOlaviNiemitalo opened this issue Mar 17, 2022 · 7 comments · Fixed by #17304
Closed

inconsistent capitalization in Italian profile menu tooltip #12712

KalleOlaviNiemitalo opened this issue Mar 17, 2022 · 7 comments · Fixed by #17304
Labels
Area-Localization Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.21

Comments

@KalleOlaviNiemitalo
Copy link

KalleOlaviNiemitalo commented Mar 17, 2022 •
edited
Loading

Windows Terminal version

1.13.10395.0

Windows build number

10.0.19044.1586

Other Software

No response

Steps to reproduce

Configure Windows Terminal Preview to display in the Italian language.
Press Ctrl+Shift+Space to open the profile menu.
Wait a second and look at the tool tip that pops up.

Expected Behavior

Consistent capitalization and spacing.

Actual Behavior

The tool tip has inconsistent capitalization and spacing:

Apri nuova scheda
ALT + clic per dividere la finestra corrente
MAIUSC+clic per aprire una nuova finestra
CTRL+Clic per aprire come amministratore

"Alt + clic" has spaces around the plus sign, but "MAIUSC+clic" and "CTRL+Clic" don't.

"CTRL+Clic" capitalizes "Clic", but "Alt + clic" and "MAIUSC+clic" don't.
@KalleOlaviNiemitalo KalleOlaviNiemitalo added the Issue-Bug It either shouldn't be doing this or needs an investigation. label Mar 17, 2022
@ghost ghost added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Mar 17, 2022
@ritikBhandari
Copy link

hi,
Can i resolve this issue?

@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Area-Localization Priority-3 A description (P3) labels Mar 17, 2022
@ghost ghost removed the Needs-Tag-Fix Doesn't match tag requirements label Mar 17, 2022
@zadjii-msft
Copy link
Member

I wish we had a story for allowing people to contribute to our localization directly - that would save so much headache. Unfortunately, I don't think our CI is really set up to support that at the moment. We'll need to submit a request to our localization team to get these strings updated manually.

(kind of wild that it was already localized like this 🙃)

Thanks for the offer!

@ritikBhandari
Copy link

No worries. Thank u :)

@zadjii-msft zadjii-msft removed the Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting label Apr 26, 2022
@KalleOlaviNiemitalo
Copy link
Author

The problem persists in 1.18.2822.0.

@lhecker lhecker self-assigned this Nov 27, 2023
@lhecker lhecker added this to the Terminal v1.20 milestone Nov 27, 2023
@lhecker
Copy link
Member

lhecker commented May 17, 2024 •
edited by DHowett
Loading

Filed internally as GCS-553414 in the GlobalCollaborationService project.

@lhecker lhecker removed their assignment May 17, 2024
@DHowett DHowett mentioned this issue May 23, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue May 28, 2024
@consvc
Localization Updates - fix issues in Korean, Italian, Spanish (#17304)
13de7c6 
Closes #12665 
Closes #12712 
Closes #16867
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label May 28, 2024
DHowett pushed a commit that referenced this issue Jun 7, 2024
@consvc @DHowett
Localization Updates - fix issues in Korean, Italian, Spanish (#17304)
72596d9 
Closes #12665
Closes #12712
Closes #16867

(cherry picked from commit 13de7c6)
Service-Card-Id: 92614019
Service-Version: 1.20
DHowett pushed a commit that referenced this issue Jun 7, 2024
@consvc @DHowett
Localization Updates - fix issues in Korean, Italian, Spanish (#17304)
3e661bf 
Closes #12665
Closes #12712
Closes #16867

(cherry picked from commit 13de7c6)
Service-Card-Id: 92614020
Service-Version: 1.21
@KalleOlaviNiemitalo
Copy link
Author

Verified that this is fixed in Terminal 1.20.11781.0.
image

@DHowett
Copy link
Member

DHowett commented Jul 13, 2024

Thanks for confirming!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Localization Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Priority-3 A description (P3) Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.21
Development

Successfully merging a pull request may close this issue.

Localization Updates - fix issues in Korean, Italian, Spanish microsoft/terminal
5 participants
@DHowett @lhecker @zadjii-msft @KalleOlaviNiemitalo @ritikBhandari