Skip to content

Conversation

@agg23
Copy link
Contributor

@agg23 agg23 commented Jun 3, 2025

Fixes #36162.

The JavaScript URL constructor uses any non-scheme colon to indicate the URL hostname, such as with about:blank. This was regressed in #34923, which hides the current value of the URL "path" from the URL constructor. Add a specific check for this case.

This will require similar handling in the ports.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@agg23 agg23 requested a review from yury-s June 4, 2025 11:57
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions
Copy link
Contributor

github-actions bot commented Jun 4, 2025

Test results for "tests 1"

4 flaky ⚠️ [firefox-library] › library/inspector/cli-codegen-1.spec.ts:986:7 › cli codegen › should not throw csp directive violation errors @firefox-ubuntu-22.04-node18
⚠️ [firefox-page] › page/page-wait-for-function.spec.ts:104:3 › should work with strict CSP policy @firefox-ubuntu-22.04-node18
⚠️ [webkit-library] › library/trace-viewer.spec.ts:784:1 › should handle src=blob @webkit-ubuntu-22.04-node18
⚠️ [playwright-test] › ui-mode-test-watch.spec.ts:145:5 › should watch all @windows-latest-node18-1

39302 passed, 818 skipped
✔️✔️✔️

Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Page.waitForURL('about:blank') fails if baseURL configured

2 participants